> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote: > > jdbc/connectors/gaian/GaianJDBCConnector.java > > Lines 21 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line21> > > > > I would think that host, port, database name, user and password should > > all be configurable. > > Yao Li wrote: > do you mean there should be a seperate configuration file?
already put all these settings into a properties file > On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote: > > jdbc/connectors/gaian/GaianJDBCConnector.java > > Lines 51 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line51> > > > > Beware literal forward-slash characters - they may not work on Windows. > > However, this is not always the case - things like the java classloaders > > take the forward-slash path separators even on Windows, so it depends on > > the specific sub-system we are providing the path/URI to. > > It seems that REST URIs and resource file paths (which we will pass to > > classloaders) are OK with '/' separators. I am not sure what will work for > > the DB connection. > > Yao Li wrote: > i tested on windows and it works properly. I will keep this issue in mind. it is only used to form a jdbc url, will to send to Gaian.so it should not be a problem. - Yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195710 ----------------------------------------------------------- On Jan. 31, 2018, 12:08 p.m., Yao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65123/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 12:08 p.m.) > > > Review request for atlas and Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Because some issues with uploading the patch, the new review will be shown on > [https://reviews.apache.org/r/65435/](https://reviews.apache.org/r/65435/), > and this page will not be updated anymore. > > The OCF Database Connector is the subclass of OCF Connector and it is > designed especially for connection to database to retrieve data. > Here we implement a connector for Gaian (GaianOCFConnector) as an example for > using OCF Database Connector. It is related to Open Connector Framework. The > JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298 > > > Diffs > ----- > > ocfdb/README.md > ocfdb/pom.xml > ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java > > ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java > > > ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java > > > > Diff: https://reviews.apache.org/r/65123/diff/5/ > > > Testing > ------- > > create an instance of the Connector and use getData() function. Gaian has to > be set up in advance. > > > File Attachments > ---------------- > > ATLAS-2298-update-patch-based-on-reviews.patch > > https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch > ATLAS-2298-update-patch-based-on-reviews.patch > > https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch > ATLAS-2298-update-the-patch-29-1.patch > > https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch > ATLAS-2298-update-the-patch-29-1.patch > > https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch > ATLAS-2298-30-Jan-review-verision.patch > > https://reviews.apache.org/media/uploaded/files/2018/01/30/b4282020-0ef5-41bc-82d2-a0e0d64d592b__ATLAS-2298-30-Jan-review-verision.patch > > > Thanks, > > Yao Li > >
