Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 16, 2018, 1:48 p.m., Graham Wallis wrote: > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java > > Lines 231 (patched) > > > > > > We also need a method for the L

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ --- (Updated May 17, 2018, 2:56 p.m.) Review request for atlas, Daniela Otelea, Dav

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203328 --- omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationF

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ --- (Updated May 17, 2018, 12:10 p.m.) Review request for atlas, Daniela Otelea, Da

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 11, 2018, 10:34 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java > > Line 291 (original), 291 (patched) > > > > > > I thought we were talking of > >

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 11, 2018, 10:05 a.m., David Radley wrote: > > omag-server/src/main/resources/application.properties > > Lines 1 (patched) > > > > > > This file causes the Atlas build to fail with a rat check. I am not > > su

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203262 --- omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203261 --- omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203260 --- omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 11, 2018, 10:34 a.m., David Radley wrote: > > omag-server/src/main/java/org/apache/atlas/omag/application/OMAGServerAdminResource.java > > Lines 510 (patched) > > > > > > OMAGInvalidParameterException is a c

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ --- (Updated May 16, 2018, 3:49 p.m.) Review request for atlas, Daniela Otelea, Dav

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

Cc: Bogdan Sava , atlas Date: 16/05/2018 14:52 Subject:Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas Sent by:Graham Wallis This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ Hi Bogdan I just raised 3

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 16, 2018, 1:48 p.m., Graham Wallis wrote: > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java > > Lines 231 (patched) > > > > > > We also need a method for the L

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 15, 2018, 3:53 p.m., David Radley wrote: > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java > > Lines 1143 (patched) > > > > > > javadoc of exceptions mismatches

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 15, 2018, 3:53 p.m., David Radley wrote: > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java > > Line 230 (original), 211 (patched) > > > > > > this

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 15, 2018, 3:53 p.m., David Radley wrote: > > omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java > > Line 180 (original), 181 (patched) > > > > > > you have remove the throws cla

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 15, 2018, 3:53 p.m., David Radley wrote: > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java > > Line 230 (original), 211 (patched) > > > > > > this

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203220 --- Hi Bogdan I just raised 3 issues - but they are all related. The

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203219 --- omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203132 --- omag-api/pom.xml Line 42 (original), 42 (patched)

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203130 --- omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdmi

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ --- (Updated May 15, 2018, 1:35 p.m.) Review request for atlas, Daniela Otelea, Dav

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 14, 2018, 11:25 a.m., Nigel Jones wrote: > > omag-api/pom.xml > > Line 46 (original) > > > > > > I wonder why we went with 1.5.7 of springboot? I know we want to match > > up SPRING versions (which maps to 4

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ --- (Updated May 14, 2018, 7 p.m.) Review request for atlas, Daniela Otelea, David

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

> On May 14, 2018, 9:59 a.m., David Radley wrote: > > omrs/pom.xml > > Line 42 (original) > > > > > > I applied the fix and build atlas using : > > mvn clean -DskipTests install -Pdist,embedded-hbase-solr > >

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/ --- (Updated May 14, 2018, 1:12 p.m.) Review request for atlas, Daniela Otelea, Dav