Re: Review Request 72441: Support solr in standalone (http) mode

[Damian Warszawski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/
---

(Updated May 26, 2020, 9:58 a.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
Subramanian.


Changes
---

setting default value for solr mode to cloud


Repository: atlas


Description
---

Atlas does not support running Solr in standalone(http) mode.

It is especially useful for testing purposes to make setup as simple as 
possible without Zookeeper. It also enables full integration with JanusGraph as 
it support both mode of running Solr `cloud` and `http` 
https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
decouple hbase and solr while running embedded mode so that solr can be run in 
embbeded mode with external hbase.

Proposed solution

call solr V1 API  while creating/updating request handlers in standalone solr
update atlas start script to enable standalone embedded solr

Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
Patch was applied against master branch


Diffs (updated)
-

  distro/src/bin/atlas_config.py f09026ff9 
  docs/src/documents/Setup/InstallationInstruction.md d1b22d624 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
 ba65f3d00 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
484c161f0 


Diff: https://reviews.apache.org/r/72441/diff/4/

Changes: https://reviews.apache.org/r/72441/diff/3-4/


Testing
---

Patch was applied and verified on our dev env with embedded solr and external 
hbase.


Thanks,

Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/#review220857
---


Fix it, then Ship it!





graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java
Lines 224 (patched)


Consider using Model.CLOUD as the default, to avoid potential break to 
existing code path. Note that 
AtlasJanusGraphIndexClient.performRequestHandlerAction() now throws 
IllegalArgumentException for null returns from here.


- Madhan Neethiraj


On May 25, 2020, 8:40 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72441/
> ---
> 
> (Updated May 25, 2020, 8:40 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas does not support running Solr in standalone(http) mode.
> 
> It is especially useful for testing purposes to make setup as simple as 
> possible without Zookeeper. It also enables full integration with JanusGraph 
> as it support both mode of running Solr `cloud` and `http` 
> https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
> decouple hbase and solr while running embedded mode so that solr can be run 
> in embbeded mode with external hbase.
> 
> Proposed solution
> 
> call solr V1 API  while creating/updating request handlers in standalone solr
> update atlas start script to enable standalone embedded solr
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
> Patch was applied against master branch
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py f09026ff9 
>   docs/src/documents/Setup/InstallationInstruction.md d1b22d624 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
>  ba65f3d00 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 484c161f0 
> 
> 
> Diff: https://reviews.apache.org/r/72441/diff/3/
> 
> 
> Testing
> ---
> 
> Patch was applied and verified on our dev env with embedded solr and external 
> hbase.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72441: Support solr in standalone (http) mode

[Damian Warszawski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/
---

(Updated May 25, 2020, 8:40 a.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
Subramanian.


Changes
---

fix markdown issues


Repository: atlas


Description
---

Atlas does not support running Solr in standalone(http) mode.

It is especially useful for testing purposes to make setup as simple as 
possible without Zookeeper. It also enables full integration with JanusGraph as 
it support both mode of running Solr `cloud` and `http` 
https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
decouple hbase and solr while running embedded mode so that solr can be run in 
embbeded mode with external hbase.

Proposed solution

call solr V1 API  while creating/updating request handlers in standalone solr
update atlas start script to enable standalone embedded solr

Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
Patch was applied against master branch


Diffs (updated)
-

  distro/src/bin/atlas_config.py f09026ff9 
  docs/src/documents/Setup/InstallationInstruction.md d1b22d624 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
 ba65f3d00 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
484c161f0 


Diff: https://reviews.apache.org/r/72441/diff/3/

Changes: https://reviews.apache.org/r/72441/diff/2-3/


Testing
---

Patch was applied and verified on our dev env with embedded solr and external 
hbase.


Thanks,

Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

[Damian Warszawski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/
---

(Updated May 19, 2020, 10:02 p.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
Subramanian.


Changes
---

modified installation instruction


Repository: atlas


Description
---

Atlas does not support running Solr in standalone(http) mode.

It is especially useful for testing purposes to make setup as simple as 
possible without Zookeeper. It also enables full integration with JanusGraph as 
it support both mode of running Solr `cloud` and `http` 
https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
decouple hbase and solr while running embedded mode so that solr can be run in 
embbeded mode with external hbase.

Proposed solution

call solr V1 API  while creating/updating request handlers in standalone solr
update atlas start script to enable standalone embedded solr

Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
Patch was applied against master branch


Diffs (updated)
-

  distro/src/bin/atlas_config.py f09026ff9 
  docs/src/documents/Setup/InstallationInstruction.md d1b22d624 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
 ba65f3d00 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
484c161f0 


Diff: https://reviews.apache.org/r/72441/diff/2/

Changes: https://reviews.apache.org/r/72441/diff/1-2/


Testing
---

Patch was applied and verified on our dev env with embedded solr and external 
hbase.


Thanks,

Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

[Damian Warszawski]

> On May 6, 2020, 7:06 p.m., Sarath Subramanian wrote:
> > can you add a small readme or doc on steps to start atlas with standalone 
> > solr (http) and attach it to JIRA.

Modified installation instruction. Please have a look on latest patch.


- Damian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/#review220661
---


On May 19, 2020, 10:02 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72441/
> ---
> 
> (Updated May 19, 2020, 10:02 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas does not support running Solr in standalone(http) mode.
> 
> It is especially useful for testing purposes to make setup as simple as 
> possible without Zookeeper. It also enables full integration with JanusGraph 
> as it support both mode of running Solr `cloud` and `http` 
> https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
> decouple hbase and solr while running embedded mode so that solr can be run 
> in embbeded mode with external hbase.
> 
> Proposed solution
> 
> call solr V1 API  while creating/updating request handlers in standalone solr
> update atlas start script to enable standalone embedded solr
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
> Patch was applied against master branch
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py f09026ff9 
>   docs/src/documents/Setup/InstallationInstruction.md d1b22d624 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
>  ba65f3d00 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 484c161f0 
> 
> 
> Diff: https://reviews.apache.org/r/72441/diff/2/
> 
> 
> Testing
> ---
> 
> Patch was applied and verified on our dev env with embedded solr and external 
> hbase.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72441: Support solr in standalone (http) mode

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/#review220661
---



can you add a small readme or doc on steps to start atlas with standalone solr 
(http) and attach it to JIRA.


graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 40 (patched)


nit: unused imports in line 40 and 41. consider removing it


- Sarath Subramanian


On April 29, 2020, 3:32 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72441/
> ---
> 
> (Updated April 29, 2020, 3:32 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas does not support running Solr in standalone(http) mode.
> 
> It is especially useful for testing purposes to make setup as simple as 
> possible without Zookeeper. It also enables full integration with JanusGraph 
> as it support both mode of running Solr `cloud` and `http` 
> https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
> decouple hbase and solr while running embedded mode so that solr can be run 
> in embbeded mode with external hbase.
> 
> Proposed solution
> 
> call solr V1 API  while creating/updating request handlers in standalone solr
> update atlas start script to enable standalone embedded solr
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
> Patch was applied against master branch
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py f09026ff9 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
>  ba65f3d00 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 484c161f0 
> 
> 
> Diff: https://reviews.apache.org/r/72441/diff/1/
> 
> 
> Testing
> ---
> 
> Patch was applied and verified on our dev env with embedded solr and external 
> hbase.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72441: Support solr in standalone (http) mode

[Damian Warszawski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/
---

(Updated April 29, 2020, 10:32 a.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
Subramanian.


Changes
---

Added reference to jira.


Repository: atlas


Description (updated)
---

Atlas does not support running Solr in standalone(http) mode.

It is especially useful for testing purposes to make setup as simple as 
possible without Zookeeper. It also enables full integration with JanusGraph as 
it support both mode of running Solr `cloud` and `http` 
https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
decouple hbase and solr while running embedded mode so that solr can be run in 
embbeded mode with external hbase.

Proposed solution

call solr V1 API  while creating/updating request handlers in standalone solr
update atlas start script to enable standalone embedded solr

Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
Patch was applied against master branch


Diffs
-

  distro/src/bin/atlas_config.py f09026ff9 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
 ba65f3d00 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
484c161f0 


Diff: https://reviews.apache.org/r/72441/diff/1/


Testing
---

Patch was applied and verified on our dev env with embedded solr and external 
hbase.


Thanks,

Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

[Damian Warszawski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/
---

(Updated April 28, 2020, 8:58 p.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
Subramanian.


Repository: atlas


Description
---

Atlas does not support running Solr in standalone(http) mode.

It is especially useful for testing purposes to make setup as simple as 
possible without Zookeeper. It also enables full integration with JanusGraph as 
it support both mode of running Solr `cloud` and `http` 
https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
decouple hbase and solr while running embedded mode so that solr can be run in 
embbeded mode with external hbase.

Proposed solution

call solr V1 API  while creating/updating request handlers in standalone solr
update atlas start script to enable standalone embedded solr


Diffs
-

  distro/src/bin/atlas_config.py f09026ff9 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
 ba65f3d00 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
484c161f0 


Diff: https://reviews.apache.org/r/72441/diff/1/


Testing
---

Patch was applied and verified on our dev env with embedded solr and external 
hbase.


Thanks,

Damian Warszawski