Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2023-08-24 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated Aug. 24, 2023, 9:38 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0 
  distro/src/bin/atlas_config.py 31e6fd043 
  distro/src/bin/atlas_start.py ffbe16271 
  distro/src/conf/atlas-application.properties b5734d7a8 
  distro/src/test/python/scripts/TestMetadata.py b813f927f 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
8a8e8cafc 


Diff: https://reviews.apache.org/r/73249/diff/11/

Changes: https://reviews.apache.org/r/73249/diff/10-11/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2023-08-17 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review225658
---




distro/src/bin/atlas_config.py
Lines 737 (patched)


get_solr_collection_name



distro/src/conf/atlas-application.properties
Lines 289 (patched)


#289  to #292 duplicate configs



distro/src/conf/atlas-application.properties
Lines 290 (patched)


Can you modify configs like
atlas.index.name.vertex.index=



intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Lines 82 (patched)


What error do we get, if after deploying Atlas, collection names are 
changed?


- Pinal Shah


On Aug. 9, 2023, 6:38 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated Aug. 9, 2023, 6:38 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0 
>   distro/src/bin/atlas_config.py 31e6fd043 
>   distro/src/bin/atlas_start.py ffbe16271 
>   distro/src/conf/atlas-application.properties b5734d7a8 
>   distro/src/test/python/scripts/TestMetadata.py b813f927f 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea 
>   repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
> PRE-CREATION 
>   
> tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java
>  8a8e8cafc 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/10/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2023-08-09 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated Aug. 9, 2023, 6:38 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0 
  distro/src/bin/atlas_config.py 31e6fd043 
  distro/src/bin/atlas_start.py ffbe16271 
  distro/src/conf/atlas-application.properties b5734d7a8 
  distro/src/test/python/scripts/TestMetadata.py b813f927f 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
8a8e8cafc 


Diff: https://reviews.apache.org/r/73249/diff/10/

Changes: https://reviews.apache.org/r/73249/diff/9-10/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2023-08-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated Aug. 8, 2023, 11:36 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0 
  distro/src/bin/atlas_config.py 31e6fd043 
  distro/src/bin/atlas_start.py ffbe16271 
  distro/src/conf/atlas-application.properties b5734d7a8 
  distro/src/test/python/scripts/TestMetadata.py b813f927f 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
8a8e8cafc 


Diff: https://reviews.apache.org/r/73249/diff/9/


Testing (updated)
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2023-08-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated Aug. 8, 2023, 11:14 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0 
  distro/src/bin/atlas_config.py 31e6fd043 
  distro/src/bin/atlas_start.py ffbe16271 
  distro/src/conf/atlas-application.properties b5734d7a8 
  distro/src/test/python/scripts/TestMetadata.py b813f927f 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
8a8e8cafc 


Diff: https://reviews.apache.org/r/73249/diff/9/

Changes: https://reviews.apache.org/r/73249/diff/8-9/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-28 Thread chaitali 


> On April 27, 2021, 5:32 a.m., Pinal Shah wrote:
> > distro/src/bin/atlas_start.py
> > Line 135 (original), 138 (patched)
> > 
> >
> > What happens if the collection name, updated in properties already 
> > exists in solr
> > Can we restrict this from not allowing to point old collection?

I have added a comment in application.properties file for this.


- chaitali


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222873
---


On April 28, 2021, 5:39 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 28, 2021, 5:39 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
>   repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
> PRE-CREATION 
>   
> tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java
>  37565188e 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/8/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-28 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 28, 2021, 5:39 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/8/

Changes: https://reviews.apache.org/r/73249/diff/7-8/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-28 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 28, 2021, 4:30 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/7/

Changes: https://reviews.apache.org/r/73249/diff/6-7/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-26 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222873
---




distro/src/bin/atlas_start.py
Line 135 (original), 138 (patched)


What happens if the collection name, updated in properties already exists 
in solr
Can we restrict this from not allowing to point old collection?



repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java
Lines 43 (patched)


Can you set collection names here?



repository/src/test/resources/atlas-application.properties
Lines 1 (patched)


Can you please review if this is required?


- Pinal Shah


On April 26, 2021, 5:41 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 26, 2021, 5:41 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
>   repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
> PRE-CREATION 
>   repository/src/test/resources/atlas-application.properties PRE-CREATION 
>   
> tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java
>  37565188e 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/6/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-25 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 26, 2021, 5:41 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  repository/src/test/resources/atlas-application.properties PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/6/

Changes: https://reviews.apache.org/r/73249/diff/5-6/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-25 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 26, 2021, 4:51 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  repository/src/test/resources/atlas-application.properties PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/5/

Changes: https://reviews.apache.org/r/73249/diff/4-5/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 8, 2021, 5:20 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/4/

Changes: https://reviews.apache.org/r/73249/diff/3-4/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-01 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222765
---




intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Lines 78 (patched)


consider renaming the configurations to:

atlas.solr.vertex.index.collection.name = vertex_index
atlas.solr.edge.index.collection.name = edge_index
atlas.solr.fulltext.index.collection.name = fulltext_index


- Sarath Subramanian


On April 1, 2021, 3:52 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 1, 2021, 3:52 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-01 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222764
---



Atlas Repair Index Tool also needs to updated to handle configurable collection 
names. Please review.

- Sarath Subramanian


On April 1, 2021, 3:52 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 1, 2021, 3:52 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-01 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 1, 2021, 10:52 a.m.)


Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 


Diff: https://reviews.apache.org/r/73249/diff/3/


Testing (updated)
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-01 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 1, 2021, 10:51 a.m.)


Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 


Diff: https://reviews.apache.org/r/73249/diff/3/

Changes: https://reviews.apache.org/r/73249/diff/2-3/


Testing
---

mvn clean install
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-01 Thread Jayendra Parab 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222759
---




distro/src/bin/atlas_config.py
Lines 741 (patched)


Remove this print msg...



distro/src/bin/atlas_start.py
Lines 29 (patched)


We should have these constants in atlas_config.py and should be names as 
VERTEX_INDEX_NAME_CONF
The method which gets the name, should make use of these constants from 
there



distro/src/conf/atlas-application.properties
Lines 83 (patched)


Kee the default index names as vertex_index, edge_index, fulltext_index


- Jayendra Parab


On March 30, 2021, 10:41 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated March 30, 2021, 10:41 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean install
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-03-30 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated March 30, 2021, 10:41 a.m.)


Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 


Diff: https://reviews.apache.org/r/73249/diff/2/


Testing
---

mvn clean install
atlas server up and running
Collections created with entities linked


Thanks,

chaitali