Re: Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74077/#review224601 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 2, 2022, 1:21

Re: Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-05 Thread Madhan Neethiraj
> On Aug. 5, 2022, 12:30 a.m., Madhan Neethiraj wrote: > > Patrik - the changes look good. Shouldn't these code changes result in > > webapp dependency updates to remove Kafka server libraries? > > Patrik Márton wrote: > Thanks for the review! The dependency is coming transitively from the

Re: Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-05 Thread Patrik Márton via Review Board
> On Aug. 5, 2022, 12:30 a.m., Madhan Neethiraj wrote: > > Patrik - the changes look good. Shouldn't these code changes result in > > webapp dependency updates to remove Kafka server libraries? Thanks for the review! The dependency is coming transitively from the notification module as it

Re: Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-04 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74077/#review224597 --- Patrik - the changes look good. Shouldn't these code changes

Re: Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-02 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74077/#review224593 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 2, 2022, 1:21

Re: Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-02 Thread Patrik Márton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74077/ --- (Updated Aug. 2, 2022, 1:21 p.m.) Review request for atlas, Ashutosh Mestry,

Review Request 74077: Refactor Atlas webapp module to remove Kafka core dependency

2022-08-02 Thread Patrik Márton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74077/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Nixon Rodrigues.