Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Suma Shivaprasad
On Sept. 22, 2016, 11:12 a.m., Jeff Hagelberg wrote: > > Enable checkstyle on new modules with this property in pom.xml - > > true > > > > With patch: > > Running org.apache.atlas.repository.graph.GraphRepoMapperScaleTest > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 113.2

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150231 --- graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150230 --- repository/src/main/scala/org/apache/atlas/query/GremlinQuery.sca

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150229 --- repository/src/main/scala/org/apache/atlas/query/GremlinQuery.sca

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150227 --- repository/src/main/scala/org/apache/atlas/query/GremlinQuery.sca

Re: Review Request 52166: Allow optional attributes to be removed when updating type

2016-09-23 Thread Suma Shivaprasad
> On Sept. 23, 2016, 6:19 a.m., Shwetha GS wrote: > > In case the attribute is added again, the data will be wrong. We can't > > discount that as an edge case, as it causes data inconsistency. Follow up > > jiras will hardly be taken up. Its fine even if we decide that we don't > > allow addin

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150218 --- graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/Atl

Re: Review Request 52077: Column level lineage in Hive

2016-09-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52077/#review150215 --- addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/Col

Re: Review Request 52077: Column level lineage in Hive

2016-09-23 Thread Suma Shivaprasad
> On Sept. 21, 2016, 8:58 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java, > > line 97 > > > > > > why is column qualifiedName different from th

Re: Rename trait to classification

2016-09-23 Thread David Radley
Hi Madhan, That would be great :-) thanks, David. From: Madhan Neethiraj To: "dev@atlas.incubator.apache.org" Date: 23/09/2016 16:48 Subject:Re: Rename trait to classification Sent by:Madhan Neethiraj David, I agree on replacing ‘trait’ with ‘Classification’. I g

Re: Rename trait to classification

2016-09-23 Thread Madhan Neethiraj
David, I agree on replacing ‘trait’ with ‘Classification’. I guess the name ‘triat’ might have been influenced by Scala (and not from Ranger, which doesn’t have ‘triat’ in its vocab..). Instead of renaming in the existing APIs, how about we go with the new name in the API introduced in ATLAS-1

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Jeff Hagelberg
> On Sept. 22, 2016, 11:12 a.m., Shwetha GS wrote: > > catalog/pom.xml, line 67 > > > > > > for now, catalog can only be used with Titan 0.5.4 - why? > > Jeff Hagelberg wrote: > A good portion of the catalog pro

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-23 Thread Jeff Hagelberg
> On Sept. 21, 2016, 11:47 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 279 > > > > > > Instead of having multiple checks its better to abstract ou

[jira] [Updated] (ATLAS-1194) Update Catalog to support Tinkerpop 3

2016-09-23 Thread Jeffrey Hagelberg (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeffrey Hagelberg updated ATLAS-1194: - Description: Right now, the catalog project has hard-coded dependencies on TinkerPop 3 cla

[jira] [Created] (ATLAS-1195) Clean up DSL Translation

2016-09-23 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-1195: Summary: Clean up DSL Translation Key: ATLAS-1195 URL: https://issues.apache.org/jira/browse/ATLAS-1195 Project: Atlas Issue Type: Sub-task

[jira] [Updated] (ATLAS-1194) Update Catalog to support Tinkerpop 3

2016-09-23 Thread Jeffrey Hagelberg (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeffrey Hagelberg updated ATLAS-1194: - Issue Type: Sub-task (was: Task) Parent: ATLAS-610 > Update Catalog to support Ti

[jira] [Created] (ATLAS-1194) Update Catalog to support Tinkerpop 3

2016-09-23 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-1194: Summary: Update Catalog to support Tinkerpop 3 Key: ATLAS-1194 URL: https://issues.apache.org/jira/browse/ATLAS-1194 Project: Atlas Issue Type: Task

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-23 Thread Shwetha GS
On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

[jira] [Updated] (ATLAS-1193) UI : UI to create entities

2016-09-23 Thread Kalyani Kashikar (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalyani Kashikar updated ATLAS-1193: Attachment: ATLAS-1193.patch > UI : UI to create entities > -- > >

[jira] [Updated] (ATLAS-1193) UI : UI to create entities

2016-09-23 Thread Kalyani Kashikar (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalyani Kashikar updated ATLAS-1193: Attachment: (was: ATLAS-1193.patch) > UI : UI to create entities > -

Re: Review Request 52215: ATLAS-1193 : UI : UI to create entities

2016-09-23 Thread Kalyani Kashikar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52215/ --- (Updated Sept. 23, 2016, 1:18 p.m.) Review request for atlas, keval bhatt, Madh

Review Request 52215: ATLAS-1193 : UI : UI to create entities

2016-09-23 Thread Kalyani Kashikar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52215/ --- Review request for atlas, keval bhatt, Madhan Neethiraj, Shwetha GS, and Suma Sh

[jira] [Updated] (ATLAS-1193) UI : UI to create entities

2016-09-23 Thread Kalyani Kashikar (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalyani Kashikar updated ATLAS-1193: Attachment: ATLAS-1193.patch > UI : UI to create entities > -- > >

[jira] [Created] (ATLAS-1193) UI : UI to create entities

2016-09-23 Thread Kalyani Kashikar (JIRA)
Kalyani Kashikar created ATLAS-1193: --- Summary: UI : UI to create entities Key: ATLAS-1193 URL: https://issues.apache.org/jira/browse/ATLAS-1193 Project: Atlas Issue Type: Bug Affects Ve

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-23 Thread David Radley
On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

[jira] [Created] (ATLAS-1192) Atlas login fails in IE-8 browser with jquery error

2016-09-23 Thread Nixon Rodrigues (JIRA)
Nixon Rodrigues created ATLAS-1192: -- Summary: Atlas login fails in IE-8 browser with jquery error Key: ATLAS-1192 URL: https://issues.apache.org/jira/browse/ATLAS-1192 Project: Atlas Issue T

Rename trait to classification

2016-09-23 Thread David Radley
Hi, I have raised Jira ATLAS-1187. This is to rename trait to Classification. I know that this would effect the API, so am keen to understand how we agree to version the API maybe including other changes. I feel trait is not very descriptive and I assume comes from Ranger terminology. I think