Re: Review Request 54660: ATLAS-1287 Subtasks: ATLAS-1288/ATLAS-1289 Integrated V2 API for Lineage, Entity Details, Tag assign to entity, Tags listing, tag create

2016-12-13 Thread keval bhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54660/ --- (Updated Dec. 14, 2016, 5:54 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 54660: ATLAS-1287 : Integrate V2 API in Atlas UI

2016-12-13 Thread keval bhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54660/ --- (Updated Dec. 14, 2016, 5:53 a.m.) Review request for atlas, Madhan Neethiraj,

[jira] [Comment Edited] (ATLAS-1287) Integrate V2 API in Atlas UI

2016-12-13 Thread Keval Bhatt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741939#comment-15741939 ] Keval Bhatt edited comment on ATLAS-1287 at 12/14/16 5:52 AM: -- This

[jira] [Comment Edited] (ATLAS-1287) Integrate V2 API in Atlas UI

2016-12-13 Thread Keval Bhatt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741939#comment-15741939 ] Keval Bhatt edited comment on ATLAS-1287 at 12/14/16 5:49 AM: -- This

[jira] [Commented] (ATLAS-1289) Integrate lineageRest API in Atlas UI

2016-12-13 Thread Keval Bhatt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747367#comment-15747367 ] Keval Bhatt commented on ATLAS-1289: Thanks [~madhan.neethiraj] for review , Committed on master (

[jira] [Commented] (ATLAS-1193) UI : UI to create entities

2016-12-13 Thread Kalyani Kashikar (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747325#comment-15747325 ] Kalyani Kashikar commented on ATLAS-1193: - ATLAS-1193.5.patch is the latest patch. Please use this

Re: Review Request 54660: ATLAS-1287 : Integrate V2 API in Atlas UI

2016-12-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54660/#review159110 --- Ship it! Ship It! - Madhan Neethiraj On Dec. 12, 2016, 1:48

[jira] [Commented] (ATLAS-1220) when i execute bin/atlas_start.py found HTTP ERROR: 503

2016-12-13 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746906#comment-15746906 ] Qiang Zhang commented on ATLAS-1220: Ok. I will be further verified according to your reply. > when i

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-13 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 13, 2016, 11:30 p.m.) Review request for atlas, Madhan

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.v5.patch > Integration tests for Entity V2 REST APIs >

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-13 Thread Apoorv Naik
> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197 > > > > > > add validations to have typename or supertype in the request to be >

Review Request 54722: ATLAS-1301: Client simplification and bugfixes

2016-12-13 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54722/ --- Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.

[jira] [Updated] (ATLAS-1301) Client calls from the IT retries more than what's specified

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1301: --- Attachment: ATLAS-1301.patch > Client calls from the IT retries more than what's specified >

Re: Review Request 54430: Atlas-1186: Add glossary Categories

2016-12-13 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54430/#review159055 --- General comments: * Indentation is misaligned in several files. *

[jira] [Commented] (ATLAS-1245) More objects should have a unique guid

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745967#comment-15745967 ] Apoorv Naik commented on ATLAS-1245: Ok so in V2 we call trait as classification and during creation

[jira] [Comment Edited] (ATLAS-1245) More objects should have a unique guid

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745967#comment-15745967 ] Apoorv Naik edited comment on ATLAS-1245 at 12/13/16 7:09 PM: -- Ok so in V2 we

[jira] [Created] (ATLAS-1374) Tests are failing in the build

2016-12-13 Thread David Radley (JIRA)
David Radley created ATLAS-1374: --- Summary: Tests are failing in the build Key: ATLAS-1374 URL: https://issues.apache.org/jira/browse/ATLAS-1374 Project: Atlas Issue Type: Bug

Re: Review Request 54430: Atlas-1186: Add glossary Categories

2016-12-13 Thread David Radley
> On Dec. 12, 2016, 6:16 p.m., Apoorv Naik wrote: > > Yes that makes sense - as a clarificaiton for me, are you comfortable with me removing references to edges and edge labels in the interface names and comments and replacing them with a more generic words like relationship and

[jira] [Commented] (ATLAS-1245) More objects should have a unique guid

2016-12-13 Thread David Radley (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745574#comment-15745574 ] David Radley commented on ATLAS-1245: - Hi Apoorv, Thanks for the comment. I have pulled in the latest

[jira] [Updated] (ATLAS-1366) Documentation for new REST API

2016-12-13 Thread Vimal Sharma (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vimal Sharma updated ATLAS-1366: Attachment: ATLAS-1366.patch I could create swagger.json using the jaxrs analyzer tool. Thanks a

[jira] [Updated] (ATLAS-1366) Documentation for new REST API

2016-12-13 Thread Vimal Sharma (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vimal Sharma updated ATLAS-1366: Attachment: swagger.json > Documentation for new REST API > -- > >

Re: Improvement suggestion: change terms to be implemented as entities

2016-12-13 Thread David Radley
Hi Shweta, Thank you, I had not considered the search side of things. I suggest that for a minium viable change for the first check in, we do not change this behavior; this may mean we need to special case the code to ensure that isa still performs as it did. I do think that search needs to

[jira] [Created] (ATLAS-1373) Change terms to have names and fully qualified names

2016-12-13 Thread David Radley (JIRA)
David Radley created ATLAS-1373: --- Summary: Change terms to have names and fully qualified names Key: ATLAS-1373 URL: https://issues.apache.org/jira/browse/ATLAS-1373 Project: Atlas Issue

[jira] [Created] (ATLAS-1372) Have Glossary objects as first level objects in search

2016-12-13 Thread David Radley (JIRA)
David Radley created ATLAS-1372: --- Summary: Have Glossary objects as first level objects in search Key: ATLAS-1372 URL: https://issues.apache.org/jira/browse/ATLAS-1372 Project: Atlas Issue

Re: Review Request 54166: ALTAS-1193: UI : UI to create entities

2016-12-13 Thread Kalyani Kashikar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54166/ --- (Updated Dec. 13, 2016, 1:06 p.m.) Review request for atlas, keval bhatt,

[jira] [Updated] (ATLAS-1193) UI : UI to create entities

2016-12-13 Thread Kalyani Kashikar (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalyani Kashikar updated ATLAS-1193: Attachment: ATLAS-1193.5.patch This patch is dependent on ATLAS-1287. > UI : UI to create

[jira] [Created] (ATLAS-1371) ATLAS UI : Allow choosing of data-type for attributes in create/edit tag dialog.

2016-12-13 Thread Keval Bhatt (JIRA)
Keval Bhatt created ATLAS-1371: -- Summary: ATLAS UI : Allow choosing of data-type for attributes in create/edit tag dialog. Key: ATLAS-1371 URL: https://issues.apache.org/jira/browse/ATLAS-1371 Project:

Re: Improvement suggestion: change terms to be implemented as entities

2016-12-13 Thread David Radley
Hi Hemanth, On point 10 - I suggest that all assets would have a "system" optional predefined multiplicity relationship to terms (which in this proposal will only be one type, so could be a standard entity to entity relationship). Does this work for you? I suggest on the tag / trait front -