Re: Review Request 54806: ATLAS-1395 : Lineage improvement for tooltip

2016-12-16 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54806/#review159443 --- Ship it! Ship It! - Madhan Neethiraj On Dec. 16, 2016, 11

[jira] [Commented] (ATLAS-1394) Equals and hashCode missing class from previous patch

2016-12-15 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753332#comment-15753332 ] Madhan Neethiraj commented on ATLAS-1394: - [~apoorvnaik] this patch should no

Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification

2016-12-15 Thread Madhan Neethiraj
viceTest.java (line 647) <https://reviews.apache.org/r/53789/#comment230383> anActualArray ==> referenceable - Madhan Neethiraj On Dec. 15, 2016, 10:06 p.m., Apoorv Naik wrote: > > --- > This is an automatically

Re: Review Request 54741: ATLAS-1377 Escaping comma in LDAP properties

2016-12-14 Thread Madhan Neethiraj
x27;t break existing configurations that have escaped commas in LDAP properties? - Madhan Neethiraj On Dec. 14, 2016, 1:13 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 54660: ATLAS-1287 : Integrate V2 API in Atlas UI

2016-12-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54660/#review159110 --- Ship it! Ship It! - Madhan Neethiraj On Dec. 12, 2016, 1:48

[jira] [Commented] (ATLAS-1343) CTAS query is not captured by Atlas with Hive2

2016-11-30 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710707#comment-15710707 ] Madhan Neethiraj commented on ATLAS-1343: - +1 for the patch > CTAS query

Re: Review Request 54166: ALTAS-1193: UI : UI to create entities

2016-11-30 Thread Madhan Neethiraj
attributes (like hive_table.aliases), editing an existing entity causes null value to be saved - perhaps because empty value is displayed in the UI though the entity has values (in the store). Please review and update to fix this issue. - Madhan Neethiraj On Nov. 29, 2016, 2:56 p.m., Kalyani

[jira] [Commented] (ATLAS-1342) Titan Solrclient - Add timeouts for zookeeper connect and session

2016-11-29 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707657#comment-15707657 ] Madhan Neethiraj commented on ATLAS-1342: - [~suma.shivaprasad] - can you pl

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

2016-11-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53828/#review157141 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 28, 2016, 8:54

Re: Review Request 53828: [ATLAS-1300] LineageResource API needs to map to the new LineageREST API

2016-11-28 Thread Madhan Neethiraj
lSuperTypes().contains(AtlasBaseTypeDef.ATLAS_TYPE_DATASET); } - Madhan Neethiraj On Nov. 28, 2016, 6:31 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[jira] [Updated] (ATLAS-1335) Update attributeDef validation to be consistent with TypeSystem

2016-11-28 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1335: Attachment: ATLAS-1335.1.patch > Update attributeDef validation to be consistent w

Re: Review Request 54092: ATLAS-1335: updated AtlasStructType to treat multi-value attribute similar to TypeSystem for backward compatibility

2016-11-28 Thread Madhan Neethiraj
main/java/org/apache/atlas/type/AtlasStructType.java 534f2a9 intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java 1a15232 Diff: https://reviews.apache.org/r/54092/diff/ Testing --- updated unit tests and verified that unit tests pass succesfully Thanks, Madhan Neethiraj

Re: Review Request 54046: [ATLAS-458] Fix project organization for ATLAS build tools

2016-11-26 Thread Madhan Neethiraj
update and commit the patch. pom.xml (line 1248) <https://reviews.apache.org/r/54046/#comment227319> Replace "0.8-incubating-SNAPSHOT" with "${project.version}". - Madhan Neethiraj On Nov. 23, 2016, 9:44 p.m.

[jira] [Commented] (ATLAS-1322) Coverity Scan 154409 : Fix dereference null return value for RestUtils

2016-11-26 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697542#comment-15697542 ] Madhan Neethiraj commented on ATLAS-1322: - +1 for the patch. Thanks [~sarat

Re: JSON License and Apache Projects

2016-11-25 Thread Madhan Neethiraj
Hemanth, David, Atlas uses JOSN libraries from org.json4s, while the licensing issue seems to be about the code/libraries from ‘https://github.com/stleary/JSON-java’. Are both referring to the same? Thanks, Madhan On 11/25/16, 2:00 AM, "David Radley" wrote: Hi , It does seem like w

[jira] [Updated] (ATLAS-1335) Update attributeDef validation to be consistent with TypeSystem

2016-11-25 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1335: Attachment: ATLAS-1335.patch Patch is available at review board: https://reviews.apache.org

Review Request 54092: ATLAS-1335: updated AtlasStructType to treat multi-value attribute similar to TypeSystem for backward compatibility

2016-11-25 Thread Madhan Neethiraj
ff: https://reviews.apache.org/r/54092/diff/ Testing --- updated unit tests and verified that unit tests pass succesfully Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1335) Update attributeDef validation to be consistent with TypeSystem

2016-11-25 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1335: --- Summary: Update attributeDef validation to be consistent with TypeSystem Key: ATLAS-1335 URL: https://issues.apache.org/jira/browse/ATLAS-1335 Project: Atlas

[jira] [Updated] (ATLAS-1319) EntityREST API does not handle attributes of type struct

2016-11-23 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1319: Attachment: ATLAS-1319.4.patch > EntityREST API does not handle attributes of type str

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
/web/adapters/TestEntityREST.java 6dd21d1 Diff: https://reviews.apache.org/r/54023/diff/ Testing --- - verified that creation of entity with struct type attribute is handled correctly by EntityREST API Thanks, Madhan Neethiraj

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/#review156786 ------- On Nov. 23, 2016, 11:55 p.m., Madhan Neethiraj wrote: > > --- &g

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 6dd21d1 Diff: https://reviews.apache.org/r/54023/diff/ Testing --- - verified that creation of entity with struct type attribute is handled correctly by EntityREST API Thanks, Madhan Neethiraj

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
creation of entity with struct type attribute is handled correctly by EntityREST API Thanks, Madhan Neethiraj

[jira] [Updated] (ATLAS-1319) EntityREST API does not handle attributes of type struct

2016-11-23 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1319: Attachment: ATLAS-1319.patch Patch at review board: https://reviews.apache.org/r/54023

Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
handled correctly by EntityREST API Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1319) EntityREST API does not handle attributes of type struct

2016-11-23 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1319: --- Summary: EntityREST API does not handle attributes of type struct Key: ATLAS-1319 URL: https://issues.apache.org/jira/browse/ATLAS-1319 Project: Atlas

[jira] [Commented] (ATLAS-1317) Disable the problematic ITs

2016-11-22 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687946#comment-15687946 ] Madhan Neethiraj commented on ATLAS-1317: - +1. Please create another JIR

[jira] [Updated] (ATLAS-1314) Update typedefs with addition of 'options' attribute

2016-11-21 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1314: Fix Version/s: 0.8-incubating > Update typedefs with addition of 'options&#x

[jira] [Updated] (ATLAS-1314) Update typedefs with addition of 'options' attribute

2016-11-21 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1314: Attachment: ATLAS-1314.patch Review board URL for the patch: https://reviews.apache.org/r

Review Request 53968: ATLAS-1314: update typedefs with addition of 'options' attribute

2016-11-21 Thread Madhan Neethiraj
DefGraphStoreV1.java 53d6591 Diff: https://reviews.apache.org/r/53968/diff/ Testing --- - verified that Atlas server startup loads the typedef-patches that add options attribute and REST APIs handle the new attribute correctly Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1314) Update typedefs with addition of 'options' attribute

2016-11-21 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1314: --- Summary: Update typedefs with addition of 'options' attribute Key: ATLAS-1314 URL: https://issues.apache.org/jira/browse/ATLAS-1314 Proj

[jira] [Updated] (ATLAS-1310) LDAP authentication attempted even when disabled

2016-11-20 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1310: Attachment: ATLAS-1310.patch Patch in review board: https://reviews.apache.org/r/53940

Review Request 53940: ATLAS-1310: attempt LDAP authentication only when enabled

2016-11-20 Thread Madhan Neethiraj
68553df Diff: https://reviews.apache.org/r/53940/diff/ Testing --- Verified that Atlas server attempts LDAP authentication only when configuration atlas.authentication.method.ldap is set to true Thanks, Madhan Neethiraj

[jira] [Assigned] (ATLAS-1310) LDAP authentication attempted even when disabled

2016-11-20 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj reassigned ATLAS-1310: --- Assignee: Madhan Neethiraj > LDAP authentication attempted even when disab

[jira] [Updated] (ATLAS-1310) LDAP authentication attempted even when disabled

2016-11-20 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1310: Description: After the updates to support KnoxSSL (ATLAS-1244), Atlas attempts LDAP

[jira] [Created] (ATLAS-1310) LDAP authentication attempted even when disabled

2016-11-20 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1310: --- Summary: LDAP authentication attempted even when disabled Key: ATLAS-1310 URL: https://issues.apache.org/jira/browse/ATLAS-1310 Project: Atlas Issue

[jira] [Updated] (ATLAS-1309) Update HBase model with addition of column-family and column entity-types

2016-11-20 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1309: Attachment: ATLAS-1309.patch Patch in Review board @ https://reviews.apache.org/r/53935

Review Request 53935: ATLAS-1309: updated HBase model with addition of column-family and column entity-defs

2016-11-20 Thread Madhan Neethiraj
-types successfully Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1309) Update HBase model with addition of column-family and column entity-types

2016-11-20 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1309: --- Summary: Update HBase model with addition of column-family and column entity-types Key: ATLAS-1309 URL: https://issues.apache.org/jira/browse/ATLAS-1309

Re: Review Request 53909: ATLAS-1292: Integration test fixes caused by recent bootstrap changes (ATLAS-1272)

2016-11-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53909/#review156410 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 18, 2016, 11

[jira] [Commented] (ATLAS-1305) Fix potential NPEs in instance conversion code

2016-11-18 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677457#comment-15677457 ] Madhan Neethiraj commented on ATLAS-1305: - +1 > Fix potential NPEs in i

[jira] [Commented] (ATLAS-1291) Type "hive_column_lineage" not present in hive_model.json

2016-11-18 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677088#comment-15677088 ] Madhan Neethiraj commented on ATLAS-1291: - [~svimal2106] HiveDataModelGener

Re: Review Request 53157: [ATLAS-1242] TypesResource API needs to use the new TypesREST API

2016-11-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53157/#review156285 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 18, 2016, 5:56

[jira] [Updated] (ATLAS-1306) Bootstrap typedef load ignores model file if a type in the file already exists

2016-11-17 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1306: Attachment: ATLAS-1306.patch > Bootstrap typedef load ignores model file if a type in

[jira] [Created] (ATLAS-1306) Bootstrap typedef load ignores model file if a type in the file already exists

2016-11-17 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1306: --- Summary: Bootstrap typedef load ignores model file if a type in the file already exists Key: ATLAS-1306 URL: https://issues.apache.org/jira/browse/ATLAS-1306

[jira] [Commented] (ATLAS-1305) Fix potential NPEs in instance conversion code

2016-11-17 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675796#comment-15675796 ] Madhan Neethiraj commented on ATLAS-1305: - +1 for the patch. One sugges

Re: Review Request 53157: [ATLAS-1242] TypesResource API needs to use the new TypesREST API

2016-11-17 Thread Madhan Neethiraj
r - fields are not copied from attrDef. Please refer to AtlasStructDefStoreV1.toJsonFromAttributeDef() webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 498) <https://reviews.apache.org/r/53157/#comment226409> return type.getTypeCategory() == TypeCategory.ENTITY - Madhan Neeth

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-15 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/#review156010 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 11, 2016, 3:07

Re: Review Request 53432: [ATLAS-1267] V2 Client for TypesREST & EntityREST API and Integration tests

2016-11-13 Thread Madhan Neethiraj
/AtlasTypedefClientV2.java (line 78) <https://reviews.apache.org/r/53432/#comment225880> Add getTypeDefHeaders() method - equivalent of TypesREST.getTypeDefHeaders() - Madhan Neethiraj On Nov. 14, 2016, 5:46 a.m., Apoorv Naik

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

2016-11-11 Thread Madhan Neethiraj
() - "/guid/{guid}" getWithAssociationsByGuid() - "/guid/withAssociations/{guid}" webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 217) <https://reviews.apache.org/r/53316/#comment225849> Consider moving 'private' methods

Re: Review Request 53073: Lineage REST API v2 implementation

2016-11-11 Thread Madhan Neethiraj
/model/lineage/AtlasLineageInfo.java (line 117) <https://reviews.apache.org/r/53073/#comment225828> replace == with equals(): if (baseEntityId != null ? !baseEntityId.equals(that.baseEntityId) : that.baseEntityId != null) { return false; } - Madhan Neethiraj On Nov. 11, 2016

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-10 Thread Madhan Neethiraj
in every call? Since 'publicKey' only changes in setJwtProperties(), consider instantiting RSASSAVerifier() in setJwtProperties() and use that instance here. webapp/src/main/java/org/apache/atlas/web/filters/SSOAuthentication.java (line 33) <https://reviews.apache.org/r/53426/#comment225765>

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

2016-11-10 Thread Madhan Neethiraj
adapters/v2/AtlasStructToStructConverter.java (line 80) <https://reviews.apache.org/r/53316/#comment225759> Consider replacing with: AtlasStructDef structDef = ((AtlasStructType)type).getStructDef(); - Madhan Neethiraj On Nov. 11, 2016, 12:12 a.m., Suma Shivaprasad wrote: >

Re: Review Request 53073: Lineage REST API v2 implementation

2016-11-10 Thread Madhan Neethiraj
ineageService.java (line 213) <https://reviews.apache.org/r/53073/#comment225750> if only List is expected from the query, consider throwing an error when any other type is returned. Please review line #220 as well for the same condition. - Madhan Neethiraj On Nov. 10,

[jira] [Updated] (ATLAS-1285) Fix issues flagged by Coverity scan - like potential NPE

2016-11-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1285: Attachment: ATLAS-1285.patch > Fix issues flagged by Coverity scan - like potential

[jira] [Created] (ATLAS-1285) Fix issues flagged by Coverity scan - like potential NPE

2016-11-10 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1285: --- Summary: Fix issues flagged by Coverity scan - like potential NPE Key: ATLAS-1285 URL: https://issues.apache.org/jira/browse/ATLAS-1285 Project: Atlas

[jira] [Updated] (ATLAS-1283) Add category attribute to AtlasBaseTypeDef

2016-11-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1283: Attachment: ATLAS-1283.3.patch > Add category attribute to AtlasBaseType

[jira] [Commented] (ATLAS-1276) webapp test failures

2016-11-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655189#comment-15655189 ] Madhan Neethiraj commented on ATLAS-1276: - +1 for the patch. Thanks [~ayub

Re: Review Request 53073: Lineage REST API v2 implementation

2016-11-10 Thread Madhan Neethiraj
> Instead of using "String" type for direction, consider using an enum. webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java (line 68) <https://reviews.apache.org/r/53073/#comment225651> Why is depth of type 'String'? Consider

Re: Review Request 53640: ATLAS-1283: added attribute AtlasBaseTypeDef.category

2016-11-10 Thread Madhan Neethiraj
08d09f7 Diff: https://reviews.apache.org/r/53640/diff/ Testing --- Verified unit-tests pass successfully Thanks, Madhan Neethiraj

Re: Review Request 53640: ATLAS-1283: added attribute AtlasBaseTypeDef.category

2016-11-10 Thread Madhan Neethiraj
73b64a3 repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 08d09f7 Diff: https://reviews.apache.org/r/53640/diff/ Testing --- Verified unit-tests pass successfully Thanks, Madhan Neethiraj

[jira] [Updated] (ATLAS-1283) Add category attribute to AtlasBaseTypeDef

2016-11-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1283: Attachment: ATLAS-1283.2.patch > Add category attribute to AtlasBaseType

[jira] [Updated] (ATLAS-1283) Add category attribute to AtlasBaseTypeDef

2016-11-10 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1283: Attachment: ATLAS-1283.patch > Add category attribute to AtlasBaseType

Review Request 53640: ATLAS-1283: added attribute AtlasBaseTypeDef.category

2016-11-10 Thread Madhan Neethiraj
/v1/AtlasTypeDefGraphStoreV1.java 73b64a3 repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 08d09f7 Diff: https://reviews.apache.org/r/53640/diff/ Testing --- Verified unit-tests pass successfully Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1283) Add category attribute to AtlasBaseTypeDef

2016-11-10 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1283: --- Summary: Add category attribute to AtlasBaseTypeDef Key: ATLAS-1283 URL: https://issues.apache.org/jira/browse/ATLAS-1283 Project: Atlas Issue Type

[jira] [Updated] (ATLAS-1281) Audit logs written to both audit.log and application.log - should only go to audit.log

2016-11-09 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1281: Attachment: ATLAS-1281.patch Review board: https://reviews.apache.org/r/53638/ > Au

Review Request 53638: ATLAS-1281: audit logs should written only to audit.log and not application.log

2016-11-09 Thread Madhan Neethiraj
/AuditFilter.java 866277f Diff: https://reviews.apache.org/r/53638/diff/ Testing --- - ran unit tests successfully - deployed atlas.war and verified that audit logs are Awritten only to audit.log and not application.log Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1281) Audit logs written to both audit.log and application.log - should only go to audit.log

2016-11-09 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1281: --- Summary: Audit logs written to both audit.log and application.log - should only go to audit.log Key: ATLAS-1281 URL: https://issues.apache.org/jira/browse/ATLAS-1281

[jira] [Updated] (ATLAS-1281) Audit logs written to both audit.log and application.log - should only go to audit.log

2016-11-09 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1281: Description: Audit logs generated by Atlas server currently go to both audit.log and

Re: Review Request 53595: Added minimal data structure for typedef calls

2016-11-08 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53595/#review155411 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 9, 2016, 6:56

Re: Review Request 53595: Added minimal data structure for typedef calls

2016-11-08 Thread Madhan Neethiraj
NTITY) to avoid calling getTypeCategory() from toTypeDefHeader(). - Madhan Neethiraj On Nov. 9, 2016, 4:40 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 53432: [ATLAS-1267] V2 Client for TypesREST API and Integration tests

2016-11-08 Thread Madhan Neethiraj
of entitydef named updatedTypeDefs.getEntityDefs().get(0).getName(). webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java (line 343) <https://reviews.apache.org/r/53432/#comment225218> consider renaming clearType

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

2016-11-08 Thread Madhan Neethiraj
may not be necessary; consider using source directly. Please review and update. webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 84) <https://reviews.apache.org/r/53316/#comment225142> isArrayListType() and isSetType() are duplicated in At

[jira] [Commented] (ATLAS-1192) Atlas IE support

2016-11-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646604#comment-15646604 ] Madhan Neethiraj commented on ATLAS-1192: - +1 > Atlas IE

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

2016-11-07 Thread Madhan Neethiraj
.apache.org/r/53316/#comment225102> Consider taking AtlasStructType as parameter, instead of Collection. AtlasStructType has a cache of AtlasType for each of its attribute - which can help eliminate typeRegistry.getType(attrTypeName) the need to instantiate AtlasArrayType and At

[jira] [Updated] (ATLAS-1272) Update types bootstrap to load from new format typedef JSON files

2016-11-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1272: Attachment: ATLAS-1272.3.patch Patch updated for the review comments. > Update ty

Re: Review Request 53526: ATLAS-1272: updated types bootstrap to load from new format typedef JSON files

2016-11-07 Thread Madhan Neethiraj
--- Thanks, Madhan Neethiraj

Re: Review Request 53526: ATLAS-1272: updated types bootstrap to load from new format typedef JSON files

2016-11-07 Thread Madhan Neethiraj
/src/test/java/org/apache/atlas/services/DefaultMetadataServiceMockTest.java 9722a72 repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java effab15 Diff: https://reviews.apache.org/r/53526/diff/ Testing --- Thanks, Madhan Neethiraj

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-07 Thread Madhan Neethiraj
seems to be initializing this.jwtProperties. Is this intentional? Perhaps this should go into loadJwtProperties() and have getJwtProperties() simply return this.jwtProperties. - Madhan Neethiraj On Nov. 7, 2016, 12:59 p.m., Nixon Rodrigues wrote: >

[jira] [Updated] (ATLAS-1272) Update types bootstrap to load from new format typedef JSON files

2016-11-07 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1272: Attachment: ATLAS-1272.patch Patch at review board here: https://reviews.apache.org/r/53526

Review Request 53526: ATLAS-1272: updated types bootstrap to load from new format typedef JSON files

2016-11-07 Thread Madhan Neethiraj
repository/src/test/java/org/apache/atlas/services/DefaultMetadataServiceMockTest.java 9722a72 repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java effab15 Diff: https://reviews.apache.org/r/53526/diff/ Testing --- Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1272) Update types bootstrap to load from new format typedef JSON files

2016-11-07 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1272: --- Summary: Update types bootstrap to load from new format typedef JSON files Key: ATLAS-1272 URL: https://issues.apache.org/jira/browse/ATLAS-1272 Project: Atlas

Re: Review Request 53073: Lineage REST API v2 implementation

2016-11-03 Thread Madhan Neethiraj
s is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53073/ > ------- > > (Updated Nov. 3, 2016, 9:54 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma > Shivaprasad. > > > Bugs: ATLAS-1234 > https:

Re: Review Request 53417: ATLAS-1266: fixed typedef APIs to update type-registry only on successful graph commit

2016-11-03 Thread Madhan Neethiraj
t; > > when indexing fails in GraphBackedSearchIndexer, shouldnt we bubble up > > the error? Else types can be created without indexes > > Madhan Neethiraj wrote: > at this time, type changes have already been committed. Bubbling > exception wouldn't undo this. > &

Re: Review Request 53417: ATLAS-1266: fixed typedef APIs to update type-registry only on successful graph commit

2016-11-03 Thread Madhan Neethiraj
uld result in rollback of type changes? - Madhan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53417/#review154771 -------

[jira] [Updated] (ATLAS-1268) Provide method to retrieve attributeDefs in a type and all its superTypes

2016-11-03 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1268: Attachment: ATLAS-1268.patch > Provide method to retrieve attributeDefs in a type and

Review Request 53419: ATLAS-1268: added methods to retrieve attributeDefs in a type and all its superTypes

2016-11-03 Thread Madhan Neethiraj
/org/apache/atlas/type/AtlasEntityType.java 9c5ec62 intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java 7ad9a18 Diff: https://reviews.apache.org/r/53419/diff/ Testing --- Added unit tests to verify the implementation. Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-1268) Provide method to retrieve attributeDefs in a type and all its superTypes

2016-11-02 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1268: --- Summary: Provide method to retrieve attributeDefs in a type and all its superTypes Key: ATLAS-1268 URL: https://issues.apache.org/jira/browse/ATLAS-1268

[jira] [Updated] (ATLAS-1266) TypeRegistry post commit mechanism

2016-11-02 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1266: Attachment: ATLAS-1266.1.patch > TypeRegistry post commit mechan

Review Request 53417: ATLAS-1266: fixed typedef APIs to update type-registry only on successful graph commit

2016-11-02 Thread Madhan Neethiraj
://reviews.apache.org/r/53417/diff/ Testing --- Verified that PostTransactionHook works as expected by adding/udating/deleting types via REST APIs. Thanks, Madhan Neethiraj

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154500 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 2, 2016, 3:20

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj
.java (line 83) <https://reviews.apache.org/r/53156/#comment224076> missing equals check on 'entity' - is it intentional? - Madhan Neethiraj On Nov. 2, 2016, 1:43 a.m., Suma Shivaprasad wrote: > > --- > This is an

[jira] [Commented] (ATLAS-1259) Test and compilation failure

2016-11-01 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627079#comment-15627079 ] Madhan Neethiraj commented on ATLAS-1259: - Consider adding following construc

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj
ponse updateById(String guid, AtlasEntity entity); EntityMutationResponse updateByUniqueAttribute(String typeName, String attrName, String attrValue, AtlasEntity entity); EntityMutationResponse deleteById(String guid); EntityMutationResponse deleteByUniqueAttribute(String typeName, String

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj
/AtlasEntityId.java (line 49) <https://reviews.apache.org/r/53156/#comment224027> Do we need status and version as a part of EntityId? Can't we use AtlasObjectId instead of AtlasEntityId? - Madhan Neethiraj On Nov. 1, 2016, 8:47 p.m., Suma Shivap

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

2016-11-01 Thread Madhan Neethiraj
4016> addClassification() ==> addClassifications() webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 172) <https://reviews.apache.org/r/53156/#comment224017> updateClassification() ==> updateClassifications() - Madhan Neethiraj On Nov. 1, 2016, 8:47 p

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Madhan Neethiraj
tlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 869) <https://reviews.apache.org/r/53207/#comment223816> Instead of empty list, why not send incoming typeDef here? - Madhan Neethiraj On Oct. 29, 2016, 12:09 a.m., Apoorv Naik wrote: > > --

[jira] [Resolved] (ATLAS-1235) Update of classification does not update the description field

2016-10-31 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-1235. - Resolution: Fixed Fix Version/s: 0.8-incubating Committed master: http://git-wip

Re: Review Request 53080: ATLAS-1235: fixed type-update to save updated values for type fields

2016-10-22 Thread Madhan Neethiraj
removal of attributes and supertypes Thanks, Madhan Neethiraj

Re: Review Request 53080: ATLAS-1235: fixed type-update to save updated values for type fields

2016-10-21 Thread Madhan Neethiraj
, Madhan Neethiraj

<    5   6   7   8   9   10   11   12   13   14   >