Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-14 Thread Jonathan Maron
> On July 13, 2015, 10:48 a.m., Shwetha GS wrote: > > For hive hook, there is a config: > > > > atlas.rest.address > > http://localhost:21000/ > > > > > > > > Can we use the same config to check if its ssl or not, get the port and > > also bind to an address? > > Jonathan Maron wrote: >

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-14 Thread Shwetha GS
> On July 13, 2015, 10:48 a.m., Shwetha GS wrote: > > For hive hook, there is a config: > > > > atlas.rest.address > > http://localhost:21000/ > > > > > > > > Can we use the same config to check if its ssl or not, get the port and > > also bind to an address? > > Jonathan Maron wrote: >

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-14 Thread Suma Shivaprasad
> On July 10, 2015, 5:05 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/Main.java, line 103 > > > > > > Could remove protected to make it package private. Dont get what a > > protected stati

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-14 Thread Jonathan Maron
> On July 10, 2015, 5:05 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/Main.java, line 103 > > > > > > Could remove protected to make it package private. Dont get what a > > protected stati

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-13 Thread Shwetha GS
> On July 13, 2015, 10:48 a.m., Shwetha GS wrote: > > For hive hook, there is a config: > > > > atlas.rest.address > > http://localhost:21000/ > > > > > > > > Can we use the same config to check if its ssl or not, get the port and > > also bind to an address? > > Jonathan Maron wrote: >

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-13 Thread Jonathan Maron
> On July 13, 2015, 10:48 a.m., Shwetha GS wrote: > > For hive hook, there is a config: > > > > atlas.rest.address > > http://localhost:21000/ > > > > > > > > Can we use the same config to check if its ssl or not, get the port and > > also bind to an address? We might be able to do that

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-13 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36359/#review91458 --- For hive hook, there is a config: atlas.rest.address http://loc

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36359/#review91320 --- webapp/src/main/java/org/apache/atlas/Main.java (line 103)

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-10 Thread Jonathan Maron
> On July 10, 2015, 5:05 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/Main.java, line 103 > > > > > > Could remove protected to make it package private. Dont get what a > > protected stati

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-10 Thread Jonathan Maron
> On July 10, 2015, 5:05 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/Main.java, line 103 > > > > > > Could remove protected to make it package private. Dont get what a > > protected stati

Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

2015-07-09 Thread Jonathan Maron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36359/ --- Review request for atlas, Arpit Gupta and Seetharam Venkatesh. Bugs: ATLAS-36