[jira] [Created] (ATLAS-1018) Add an API to return deleted entity instead of returning guid of the deleted entity

[Satish Duggana (JIRA)]

Satish Duggana created ATLAS-1018:
-

 Summary: Add an API to return deleted entity instead of returning 
guid of the deleted entity
 Key: ATLAS-1018
 URL: https://issues.apache.org/jira/browse/ATLAS-1018
 Project: Atlas
  Issue Type: Improvement
Reporter: Satish Duggana






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1017) Sequence support to generate unique numbers(can be monotonic) like Phoenix by suing the underlying types storage engine.

[Satish Duggana (JIRA)]

Satish Duggana created ATLAS-1017:
-

 Summary: Sequence support to generate unique numbers(can be 
monotonic) like Phoenix by suing the underlying types storage engine. 
 Key: ATLAS-1017
 URL: https://issues.apache.org/jira/browse/ATLAS-1017
 Project: Atlas
  Issue Type: Improvement
Reporter: Satish Duggana


Sequence support to generate unique numbers(can be monotonic) like Phoenix by 
using the underlying types storage engine. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49570: ATLAS-986: Ability to differentiate business catalog terms from traits

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49570/#review142004
---




catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 209)


Instead of adding a supertype, lets just add the attribute directly. We 
need to support migration path for future versions. Adding an optional 
attribute is supported, but not adding a supertype



common/src/main/java/org/apache/atlas/AtlasConstants.java (line 36)


Move these constants to catalog module

Rename to taxonomy.namespace so that it doesn't conflict with namespace 
that we might add to all entities/types in future



typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
(line 19)


revert, no changes?


- Shwetha GS


On July 3, 2016, 7:21 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49570/
> ---
> 
> (Updated July 3, 2016, 7:21 a.m.)
> 
> 
> Review request for atlas and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-986
> https://issues.apache.org/jira/browse/ATLAS-986
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Ability to differentiate business catalog terms from traits (author: 
> suma.shivaprasad)
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 8ca47d9 
>   catalog/pom.xml 7b9b691 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> a8e63f3 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java
>  ff22f3b 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultTypeSystemTest.java 
> PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  5a03414 
>   
> catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java
>  33620c3 
>   common/src/main/java/org/apache/atlas/AtlasConstants.java cb46316 
>   pom.xml f119525 
>   repository/pom.xml 9c34f19 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  99f0036 
>   repository/src/test/java/org/apache/atlas/TestUtils.java a159496 
>   
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
>  e6dd230 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 7cc036c 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> c355ba9 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 1f0c944 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> d84f8a2 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
> b2ff4cf 
> 
> Diff: https://reviews.apache.org/r/49570/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Created] (ATLAS-1016) Support for composite unique attributes for a type.

[Satish Duggana (JIRA)]

Satish Duggana created ATLAS-1016:
-

 Summary: Support for composite unique attributes for a type.
 Key: ATLAS-1016
 URL: https://issues.apache.org/jira/browse/ATLAS-1016
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 0.8-incubating
Reporter: Satish Duggana
 Fix For: 0.8-incubating


Currently atlas types support attributes containing unique attributes. Enhance 
this to support composite unique attributes. 

For example,
DeviceInfo has attributes like name, model, version and timestamp. Any of these 
attributes can be configured unique constraint. There should be a way to set 
composite unique constraint on both model and version fields so that it should 
not allow storing entities having same set of values for both model and version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1015) ClassCastException: scala.math.BigInt cannot be cast to java.lang.Long for an attribute with data type as Long.

[Satish Duggana (JIRA)]

Satish Duggana created ATLAS-1015:
-

 Summary: ClassCastException: scala.math.BigInt cannot be cast to 
java.lang.Long for an attribute with data type as Long.
 Key: ATLAS-1015
 URL: https://issues.apache.org/jira/browse/ATLAS-1015
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8-incubating
Reporter: Satish Duggana
Priority: Critical
 Fix For: 0.8-incubating


A type is created with the below info. An entity is created with respective 
attributes including the Long value for timestamp. But when that stored entity 
is retrieved, it returns a Referenceable with timestamp attribute containing   
scala.math.BigInt type instead of java.lang.Long type 

{code:java}
TypesUtil.createClassTypeDef(
DeviceInfo.NAME_SPACE, null,
TypesUtil.createUniqueRequiredAttrDef(DeviceInfo.NAME, 
DataTypes.STRING_TYPE),
TypesUtil.createUniqueRequiredAttrDef(DeviceInfo.XID, 
DataTypes.STRING_TYPE),
attrDef(DeviceInfo.TIMESTAMP, DataTypes.LONG_TYPE),
attrDef(DeviceInfo.VERSION, DataTypes.STRING_TYPE)
);
{code}

You can look at the test code 
[here|https://github.com/satishd/incubator-atlas/blob/types-poc/samples/src/test/java/org/apache/atlas/sample/AtlasMetadataServiceTest.java]




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374305#comment-15374305
 ] 

Vimal Sharma commented on ATLAS-1009:
-

[~madhan.neethiraj] ATLAS_CONF is required to get atlas-application.properties. 
The import_hive.sh script needs Atlas configuration like "atlas.rest.address" 
to communicate imported data to Atlas server.

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009-v2.patch, ATLAS-1009-v3.patch, 
> ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49956: ATLAS-1010 Atlas allows recreation of tags with same name

[David Kantor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49956/#review141995
---



PLease hold off on committing this, I need more time to review.  The fact that 
it breaks StoreBackedTypeCache is a concern.

- David Kantor


On July 12, 2016, 4:11 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49956/
> ---
> 
> (Updated July 12, 2016, 4:11 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1010
> https://issues.apache.org/jira/browse/ATLAS-1010
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Transient type system which validates the new types being added, wasn't 
> checking against the singleton instance
> 
> 
> Diffs
> -
> 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java
>  ee4cc28 
>   
> repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java
>  4cb5c67 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> c355ba9 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/EnumTest.java 
> adbeb19 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java
>  574e0f9 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java
>  7675195 
> 
> Diff: https://reviews.apache.org/r/49956/diff/
> 
> 
> Testing
> ---
> 
> UT, IT added
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 49956: ATLAS-1010 Atlas allows recreation of tags with same name

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49956/#review141992
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 12, 2016, 4:11 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49956/
> ---
> 
> (Updated July 12, 2016, 4:11 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1010
> https://issues.apache.org/jira/browse/ATLAS-1010
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Transient type system which validates the new types being added, wasn't 
> checking against the singleton instance
> 
> 
> Diffs
> -
> 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java
>  ee4cc28 
>   
> repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java
>  4cb5c67 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> c355ba9 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/EnumTest.java 
> adbeb19 
>   
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java
>  574e0f9 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java
>  7675195 
> 
> Diff: https://reviews.apache.org/r/49956/diff/
> 
> 
> Testing
> ---
> 
> UT, IT added
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

[jira] [Commented] (ATLAS-991) Lower bound checking not always disabled for Entities being deleted

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373948#comment-15373948
 ] 

ATLAS QA commented on ATLAS-991:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12817532/rb49869.patch
  against master revision e13fa5e.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 381 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsplugin-classloader.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/405//console

This message is automatically generated.

> Lower bound checking not always disabled for Entities being deleted
> ---
>
> Key: ATLAS-991
> URL: https://issues.apache.org/jira/browse/ATLAS-991
> Project: Atlas
>  Issue Type: Bug
>Reporter: Jeffrey Hagelberg
>Assignee: David Kantor
> Attachments: rb49869.patch
>
>
> It is often the case multiple entities get deleted at the same time.  The 
> current delete logic does not compute the delete closure up front, so it is 
> possible for the processing of a particular Entity to trigger a lower bound 
> violation in an entity that will be deleted but has not been processed yet.
> This issue is specific to hard delete.  It does not happen when soft delete 
> is being used.
> Here's a simple test that can be added to 
> GraphBackedMetadataRepositoryDeleteTestBase to reproduce the issue:
> {noformat}
> @Test
> public void testLowerBoundsIgnoredOnDeletedEntities() throws Exception {
> 
> String hrDeptGuid = createHrDeptGraph();
> ITypedReferenceableInstance hrDept = 
> repositoryService.getEntityDefinition(hrDeptGuid);
> Map nameGuidMap = getEmployeeNameGuidMap(hrDept);
> ITypedReferenceableInstance john = 
> repositoryService.getEntityDefinition(nameGuidMap.get("John"));
> String johnGuid = 

[jira] [Commented] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Madhan Neethiraj (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373936#comment-15373936
 ] 

Madhan Neethiraj commented on ATLAS-1009:
-

[~svimal2106] updated import-hive.sh script, in ATLAS-1009-v3.patch, still has 
references to ATLAS_CONF. What does the script need under this directory? This 
directory may not be present in the host where import-hive.sh is run. Please 
review and update.

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009-v2.patch, ATLAS-1009-v3.patch, 
> ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49869: ATLAS-991: avoid enforcing required attributes on deleted entities

[David Kantor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49869/
---

(Updated July 12, 2016, 10:24 p.m.)


Review request for atlas.


Bugs: ATLAS-991
https://issues.apache.org/jira/browse/ATLAS-991


Repository: atlas


Description
---

When deleting entities, avoid enforcing lower bound constraints (i.e. required 
attributes) on all entities being deleted.  Previously, only the entities that 
were specifically requested for deletion were skipped when enforcing required 
attributes, but any composite entities that were owned by 'root' deletion 
candidates were not skipped, causing NullRequiredAttributeException to be 
thrown unnecessarily.


Diffs
-

  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
91f9bd008a6939dfe78656f5c1845637a30ee9eb 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 e5c0e46e2ed1d9e0be987c30b9a0613784c82627 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
4f531e28173f79d63dc3642f2aedd69df2fa12a6 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
 34842c3dc2904b123fecb5087aee357678b00156 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java
 cc6026461bcd38b83dde0bcec2e835f5824e894f 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java
 90bb635126a02cd38c045bd5332499c4481d3751 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/49869/diff/


Testing
---

Ran all unit and integration tests with no regressions.


Thanks,

David Kantor

[jira] [Updated] (ATLAS-991) Lower bound checking not always disabled for Entities being deleted

[David Kantor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor updated ATLAS-991:
---
Attachment: rb49869.patch

See https://reviews.apache.org/r/49869/ for changes.

> Lower bound checking not always disabled for Entities being deleted
> ---
>
> Key: ATLAS-991
> URL: https://issues.apache.org/jira/browse/ATLAS-991
> Project: Atlas
>  Issue Type: Bug
>Reporter: Jeffrey Hagelberg
>Assignee: David Kantor
> Attachments: rb49869.patch
>
>
> It is often the case multiple entities get deleted at the same time.  The 
> current delete logic does not compute the delete closure up front, so it is 
> possible for the processing of a particular Entity to trigger a lower bound 
> violation in an entity that will be deleted but has not been processed yet.
> This issue is specific to hard delete.  It does not happen when soft delete 
> is being used.
> Here's a simple test that can be added to 
> GraphBackedMetadataRepositoryDeleteTestBase to reproduce the issue:
> {noformat}
> @Test
> public void testLowerBoundsIgnoredOnDeletedEntities() throws Exception {
> 
> String hrDeptGuid = createHrDeptGraph();
> ITypedReferenceableInstance hrDept = 
> repositoryService.getEntityDefinition(hrDeptGuid);
> Map nameGuidMap = getEmployeeNameGuidMap(hrDept);
> ITypedReferenceableInstance john = 
> repositoryService.getEntityDefinition(nameGuidMap.get("John"));
> String johnGuid = john.getId()._getId();
> ITypedReferenceableInstance max = 
> repositoryService.getEntityDefinition(nameGuidMap.get("Max"));
> String maxGuid = max.getId()._getId();
> 
> ITypedReferenceableInstance jane = 
> repositoryService.getEntityDefinition(nameGuidMap.get("Jane"));
> String janeGuid = jane.getId()._getId();
> 
> //the lower bound constraint on jane.subordinates should not be 
> enforced since jane is being deleted
> deleteEntities(johnGuid, maxGuid, janeGuid);
> 
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49929: ATLAS-1003: ensure tests cleanup graph to avoid leaving data that affects downstream tests

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49929/#review141953
---


Ship it!




Ship It!

- Jeff Hagelberg


On July 12, 2016, 2:55 p.m., David Kantor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49929/
> ---
> 
> (Updated July 12, 2016, 2:55 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1003
> https://issues.apache.org/jira/browse/ATLAS-1003
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1003: Ignore exception from TitanGraph.shutdown() and continue 
> processing TitanCleanup.clear() to ensure tests don't leave data in the graph 
> that could cause problems for subsequent tests.  Previously, some tests would 
> fail depending on the order that the maven surefire plugin executed the 
> tests, due to type data left over in the graph store from a previous test.
> 
> 
> Diffs
> -
> 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
>  da47dc1b90322189e3129ed8e4185a832bc49678 
>   
> repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java
>  4cb5c678f0f530f2c1ef517f3a4fb5d8b4f4fb37 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 
> b23c0f60ace59fa15886c94f35e35d3113872783 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
> 0e0ac8633a256dc7c8966c2b8d52eb942b52e1c6 
> 
> Diff: https://reviews.apache.org/r/49929/diff/
> 
> 
> Testing
> ---
> 
> All repository tests now pass, regardless of test order.
> 
> 
> Thanks,
> 
> David Kantor
> 
>

[jira] [Updated] (ATLAS-1014) Unnecessary locking and double checked locking for a threadlocal in RequestContext.

[Satish Duggana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Satish Duggana updated ATLAS-1014:
--
Description: 
{code:java}
public static RequestContext get() {
if (CURRENT_CONTEXT.get() == null) {
synchronized (RequestContext.class) {
if (CURRENT_CONTEXT.get() == null) {
createContext();
}
}
}
return CURRENT_CONTEXT.get();
}
{code}

There is no need to have double checked locking and synchronization for setting 
a threadlocal state. That logic can be removed by adding the below code while 
instantiating CURRENT_CONTEXT.

{code:java}

private static final ThreadLocal CURRENT_CONTEXT = new 
ThreadLocal() {
@Override
protected RequestContext initialValue() {
RequestContext context = new RequestContext();
context.requestTime = System.currentTimeMillis();
return context;
}
};
{code}
RequestContext#createContext usages can be changed to RequestContext#get

  was:

public static RequestContext get() {
if (CURRENT_CONTEXT.get() == null) {
synchronized (RequestContext.class) {
if (CURRENT_CONTEXT.get() == null) {
createContext();
}
}
}
return CURRENT_CONTEXT.get();
}

There is no need to have double checked locking and synchronization for setting 
current thread's state. That logic can be removed by adding the below code 
while instantiating CURRENT_CONTEXT.

``` java
private static final ThreadLocal CURRENT_CONTEXT = new 
ThreadLocal() {
@Override
protected RequestContext initialValue() {
RequestContext context = new RequestContext();
context.requestTime = System.currentTimeMillis();
return context;
}
};
```

RequestContext#createContext usages can be changed to RequestContext#get


> Unnecessary locking and double checked locking for a threadlocal in 
> RequestContext.
> ---
>
> Key: ATLAS-1014
> URL: https://issues.apache.org/jira/browse/ATLAS-1014
> Project: Atlas
>  Issue Type: Task
>Reporter: Satish Duggana
>
> {code:java}
> public static RequestContext get() {
> if (CURRENT_CONTEXT.get() == null) {
> synchronized (RequestContext.class) {
> if (CURRENT_CONTEXT.get() == null) {
> createContext();
> }
> }
> }
> return CURRENT_CONTEXT.get();
> }
> {code}
> There is no need to have double checked locking and synchronization for 
> setting a threadlocal state. That logic can be removed by adding the below 
> code while instantiating CURRENT_CONTEXT.
> {code:java}
> private static final ThreadLocal CURRENT_CONTEXT = new 
> ThreadLocal() {
> @Override
> protected RequestContext initialValue() {
> RequestContext context = new RequestContext();
> context.requestTime = System.currentTimeMillis();
> return context;
> }
> };
> {code}
> RequestContext#createContext usages can be changed to RequestContext#get



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1014) Unnecessary locking and double checked locking for a threadlocal in RequestContext.

[Satish Duggana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Satish Duggana updated ATLAS-1014:
--
Description: 

public static RequestContext get() {
if (CURRENT_CONTEXT.get() == null) {
synchronized (RequestContext.class) {
if (CURRENT_CONTEXT.get() == null) {
createContext();
}
}
}
return CURRENT_CONTEXT.get();
}

There is no need to have double checked locking and synchronization for setting 
current thread's state. That logic can be removed by adding the below code 
while instantiating CURRENT_CONTEXT.

``` java
private static final ThreadLocal CURRENT_CONTEXT = new 
ThreadLocal() {
@Override
protected RequestContext initialValue() {
RequestContext context = new RequestContext();
context.requestTime = System.currentTimeMillis();
return context;
}
};
```

RequestContext#createContext usages can be changed to RequestContext#get

  was:


public static RequestContext get() {
if (CURRENT_CONTEXT.get() == null) {
synchronized (RequestContext.class) {
if (CURRENT_CONTEXT.get() == null) {
createContext();
}
}
}
return CURRENT_CONTEXT.get();
}
There is no need to have double checked locking and synchronization for setting 
current thread's state. That logic can be removed by adding the below code 
while instantiating CURRENT_CONTEXT.

private static final ThreadLocal CURRENT_CONTEXT = new 
ThreadLocal<>() {
@Override
protected Object initialValue() {
RequestContext context = new RequestContext();
context.requestTime = System.currentTimeMillis();
return context;
}
};


RequestContext#createContext usages can be changed to RequestContext#get


> Unnecessary locking and double checked locking for a threadlocal in 
> RequestContext.
> ---
>
> Key: ATLAS-1014
> URL: https://issues.apache.org/jira/browse/ATLAS-1014
> Project: Atlas
>  Issue Type: Task
>Reporter: Satish Duggana
>
> public static RequestContext get() {
> if (CURRENT_CONTEXT.get() == null) {
> synchronized (RequestContext.class) {
> if (CURRENT_CONTEXT.get() == null) {
> createContext();
> }
> }
> }
> return CURRENT_CONTEXT.get();
> }
> There is no need to have double checked locking and synchronization for 
> setting current thread's state. That logic can be removed by adding the below 
> code while instantiating CURRENT_CONTEXT.
> ``` java
> private static final ThreadLocal CURRENT_CONTEXT = new 
> ThreadLocal() {
> @Override
> protected RequestContext initialValue() {
> RequestContext context = new RequestContext();
> context.requestTime = System.currentTimeMillis();
> return context;
> }
> };
> ```
> RequestContext#createContext usages can be changed to RequestContext#get



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1012) DefaultMetadataService#getEntityDefinition(String guid) returns a deleted instance with SoftDeleteHandler

[Satish Duggana (JIRA)]

Satish Duggana created ATLAS-1012:
-

 Summary: DefaultMetadataService#getEntityDefinition(String guid) 
returns a deleted instance with SoftDeleteHandler
 Key: ATLAS-1012
 URL: https://issues.apache.org/jira/browse/ATLAS-1012
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8-incubating
Reporter: Satish Duggana
 Fix For: 0.8-incubating


`DefaultMetadataService#getEntityDefinition(String guid)` returns a deleted 
instance when atlas.DeleteHandler.impl is configured with 
`org.apache.atlas.repository.graph.SoftDeleteHandler`

Main reason seems to be about not checking for a valid state of the instance 
before it is returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1003) DataSetLineageServiceTest, GraphBackedDiscoveryServiceTest, and GraphRepoMapperScaleTest failing in some environments

[David Kantor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor updated ATLAS-1003:

Attachment: rb49929.patch

> DataSetLineageServiceTest, GraphBackedDiscoveryServiceTest, and 
> GraphRepoMapperScaleTest failing in some environments
> -
>
> Key: ATLAS-1003
> URL: https://issues.apache.org/jira/browse/ATLAS-1003
> Project: Atlas
>  Issue Type: Bug
>Reporter: David Kantor
>Assignee: David Kantor
> Attachments: rb49929.patch
>
>
> DataSetLineageServiceTest, GraphBackedDiscoveryServiceTest, and 
> GraphRepoMapperScaleTest are failing in some environments, depending on the 
> order in which the surefire plugin runs the repository tests.  On my Windows 
> box, these tests consistently pass when running the repository tests.  But on 
> my Linux VM, the surefire plugin runs the repository tests in a different 
> order, and the tests listed above consistently fail, due to what appears to 
> be a type system incompatibility between types left around by previously run 
> tests and the types defined/used by these tests.  For example, here is the 
> stack trace from the DataSetLineageServiceTest failure:
> {noformat}Running org.apache.atlas.discovery.DataSetLineageServiceTest
> Tests run: 60, Failures: 1, Errors: 0, Skipped: 59, Time elapsed: 11,167.532 
> sec <<< FAILURE! - in org.apache.atlas.discovery.DataSetLineageServiceTest
> setUp(org.apache.atlas.discovery.DataSetLineageServiceTest)  Time elapsed: 
> 11,166.618 sec  <<< FAILURE!
> org.apache.atlas.typesystem.types.ValueConversionException: Cannot convert 
> value '{Id='(type: hive_process, id: )', traits=[ETL], 
> values={startTime=1468254266594, inputs=[(type: hive_table, id: 
> 2e600105-d4a9-4a3a-8f7b-d81fedbf3abc), (type: hive_table, id: 
> 9d71dc2d-4a6a-4365-858c-d7d6c2ab88da)], description=hive query for daily 
> summary, queryGraph=graph, qualifiedName=loadSalesDaily, name=loadSalesDaily, 
> queryId=id, queryText=create table as select , outputs=[(type: hive_table, 
> id: 908a7192-080a-4c59-a6c1-3a75f68b7d37)], endTime=1468254276594, user=John 
> ETL, queryPlan=plan}}' to datatype hive_process
> at 
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:100)
> at 
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:46)
> at 
> org.apache.atlas.typesystem.types.DataTypes$ArrayType.convert(DataTypes.java:495)
> at 
> org.apache.atlas.typesystem.types.DataTypes$ArrayType.convert(DataTypes.java:464)
> at 
> org.apache.atlas.typesystem.persistence.StructInstance.set(StructInstance.java:121)
> at 
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:143)
> at 
> org.apache.atlas.BaseRepositoryTest.createInstance(BaseRepositoryTest.java:373)
> at 
> org.apache.atlas.BaseRepositoryTest.loadProcess(BaseRepositoryTest.java:351)
> at 
> org.apache.atlas.BaseRepositoryTest.setupInstances(BaseRepositoryTest.java:227)
> at 
> org.apache.atlas.BaseRepositoryTest.setUp(BaseRepositoryTest.java:73)
> at 
> org.apache.atlas.discovery.DataSetLineageServiceTest.setUp(DataSetLineageServiceTest.java:67){noformat}
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 49929: ATLAS-1003: ensure tests cleanup graph to avoid leaving data that affects downstream tests

[David Kantor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49929/
---

Review request for atlas.


Bugs: ATLAS-1003
https://issues.apache.org/jira/browse/ATLAS-1003


Repository: atlas


Description
---

ATLAS-1003: Ignore exception from TitanGraph.shutdown() and continue processing 
TitanCleanup.clear() to ensure tests don't leave data in the graph that could 
cause problems for subsequent tests.  Previously, some tests would fail 
depending on the order that the maven surefire plugin executed the tests, due 
to type data left over in the graph store from a previous test.


Diffs
-

  
repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
 da47dc1b90322189e3129ed8e4185a832bc49678 
  
repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java
 4cb5c678f0f530f2c1ef517f3a4fb5d8b4f4fb37 
  repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 
b23c0f60ace59fa15886c94f35e35d3113872783 
  repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
0e0ac8633a256dc7c8966c2b8d52eb942b52e1c6 

Diff: https://reviews.apache.org/r/49929/diff/


Testing
---

All repository tests now pass, regardless of test order.


Thanks,

David Kantor

[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372801#comment-15372801
 ] 

ATLAS QA commented on ATLAS-847:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12817403/ATLAS-847.1.patch
  against master revision e13fa5e.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/402//console

This message is automatically generated.

> UI: Audit versioning does not paginate details from Atlas server
> 
>
> Key: ATLAS-847
> URL: https://issues.apache.org/jira/browse/ATLAS-847
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Kalyani Kashikar
>Priority: Critical
> Attachments: ATLAS-847.1.patch, ATLAS-847.patch, audit_pagination.png
>
>
> In ATLAS-664, the capability to view Audit events was added to the Atlas 
> admin UI. However, currently, the API call made only fetches the first 100 
> events (which is the default if no count is sent). In order to fetch the next 
> set of events, further API calls need to be made to the Audit API, by 
> providing additional parameters in the API. This JIRA is to track the 
> required changes in UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server

[Kalyani Kashikar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kalyani Kashikar updated ATLAS-847:
---
Attachment: ATLAS-847.1.patch

This patch is dependent on ATLAS-1004.

> UI: Audit versioning does not paginate details from Atlas server
> 
>
> Key: ATLAS-847
> URL: https://issues.apache.org/jira/browse/ATLAS-847
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Kalyani Kashikar
>Priority: Critical
> Attachments: ATLAS-847.1.patch, ATLAS-847.patch, audit_pagination.png
>
>
> In ATLAS-664, the capability to view Audit events was added to the Atlas 
> admin UI. However, currently, the API call made only fetches the first 100 
> events (which is the default if no count is sent). In order to fetch the next 
> set of events, further API calls need to be made to the Audit API, by 
> providing additional parameters in the API. This JIRA is to track the 
> required changes in UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372790#comment-15372790
 ] 

ATLAS QA commented on ATLAS-1009:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12817387/ATLAS-1009-v3.patch
  against master revision e13fa5e.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 381 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsplugin-classloader.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/401//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/401//console

This message is automatically generated.

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009-v2.patch, ATLAS-1009-v3.patch, 
> ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1004) Option to enable taxonomy feature

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372713#comment-15372713
 ] 

ATLAS QA commented on ATLAS-1004:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12817377/ATLAS-1004.patch
  against master revision e13fa5e.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 382 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsplugin-classloader.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/400//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/400//console

This message is automatically generated.

> Option to enable taxonomy feature
> -
>
> Key: ATLAS-1004
> URL: https://issues.apache.org/jira/browse/ATLAS-1004
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Madhan Neethiraj
>Assignee: Keval Bhatt
> Attachments: ATLAS-1004.patch
>
>
> Currently 'term' object used in taxonomy feature implementation is modeled as 
> a trait. However, unlike tags, all the associations of a term (with entities) 
> share the attribute values of the term object. This and few other aspects of 
> taxonomy implementation would need to be reviewed. Until then, this feature 
> should be available in the UI only for users who opt-in to enable, via a 
> configuration - like atlas.feature.taxonomy.enable=true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1004) Option to enable taxonomy feature

[Madhan Neethiraj (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372685#comment-15372685
 ] 

Madhan Neethiraj commented on ATLAS-1004:
-

+1 for the patch

> Option to enable taxonomy feature
> -
>
> Key: ATLAS-1004
> URL: https://issues.apache.org/jira/browse/ATLAS-1004
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Madhan Neethiraj
>Assignee: Keval Bhatt
> Attachments: ATLAS-1004.patch
>
>
> Currently 'term' object used in taxonomy feature implementation is modeled as 
> a trait. However, unlike tags, all the associations of a term (with entities) 
> share the attribute values of the term object. This and few other aspects of 
> taxonomy implementation would need to be reviewed. Until then, this feature 
> should be available in the UI only for users who opt-in to enable, via a 
> configuration - like atlas.feature.taxonomy.enable=true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49949: ATLAS-1004 : Option to enable taxonomy feature

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49949/#review141882
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 12, 2016, 9:04 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49949/
> ---
> 
> (Updated July 12, 2016, 9:04 a.m.)
> 
> 
> Review request for atlas, Gautam Borad, Madhan Neethiraj, and Shwetha GS.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently 'term' object used in taxonomy feature implementation is modeled as 
> a trait. However, unlike tags, all the associations of a term (with entities) 
> share the attribute values of the term object. This and few other aspects of 
> taxonomy implementation would need to be reviewed. Until then, this feature 
> should be available in the UI only for users who opt-in to enable, via a 
> configuration - like atlas.feature.taxonomy.enable=true.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/loader.scss d668c38 
>   dashboardv2/public/css/scss/theme.scss 2577cfc 
>   dashboardv2/public/js/main.js 552d906 
>   dashboardv2/public/js/router/Router.js 83e1d24 
>   
> dashboardv2/public/js/templates/business_catalog/SideNavLayoutView_tmpl.html 
> 6d504ba 
>   dashboardv2/public/js/templates/common/TableLayout_tmpl.html b5a0472 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 1083b34 
>   dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 8ab545e 
>   dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 
> 5caa3ea 
>   dashboardv2/public/js/utils/TableLayout.js 6528193 
>   dashboardv2/public/js/utils/Utils.js 8e33ef9 
>   dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js 5837006 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 2aaeaa4 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js b021127 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 5ec1b22 
>   dashboardv2/public/js/views/tag/TagLayoutView.js 49811ac 
>   distro/src/conf/atlas-application.properties 79723f4 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> b7f6cf2 
> 
> Diff: https://reviews.apache.org/r/49949/diff/
> 
> 
> Testing
> ---
> 
> Verfied all scenerio by enabling and disabling this property 
> *atlas.feature.taxonomy.enable*
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

[jira] [Updated] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1009:

Attachment: ATLAS-1009-v3.patch

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009-v2.patch, ATLAS-1009-v3.patch, 
> ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1011) Flex based component using FileReference Upload API fails with 400 Bad Request for multi upload scenario because of missing boundary conditions

[Vamshi Krishna Kaley (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372564#comment-15372564
 ] 

Vamshi Krishna Kaley commented on ATLAS-1011:
-

Attaching the mail containing details of the issue

[^RE  St Jude   Multiple SCORM Uploads   Troubleshooting with Engg and CO.msg] 
_(1.38 MB)_

> Flex based component using FileReference Upload API fails with 400 Bad 
> Request for multi upload scenario because of missing boundary conditions
> ---
>
> Key: ATLAS-1011
> URL: https://issues.apache.org/jira/browse/ATLAS-1011
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vamshi Krishna Kaley
> Attachments: RE  St Jude   Multiple SCORM Uploads   Troubleshooting 
> with Engg and CO.msg
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1011) Flex based component using FileReference Upload API fails with 400 Bad Request for multi upload scenario because of missing boundary conditions

[Vamshi Krishna Kaley (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372562#comment-15372562
 ] 

Vamshi Krishna Kaley commented on ATLAS-1011:
-

We have developed a component of multi file upload using flex sdk 3 using 
FileReference Upload built in functionality.

However we have encountered that the upload fails for more than two files over 
slow transmission networks.

On further investigation  We found that the flash is resulting in I/O Errors 
during the retrieval of total bytes being uploaded for display in the upload 
progress with the log information as displayed below
==
388956 AVMINF: MTHD flash.events::ProgressEvent/get bytesLoaded ()
388958 AVMINF: MTHD flash.events::ProgressEvent/get bytesTotal ()
388960 AVMINF: MTHD flash.events::IOErrorEvent ()
388962 AVMINF: MTHD flash.events::ErrorEvent ()
388964 AVMINF: MTHD flash.events::TextEvent ()
388965 AVMINF: MTHD flash.events::Event ()
388967 AVMINF: MTHD flash.events::Event/ctor ()
388970 AVMINF: MTHD FileUpload/OnIOError ()
388972 AVMINF: MTHD flash.events::IOErrorEvent/toString ()
IOError Event : Dispatched when the upload or download fails.[IOErrorEvent 
type="ioError" bubbles=false cancelable=false eventPhase=2 text="Error #2038: 
File I/O Error. URL: <>
=

Due to this error the POST request is resulting in Bad Requests on the Web 
Server because of the missing boundary closures which are required to complete 
the POST request.

This issue is always replicable on slow networks which are hovering around 
100Kbps

Request you to look into it and do the needful to provide a fix which needs to 
be incorporated as one of our customers are critically affected with this 
functionality miss.


> Flex based component using FileReference Upload API fails with 400 Bad 
> Request for multi upload scenario because of missing boundary conditions
> ---
>
> Key: ATLAS-1011
> URL: https://issues.apache.org/jira/browse/ATLAS-1011
> Project: Atlas
>  Issue Type: Bug
>Reporter: Vamshi Krishna Kaley
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1011) Flex based component using FileReference Upload API fails with 400 Bad Request for multi upload scenario because of missing boundary conditions

[Vamshi Krishna Kaley (JIRA)]

Vamshi Krishna Kaley created ATLAS-1011:
---

 Summary: Flex based component using FileReference Upload API fails 
with 400 Bad Request for multi upload scenario because of missing boundary 
conditions
 Key: ATLAS-1011
 URL: https://issues.apache.org/jira/browse/ATLAS-1011
 Project: Atlas
  Issue Type: Bug
Reporter: Vamshi Krishna Kaley






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1009:

Attachment: ATLAS-1009-v2.patch

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009-v2.patch, ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372528#comment-15372528
 ] 

Vimal Sharma commented on ATLAS-1009:
-

removed and updated

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009-v2.patch, ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ATLAS-1010) Atlas allows recreation of tags with same name

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S reassigned ATLAS-1010:
--

Assignee: Shwetha G S

> Atlas allows recreation of tags with same name
> --
>
> Key: ATLAS-1010
> URL: https://issues.apache.org/jira/browse/ATLAS-1010
> Project: Atlas
>  Issue Type: Bug
> Environment: Atlas - 0.8
>Reporter: Sharmadha Sainath
>Assignee: Shwetha G S
>Priority: Critical
>
> On Atlas UI, created a tag "tag1" with a description.
> recreated tag with same name with different description. tag POST was 
> successful and replaced the old one (the description of tag1 was the that of 
> recreated one).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1009:

Attachment: ATLAS-1009.patch

> Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
> ---
>
> Key: ATLAS-1009
> URL: https://issues.apache.org/jira/browse/ATLAS-1009
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1009.patch
>
>
> Change import_hive.sh so that required environment variables HIVE_HOME and 
> HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1010) Atlas allows recreation of tags with same name

[Sharmadha Sainath (JIRA)]

Sharmadha Sainath created ATLAS-1010:


 Summary: Atlas allows recreation of tags with same name
 Key: ATLAS-1010
 URL: https://issues.apache.org/jira/browse/ATLAS-1010
 Project: Atlas
  Issue Type: Bug
 Environment: Atlas - 0.8
Reporter: Sharmadha Sainath
Priority: Critical


On Atlas UI, created a tag "tag1" with a description.
recreated tag with same name with different description. tag POST was 
successful and replaced the old one (the description of tag1 was the that of 
recreated one).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1009) Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1009:
---

 Summary: Source HIVE_HOME and HIVE_CONF_DIR from hive_env.sh
 Key: ATLAS-1009
 URL: https://issues.apache.org/jira/browse/ATLAS-1009
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.7-incubating
Reporter: Vimal Sharma
Assignee: Vimal Sharma
 Fix For: 0.7-incubating


Change import_hive.sh so that required environment variables HIVE_HOME and 
HIVE_CONF_DIR are sourced from hive_env.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1008) Change log message in HiveMetaStoreBridge

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1008:
---

 Summary: Change log message in HiveMetaStoreBridge
 Key: ATLAS-1008
 URL: https://issues.apache.org/jira/browse/ATLAS-1008
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma
Priority: Trivial


LOG.error("Unable to import {} tables out of {} tables from {}", 
tablesImported, hiveTables.size(), databaseName);

Unable to import 18 tables out of 19 tables from default 
(HiveMetaStoreBridge:318)

No of tables successfully imported are print instead of the number of tables 
for which import failed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-796) Fulltext search 500 Error

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-796:
--
Priority: Major  (was: Critical)

> Fulltext search 500 Error
> -
>
> Key: ATLAS-796
> URL: https://issues.apache.org/jira/browse/ATLAS-796
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>
> Including ":" in a fulltext query results in a 500 Error. For example: 
> http://172.22.83.187:21000/api/atlas/discovery/search/fulltext?query=d%3Aa



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-986) Ability to differentiate business catalog terms from traits

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372229#comment-15372229
 ] 

Vimal Sharma commented on ATLAS-986:


+1

> Ability to differentiate business catalog terms from traits
> ---
>
> Key: ATLAS-986
> URL: https://issues.apache.org/jira/browse/ATLAS-986
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-986.1.patch, ATLAS-986.2.patch, ATLAS-986.patch
>
>
> Currently Terms are created a traits and there is no way to differentiate 
> them. 
> Proposal is to add a superType TaxonomyTerm which all Business Catalog terms 
> will inherit from to differentiate them in the model.
> So , any term type should have TaxononyTerm in its supertypes
> To differentiate them during notifications, TaxonmoyTerm  type will have a  
> "namespace" attribute which will be set to  value "atlas.taxonomy" for all 
> terms during their creation. Normal trait instances which are created and 
> associated with entities will not have this attribute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-347) Atlas search APIs should allow pagination of results

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-347:
--
Attachment: ATLAS-347-v2.patch

orderby doesn't require fully qualified field name anymore. For example, 
'hive_table orderby name' resolves name to 'hive_table orderby Asset.name'
limit and offset in API and queries are merged - final limit=min(API limit, 
query limit), final offset=(API offset + query offset)
limit and offset params in API are optional and have 100, and 0 as defaults 
respectively
Pagination of full text search results will be handled in another jira
DSL query supported multiple query source, for example 'hive_table as t where 
name = 'xx', hive_db as d where name = 'yy' select t.name, d.name'. There can 
be single select in the query. But the QueryParser had wrong syntx of 
supporting multiple selects, fixed that. So, DSL query can contain multiple 
query sources with where clause, but can contain single select, orderby and 
limit
orderby using alias doesn't work - hive_table select name as n orderby n. But 
hive_table select name as n orderby 'n' works. Created ATLAS-1007
Added/modified tests


> Atlas search APIs should allow pagination of results
> 
>
> Key: ATLAS-347
> URL: https://issues.apache.org/jira/browse/ATLAS-347
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Hemanth Yamijala
>Assignee: Shwetha G S
>Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-347-v2.patch, ATLAS-347.patch
>
>
> Currently, we can search for all entities of type like a hive table or hive 
> column (query string is hive_table or hive_column). The API returns all 
> results at one shot in this case. With a sufficiently large number of 
> entities, this would be a huge list and a lot of data flowing from server to 
> UI. To scale this better, we should have a way of specifying to get a page of 
> results at a time in the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1007) Orderby using alias doesn't work

[Shwetha G S (JIRA)]

Shwetha G S created ATLAS-1007:
--

 Summary: Orderby using alias doesn't work
 Key: ATLAS-1007
 URL: https://issues.apache.org/jira/browse/ATLAS-1007
 Project: Atlas
  Issue Type: Bug
Reporter: Shwetha G S


DSL query 'hive_table select name as n orderby n' doesn't work. But 'hive_table 
select name as n orderby "n"' works



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)