Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification

2016-12-15 Thread Apoorv Naik
passing. Thanks, Apoorv Naik

Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification

2016-12-15 Thread Apoorv Naik
/TypeUtils.java (line 100) <https://reviews.apache.org/r/53789/#comment230356> This change shouldn't be here. It's a wrong negation expression. - Apoorv Naik On Dec. 14, 2016, 8:40 p.m., Apoorv Naik

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

2016-12-14 Thread Apoorv Naik
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 43414c9597b5c88c3e5fed45628abd1bbe0b9185 Diff: https://reviews.apache.org/r/54233/diff/ Testing --- UTs passing for AtlasTypedefStore Thanks, Apoorv Naik

Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification

2016-12-14 Thread Apoorv Naik
: https://reviews.apache.org/r/53789/diff/ Testing --- Unit Tests passing. Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1304) Code cleanup and simplification

2016-12-14 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1304: --- Attachment: ATLAS-1304.patch > Code cleanup and simplificat

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-13 Thread Apoorv Naik
/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 Diff: https://reviews.apache.org/r/54058/diff/ Testing --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.v5.patch > Integration tests for Entity V2 REST A

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-13 Thread Apoorv Naik
ename or supertype in the request to be > > provided mandatorily. Else it will end up running a query which may not be > > indexed. > > Apoorv Naik wrote: > I've added a todo section for this in the store class. Will be adding this

Review Request 54722: ATLAS-1301: Client simplification and bugfixes

2016-12-13 Thread Apoorv Naik
/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 Diff: https://reviews.apache.org/r/54722/diff/ Testing --- UnitTests passing Integration tests passing Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1301) Client calls from the IT retries more than what's specified

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1301: --- Attachment: ATLAS-1301.patch > Client calls from the IT retries more than what's specif

[jira] [Commented] (ATLAS-1245) More objects should have a unique guid

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745967#comment-15745967 ] Apoorv Naik commented on ATLAS-1245: Ok so in V2 we call trait as classification and during creation

[jira] [Comment Edited] (ATLAS-1245) More objects should have a unique guid

2016-12-13 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745967#comment-15745967 ] Apoorv Naik edited comment on ATLAS-1245 at 12/13/16 7:09 PM: -- Ok so in V2 we

Re: Review Request 53748: Updated equals and hashCode

2016-12-12 Thread Apoorv Naik
) --- Unit tests passing. Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1303) Update hashCode and equals method to use standard JDK libraries

2016-12-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1303: --- Attachment: (was: 0001-Updated-equals-and-hashCode-signatures.patch) > Update hashCode and equ

[jira] [Updated] (ATLAS-1303) Update hashCode and equals method to use standard JDK libraries

2016-12-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1303: --- Attachment: ATLAS-1303.patch > Update hashCode and equals method to use standard JDK librar

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-12-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.v4.patch > Integration tests for Entity V2 REST A

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
install -Pdist was successful Thanks, Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
eviews.apache.org/r/54058/#review158111 --- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158102 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
is this not available for test already in the same patch through > > EntitiesREST.searchEntities? > > Apoorv Naik wrote: > Search was marked as a todo feature, hence added a todo here as well. The search functionality is being added to the store, right now the code doesn't u

[jira] [Created] (ATLAS-1370) Built-in API testbed

2016-12-12 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1370: -- Summary: Built-in API testbed Key: ATLAS-1370 URL: https://issues.apache.org/jira/browse/ATLAS-1370 Project: Atlas Issue Type: Improvement Affects Versions

[jira] [Commented] (ATLAS-1318) Atlas Type System does not have DELETE API

2016-12-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743056#comment-15743056 ] Apoorv Naik commented on ATLAS-1318: Right now there's an experimental API in the TypesREST class

Re: Review Request 54430: Atlas-1186: Add glossary Categories

2016-12-12 Thread Apoorv Naik
oryResourceProvider.java (line 58) <https://reviews.apache.org/r/54430/#comment229118> Template instead of string concatenation. - Apoorv Naik On Dec. 7, 2016, 2:42 p.m., David Radley wrote: > > --- > This is an automat

[jira] [Commented] (ATLAS-1245) More objects should have a unique guid

2016-12-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742654#comment-15742654 ] Apoorv Naik commented on ATLAS-1245: Hey David, There are new v2 APIs in place in which all the types

[jira] [Commented] (ATLAS-1363) Upgrade front end maven plugin to 1.0

2016-12-09 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736127#comment-15736127 ] Apoorv Naik commented on ATLAS-1363: +1 > Upgrade front end maven plugin to

[jira] [Updated] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes

2016-12-08 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1358: --- Attachment: ATLAS-1358.1.patch Few more fixes are ITs were failing > NPE in AtlasTypedefStoreT

[jira] [Created] (ATLAS-1360) Actual UnitTests instead of ITs disguised as UTs

2016-12-08 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1360: -- Summary: Actual UnitTests instead of ITs disguised as UTs Key: ATLAS-1360 URL: https://issues.apache.org/jira/browse/ATLAS-1360 Project: Atlas Issue Type: Wish

[jira] [Updated] (ATLAS-1345) V2 Search API enhancement to honor hierarchical references

2016-12-08 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1345: --- Attachment: ATLAS-1345.1.patch > V2 Search API enhancement to honor hierarchical referen

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

2016-12-08 Thread Apoorv Naik
cdbde1b8cf00975752df80213d06015aff3fd308 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649 Diff: https://reviews.apache.org/r/54233/diff/ Testing --- UTs passing for AtlasTypedefStore Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1359) Move new client classes to atlas-intg

2016-12-08 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1359: -- Summary: Move new client classes to atlas-intg Key: ATLAS-1359 URL: https://issues.apache.org/jira/browse/ATLAS-1359 Project: Atlas Issue Type: Improvement

[jira] [Commented] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes

2016-12-08 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732936#comment-15732936 ] Apoorv Naik commented on ATLAS-1358: UnitTests running correctly now. I haven't been able to run

[jira] [Updated] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes

2016-12-08 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1358: --- Attachment: ATLAS-1358.patch > NPE in AtlasTypedefStoreTest after SearchFilter chan

[jira] [Created] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes

2016-12-08 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1358: -- Summary: NPE in AtlasTypedefStoreTest after SearchFilter changes Key: ATLAS-1358 URL: https://issues.apache.org/jira/browse/ATLAS-1358 Project: Atlas Issue Type

[jira] [Updated] (ATLAS-1357) Fix for failures from ATLAS-1307

2016-12-08 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1357: --- Attachment: ATLAS-1357.patch > Fix for failures from ATLAS-1

[jira] [Created] (ATLAS-1357) Fix for failures from ATLAS-1307

2016-12-07 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1357: -- Summary: Fix for failures from ATLAS-1307 Key: ATLAS-1357 URL: https://issues.apache.org/jira/browse/ATLAS-1357 Project: Atlas Issue Type: Bug Affects

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-07 Thread Apoorv Naik
----- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- &

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-07 Thread Apoorv Naik
ps://reviews.apache.org/r/54058/#review158112 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-07 Thread Apoorv Naik
ly, visit: https://reviews.apache.org/r/54058/#review158113 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail.

[jira] [Updated] (ATLAS-1355) Removal of superType during type updates results in a 500 Internal Server error

2016-12-07 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1355: --- Attachment: ATLAS-1355.patch > Removal of superType during type updates results in a 500 Inter

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

2016-12-07 Thread Apoorv Naik
----- On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53960/ > ---

Review Request 54500: ATLAS-1355: Fix for bad error translation from V2 API

2016-12-07 Thread Apoorv Naik
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649 Diff: https://reviews.apache.org/r/54500/diff/ Testing --- Unit tests passing. IT run pending. Thanks, Apoorv Naik

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

2016-12-06 Thread Apoorv Naik
eviews.apache.org/r/53960/#review158294 --- On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To re

[jira] [Commented] (ATLAS-1353) Invalid error message(500 internal server error) for lineage query on non-existing table.

2016-12-06 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727724#comment-15727724 ] Apoorv Naik commented on ATLAS-1353: Looks good to me. +1 > Invalid error message(500 internal ser

[jira] [Commented] (ATLAS-1342) Titan Solrclient - Add timeouts for zookeeper connect and session

2016-12-06 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727721#comment-15727721 ] Apoorv Naik commented on ATLAS-1342: Changes look good at a higher level. > Titan Solrclient -

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

2016-12-06 Thread Apoorv Naik
> On Dec. 6, 2016, 10:31 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java, > > line 122 > > <https://reviews.apache.org/r/54233/diff/1/?file=1573340#file1573340line122> > > > > The type

[jira] [Updated] (ATLAS-1307) All Integration tests should route the calls through the Client

2016-12-06 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1307: --- Attachment: ATLAS-1307.1.patch > All Integration tests should route the calls through the Cli

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

2016-12-06 Thread Apoorv Naik
webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/53960/diff/ Testing --- All tests passing Thanks, Apoorv Naik

Re: Review Request 53748: Updated equals and hashCode

2016-12-06 Thread Apoorv Naik
eviews.apache.org/r/53748/#review156234 --- On Nov. 29, 2016, 8:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 53748: Updated equals and hashCode

2016-12-06 Thread Apoorv Naik
g Lombok instead which would make the > > code more concise and less error prone - > > https://projectlombok.org/features/index.html. We could use it later for > > Getter/Setters and other useful features > > Apoorv Naik wrote: > Sure I can give it a try. Is MIT licensing o

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

2016-12-06 Thread Apoorv Naik
means that the supertype resolution doesn't happen, so only immediate supertypes pass through the filter. - Apoorv Naik On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

2016-12-06 Thread Apoorv Naik
/FilterUtil.java (line 122) <https://reviews.apache.org/r/54233/#comment229027> The type parameter is passed in as a query param, this the toUpperCase for that and then the comparison. The other option is to try getting an enum from that value if that fails return false. - Apoorv Naik

Re: Review Request 54260: ATLAS-1347: Fix error codes for exceptions

2016-12-06 Thread Apoorv Naik
/apache/atlas/AtlasErrorCode.java 84d8173acfbc8bd78263d37adab8fec011e84654 webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 7a9840b686c35936fbeae5f18cea513fc9b96655 Diff: https://reviews.apache.org/r/54260/diff/ Testing --- Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"

2016-12-06 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1347: --- Attachment: ATLAS-1347.v1.patch > Creating a class with unknown supertype results in "409

[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"

2016-12-06 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1347: --- Attachment: (was: ATLAS-1347.v1.patch) > Creating a class with unknown supertype results in &

[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"

2016-12-06 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1347: --- Attachment: ATLAS-1347.v1.patch > Creating a class with unknown supertype results in "409

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-02 Thread Apoorv Naik
of checks against a *Entity class - Apoorv Naik On Dec. 2, 2016, 3:11 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[jira] [Updated] (ATLAS-1349) Reduce excess error logging in atlas logs

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1349: --- Attachment: ATLAS-1349.patch > Reduce excess error logging in atlas l

Review Request 54260: ATLAS-1347: Fix error codes for exceptions

2016-12-01 Thread Apoorv Naik
7a9840b686c35936fbeae5f18cea513fc9b96655 Diff: https://reviews.apache.org/r/54260/diff/ Testing --- Thanks, Apoorv Naik

[jira] [Assigned] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1347: -- Assignee: Apoorv Naik > Creating a class with unknown supertype results in "409

[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1347: --- Attachment: ATLAS-1347.patch > Creating a class with unknown supertype results in "409

[jira] [Created] (ATLAS-1349) Reduce excess error logging in atlas logs

2016-12-01 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1349: -- Summary: Reduce excess error logging in atlas logs Key: ATLAS-1349 URL: https://issues.apache.org/jira/browse/ATLAS-1349 Project: Atlas Issue Type: Improvement

[jira] [Updated] (ATLAS-1346) Search APIs should return empty list instead of throwing exception

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Summary: Search APIs should return empty list instead of throwing exception (was: Fix for excessive

[jira] [Updated] (ATLAS-1346) Fix for excessive error logging in atlas logs

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Summary: Fix for excessive error logging in atlas logs (was: Exception interception fixes

[jira] [Updated] (ATLAS-1346) Exception interception fixes and reduced logging

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Summary: Exception interception fixes and reduced logging (was: Search APIs should return empty list

[jira] [Commented] (ATLAS-1346) Search APIs should return empty list instead of throwing exception

2016-12-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712575#comment-15712575 ] Apoorv Naik commented on ATLAS-1346: [~yhemanth] Thanks for the clarification Hemanth. Will look

[jira] [Updated] (ATLAS-1346) Search APIs should return empty list instead of throwing exception

2016-11-30 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Attachment: (was: ATLAS-1346.patch) > Search APIs should return empty list instead of throw

[jira] [Updated] (ATLAS-1346) Search APIs should return empty list instead of throwing exception

2016-11-30 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Attachment: ATLAS-1346.patch > Search APIs should return empty list instead of throwing except

[jira] [Created] (ATLAS-1346) Search APIs should return empty list instead of throwing exception

2016-11-30 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1346: -- Summary: Search APIs should return empty list instead of throwing exception Key: ATLAS-1346 URL: https://issues.apache.org/jira/browse/ATLAS-1346 Project: Atlas

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-11-30 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311-v3.patch > Integration tests for Entity V2 REST A

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-30 Thread Apoorv Naik
, Apoorv Naik

Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

2016-11-30 Thread Apoorv Naik
/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649 Diff: https://reviews.apache.org/r/54233/diff/ Testing --- UTs passing for AtlasTypedefStore Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1345) V2 API to provide all supertypes for a given type/entity

2016-11-30 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1345: -- Summary: V2 API to provide all supertypes for a given type/entity Key: ATLAS-1345 URL: https://issues.apache.org/jira/browse/ATLAS-1345 Project: Atlas Issue

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-11-29 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311-v2.patch > Integration tests for Entity V2 REST A

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
/TypedefsJerseyResourceIT.java 2fa1602 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/54058/diff/ Testing --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review157336 --- Needs update after the FormatAdapter changes. - Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/54058/diff/ Testing (updated) --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
/src/test/resources/atlas-application.properties (line 38) <https://reviews.apache.org/r/54058/#comment227815> Need to revert this. typesystem/src/test/resources/atlas-application.properties (line 84) <https://reviews.apache.org/r/54058/#comment227816> Same here. -

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
/SecureEmbeddedServerTestBase.java 455f121 webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java 82abc1b webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf Diff: https://reviews.apache.org/r/54058/diff/ Testing --- Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-11-29 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.patch > Integration tests for Entity V2 REST A

Re: Review Request 53748: Updated equals and hashCode

2016-11-28 Thread Apoorv Naik
://reviews.apache.org/r/53748/diff/ Testing --- Working on executing all tests Thanks, Apoorv Naik

Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-24 Thread Apoorv Naik
webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf Diff: https://reviews.apache.org/r/54058/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/#review156804 --- Ship it! Looks good to me. - Apoorv Naik On Nov. 23, 2016

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Apoorv Naik
pache.org/r/54023/#comment227077> AtlasErrorCode instead of manual string concatenation. Overall looks good to me. - Apoorv Naik On Nov. 23, 2016, 11:17 a.m., Madhan Neethiraj wrote: > > --- > This is an automatic

[jira] [Comment Edited] (ATLAS-1316) V2 API webapp tests are failing

2016-11-23 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690704#comment-15690704 ] Apoorv Naik edited comment on ATLAS-1316 at 11/23/16 4:57 PM: -- If the mvn

[jira] [Commented] (ATLAS-1316) V2 API webapp tests are failing

2016-11-23 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690704#comment-15690704 ] Apoorv Naik commented on ATLAS-1316: If the mvn verify is going through fine then lets go ahead

[jira] [Commented] (ATLAS-1315) Fix webapp Integration tests

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688515#comment-15688515 ] Apoorv Naik commented on ATLAS-1315: Just compiled and ran on a brand new VM. Looks fine now, tests

[jira] [Updated] (ATLAS-1317) Disable the problematic ITs

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1317: --- Attachment: ATLAS-1317.patch Disabling the inconsistent tests temporarily > Disable the problema

[jira] [Commented] (ATLAS-1316) V2 API webapp tests are failing

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687722#comment-15687722 ] Apoorv Naik commented on ATLAS-1316: This is because the web.xml is not in sync with the main web.xml

[jira] [Created] (ATLAS-1317) Disable the problematic ITs

2016-11-22 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1317: -- Summary: Disable the problematic ITs Key: ATLAS-1317 URL: https://issues.apache.org/jira/browse/ATLAS-1317 Project: Atlas Issue Type: Bug Affects Versions

[jira] [Updated] (ATLAS-1315) Fix webapp Integration tests

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1315: --- Attachment: Screen Shot 2016-11-22 at 9.11.55 AM.png > Fix webapp Integration te

[jira] [Updated] (ATLAS-1315) Fix webapp Integration tests

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1315: --- Attachment: Screen Shot 2016-11-22 at 9.05.41 AM.png Screen Shot 2016-11-22 at 9.03.51

[jira] [Commented] (ATLAS-1315) Fix webapp Integration tests

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687261#comment-15687261 ] Apoorv Naik commented on ATLAS-1315: Hey Ayub, The patch doesn't work on my system, I still see

[jira] [Commented] (ATLAS-1316) V2 API webapp tests are failing

2016-11-22 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687247#comment-15687247 ] Apoorv Naik commented on ATLAS-1316: Can you share the stacktrace of the failures ? This seems

Review Request 53976: ATLAS-1292: Fix for integration tests

2016-11-21 Thread Apoorv Naik
webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 Diff: https://reviews.apache.org/r/53976/diff/ Testing --- All ITs passing except the EntityNotificationIT Thanks, Apoorv Naik

Re: Review Request 53968: ATLAS-1314: update typedefs with addition of 'options' attribute

2016-11-21 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53968/#review156546 --- Ship it! Ship It! - Apoorv Naik On Nov. 21, 2016, 11:02 p.m

Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

2016-11-21 Thread Apoorv Naik
/MetadataDiscoveryJerseyResourceIT.java 9aff145 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d Diff: https://reviews.apache.org/r/53960/diff/ Testing --- All tests passing Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-11-21 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Summary: Integration tests for Entity V2 REST APIs (was: New client for Entity V2 REST APIs

[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs

2016-11-21 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Description: Currently there's no IT for the new REST API. (was: Currently there's no client

[jira] [Updated] (ATLAS-1301) Client calls from the IT retries more than what's specified

2016-11-21 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1301: --- Summary: Client calls from the IT retries more than what's specified (was: New Client retries more

[jira] [Updated] (ATLAS-1303) Update hashCode and equals method to use standard JDK libraries

2016-11-20 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1303: --- Attachment: 0001-Updated-equals-and-hashCode-signatures.patch > Update hashCode and equals met

<    1   2   3   4   5   6   7   >