[jira] [Commented] (AVRO-1747) JavaScript implementation

2015-11-04 Thread Matthieu Monsch (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991210#comment-14991210 ] Matthieu Monsch commented on AVRO-1747: --- Thanks for the feedback! 1. Will do. 2. Sur

[jira] [Commented] (AVRO-1747) JavaScript implementation

2015-11-04 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990543#comment-14990543 ] Ryan Blue commented on AVRO-1747: - Also, can you add the previous author back in the JSON m

[jira] [Comment Edited] (AVRO-1747) JavaScript implementation

2015-11-04 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990525#comment-14990525 ] Ryan Blue edited comment on AVRO-1747 at 11/4/15 10:01 PM: --- Matth

[jira] [Commented] (AVRO-1747) JavaScript implementation

2015-11-04 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990525#comment-14990525 ] Ryan Blue commented on AVRO-1747: - Matthieu, here are a few things I noticed: 1. The new f

[jira] [Updated] (AVRO-1754) C++ ValiditingDecoder handles null incorrectly

2015-11-04 Thread John McClean (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John McClean updated AVRO-1754: --- Attachment: AVRO-1754.patch > C++ ValiditingDecoder handles null incorrectly >

[jira] [Updated] (AVRO-1754) C++ ValiditingDecoder handles null incorrectly

2015-11-04 Thread John McClean (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John McClean updated AVRO-1754: --- Description: When decoding null, the ValidatingDecoder does not call the underlying 'decodeNull' metho

[jira] [Updated] (AVRO-1754) C++ ValiditingDecoder handles null incorrectly

2015-11-04 Thread John McClean (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John McClean updated AVRO-1754: --- Description: When decoding null, the ValidatingDecoder does not call the underlying 'decodeNull' metho

[jira] [Updated] (AVRO-1754) C++ ValiditingDecoder handles null incorrectly

2015-11-04 Thread John McClean (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John McClean updated AVRO-1754: --- Description: When decoding null, the ValidatingDecoder does not call the underlying 'decodeNull' metho

[jira] [Created] (AVRO-1754) C++ ValiditingDecoder handles null incorrectly

2015-11-04 Thread John McClean (JIRA)
John McClean created AVRO-1754: -- Summary: C++ ValiditingDecoder handles null incorrectly Key: AVRO-1754 URL: https://issues.apache.org/jira/browse/AVRO-1754 Project: Avro Issue Type: Bug

[jira] [Commented] (AVRO-1747) JavaScript implementation

2015-11-04 Thread Matthieu Monsch (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990071#comment-14990071 ] Matthieu Monsch commented on AVRO-1747: --- Thanks Ryan. I'm also adding a feature to le

[jira] [Commented] (AVRO-1747) JavaScript implementation

2015-11-04 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990037#comment-14990037 ] Ryan Blue commented on AVRO-1747: - Thanks Matthieu! I'll have a look at your patch today. S