Re: backporting a fix to avro 1.7

2016-10-04 Thread radai
Thanks, I've opened a PR to backport to 1.8 (https://github.com/apache/avro/pull/140 - has everything that landed originally except additions to CHANGES.txt) For 1.7, I had to 1st bring the branch to compile (PR here - https://github.com/apache/avro/pull/139) and will backport in a subsequent PR.

[jira] [Commented] (AVRO-1901) creating a record called "Exception" leads to generated code not compiling

2016-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546946#comment-15546946 ] ASF GitHub Bot commented on AVRO-1901: -- GitHub user radai-rosenblatt opened a pull req

[GitHub] avro pull request #140: AVRO-1901: Record named Exception generated bad code

2016-10-04 Thread radai-rosenblatt
GitHub user radai-rosenblatt opened a pull request: https://github.com/apache/avro/pull/140 AVRO-1901: Record named Exception generated bad code NOTE - I did not update CHANGES.txt You can merge this pull request into a Git repository by running: $ git pull https://github.com/r

[jira] [Commented] (AVRO-1681) Improve generated JavaDocs

2016-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546893#comment-15546893 ] ASF GitHub Bot commented on AVRO-1681: -- GitHub user radai-rosenblatt opened a pull req

[GitHub] avro pull request #139: Make 1.7 branch build

2016-10-04 Thread radai-rosenblatt
GitHub user radai-rosenblatt opened a pull request: https://github.com/apache/avro/pull/139 Make 1.7 branch build Seems like AVRO-1681 was only partially applied to the 1.7 branch. Specifically, the expected test output was not updated to reflect changes in javadoc. This commit

[jira] [Commented] (AVRO-1923) Recursive record causes StackOverflow in GenericData.toString

2016-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545527#comment-15545527 ] ASF GitHub Bot commented on AVRO-1923: -- Github user nielsbasjes closed the pull reques

[GitHub] avro pull request #128: AVRO-1923: Stop infinite recursion in GenericData.to...

2016-10-04 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Updated] (AVRO-1923) Recursive record causes StackOverflow in GenericData.toString

2016-10-04 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-1923: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Recursive record causes StackOverf

[jira] [Commented] (AVRO-1923) Recursive record causes StackOverflow in GenericData.toString

2016-10-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545480#comment-15545480 ] ASF subversion and git services commented on AVRO-1923: --- Commit e276a

[jira] [Commented] (AVRO-1923) Recursive record causes StackOverflow in GenericData.toString

2016-10-04 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545481#comment-15545481 ] Niels Basjes commented on AVRO-1923: Committed. > Recursive record causes StackOverflo

[jira] [Updated] (AVRO-1929) SchemaCompatibility fails to recognize string<->bytes promotion

2016-10-04 Thread Anders Sundelin (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anders Sundelin updated AVRO-1929: -- Status: Patch Available (was: Open) This time, added the patch as a attached file HTH /Anders >

[jira] [Updated] (AVRO-1929) SchemaCompatibility fails to recognize string<->bytes promotion

2016-10-04 Thread Anders Sundelin (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anders Sundelin updated AVRO-1929: -- Attachment: AVRO-1929.patch Patch for AVRO-1929 issue > SchemaCompatibility fails to recognize s

[jira] [Updated] (AVRO-1929) SchemaCompatibility fails to recognize string<->bytes promotion

2016-10-04 Thread Anders Sundelin (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anders Sundelin updated AVRO-1929: -- Status: Open (was: Patch Available) > SchemaCompatibility fails to recognize string<->bytes prom

[jira] [Commented] (AVRO-1929) SchemaCompatibility fails to recognize string<->bytes promotion

2016-10-04 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545441#comment-15545441 ] Gabor Szadovszky commented on AVRO-1929: Thanks for the patch, [~epkanol]. Could yo

[jira] [Updated] (AVRO-1929) SchemaCompatibility fails to recognize string<->bytes promotion

2016-10-04 Thread Anders Sundelin (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anders Sundelin updated AVRO-1929: -- Status: Patch Available (was: Open) diff --git a/lang/java/avro/src/main/java/org/apache/avro/S

[jira] [Commented] (AVRO-1918) Improve logical type documentation

2016-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545421#comment-15545421 ] ASF GitHub Bot commented on AVRO-1918: -- Github user gszadovszky closed the pull reques

[GitHub] avro pull request #129: AVRO-1918 - Improve logical type documentation

2016-10-04 Thread gszadovszky
Github user gszadovszky closed the pull request at: https://github.com/apache/avro/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Created] (AVRO-1929) SchemaCompatibility fails to recognize string<->bytes promotion

2016-10-04 Thread Anders Sundelin (JIRA)
Anders Sundelin created AVRO-1929: - Summary: SchemaCompatibility fails to recognize string<->bytes promotion Key: AVRO-1929 URL: https://issues.apache.org/jira/browse/AVRO-1929 Project: Avro

Re: backporting a fix to avro 1.7

2016-10-04 Thread Sean Busbey
(For others, the jira under discussion is AVRO-1901 https://issues.apache.org/jira/browse/AVRO-1901) On Tue, Oct 4, 2016 at 8:28 AM, Sean Busbey wrote: > yes, it looks like the jira landed in 1.9, though there isn't a fix > version set. I don't see anything in the patch that would prevent a > bac

Re: backporting a fix to avro 1.7

2016-10-04 Thread Sean Busbey
yes, it looks like the jira landed in 1.9, though there isn't a fix version set. I don't see anything in the patch that would prevent a backport to 1.7. On Mon, Oct 3, 2016 at 2:28 PM, radai wrote: > Hi, > > I've recently encountered a bug in avro code generation, for which I > submitted a fix (

[jira] [Commented] (AVRO-1605) Remove Jackson classes from public API

2016-10-04 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544956#comment-15544956 ] Tom White commented on AVRO-1605: - I'm not sure how long the accessors would need to be the

[jira] [Commented] (AVRO-1861) Avro Schema parser treats Avro float type as Java Double for default values

2016-10-04 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544838#comment-15544838 ] Gabor Szadovszky commented on AVRO-1861: One fix for both. > Avro Schema parser tr

[jira] [Commented] (AVRO-1605) Remove Jackson classes from public API

2016-10-04 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544756#comment-15544756 ] Gabor Szadovszky commented on AVRO-1605: My understanding about this issue was to n

[jira] [Commented] (AVRO-1861) Avro Schema parser treats Avro float type as Java Double for default values

2016-10-04 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544668#comment-15544668 ] Gabor Szadovszky commented on AVRO-1861: You are absolutely right. I just wanted to