[jira] [Comment Edited] (AVRO-2244) Problems with TestSpecificLogicalTypes.testAbilityToReadJsr310RecordWrittenAsJodaRecord:148

2018-10-23 Thread Raymie Stata (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661817#comment-16661817 ] Raymie Stata edited comment on AVRO-2244 at 10/24/18 6:56 AM: --

[jira] [Comment Edited] (AVRO-2244) Problems with TestSpecificLogicalTypes.testAbilityToReadJsr310RecordWrittenAsJodaRecord:148

2018-10-23 Thread Raymie Stata (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661817#comment-16661817 ] Raymie Stata edited comment on AVRO-2244 at 10/24/18 6:51 AM: --

[jira] [Commented] (AVRO-2244) Problems with TestSpecificLogicalTypes.testAbilityToReadJsr310RecordWrittenAsJodaRecord:148

2018-10-23 Thread Raymie Stata (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661817#comment-16661817 ] Raymie Stata commented on AVRO-2244: If there's any doubt about this issue being resol

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661798#comment-16661798 ] ASF GitHub Bot commented on AVRO-2090: -- Fokko commented on issue #350: AVRO-2090 seco

Resolving Enumerations -- bug?

2018-10-23 Thread Raymie Stata
While working on AVRO-2090, I noticed what is either an implementation bug or a specification bug in schema resolution for enumerations. The relevant code is here: https://bit.ly/2q5tsIp. This code uses the reader's default symbol, if it exists, in the case where the writer's symbols is missing.

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661468#comment-16661468 ] ASF GitHub Bot commented on AVRO-2090: -- cutting commented on issue #350: AVRO-2090 se

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661364#comment-16661364 ] ASF GitHub Bot commented on AVRO-2090: -- rstata commented on issue #350: AVRO-2090 sec

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661328#comment-16661328 ] ASF GitHub Bot commented on AVRO-2090: -- Fokko commented on issue #350: AVRO-2090 seco

Re: Merge strategy

2018-10-23 Thread Michael A. Smith
I’m generally in favor of linear commits iff the committers can be trusted to follow good git hygiene in general, like with small, proprietary projects with strong leadership. With Avro, with its variegated multilang repo and commits coming from the community at large, I’m not sure if linear-rebas

Merge strategy

2018-10-23 Thread Driesprong, Fokko
Hi all, Allow me to start the great debate. [image: image.png] I would like to get the Avro's dev-community's opinion on the merge strategy of pull requests. By default Github supports three options: - Create a merge commit - Squash and merge - Rebase and merge https://help.github.com/articles/a

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661287#comment-16661287 ] ASF GitHub Bot commented on AVRO-2090: -- rstata commented on issue #350: AVRO-2090 sec

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661274#comment-16661274 ] ASF GitHub Bot commented on AVRO-2090: -- Fokko commented on issue #350: AVRO-2090 seco

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661131#comment-16661131 ] ASF GitHub Bot commented on AVRO-2090: -- Fokko commented on issue #350: AVRO-2090 seco

[jira] [Commented] (AVRO-2235) Regenerate TestRecordWithLogicalTypes

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661129#comment-16661129 ] ASF GitHub Bot commented on AVRO-2235: -- rstata closed pull request #342: AVRO-2235: r

[jira] [Commented] (AVRO-2244) Problems with TestSpecificLogicalTypes.testAbilityToReadJsr310RecordWrittenAsJodaRecord:148

2018-10-23 Thread Raymie Stata (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661123#comment-16661123 ] Raymie Stata commented on AVRO-2244: I don't believe the fix for AVRO-2241 addresses t

[jira] [Resolved] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting resolved AVRO-2090. Resolution: Fixed Fix Version/s: 1.9.0 I committed this. Thanks, Raymie! > Improve encode/de

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661059#comment-16661059 ] ASF subversion and git services commented on AVRO-2090: --- Commit b4ed

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661060#comment-16661060 ] ASF subversion and git services commented on AVRO-2090: --- Commit b4ed

[jira] [Commented] (AVRO-2090) Improve encode/decode time for SpecificRecord using code generation

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661058#comment-16661058 ] ASF GitHub Bot commented on AVRO-2090: -- cutting closed pull request #350: AVRO-2090 s

[jira] [Commented] (AVRO-2241) Fix Jsr310/Joda tests when comparing datetimes

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660790#comment-16660790 ] ASF GitHub Bot commented on AVRO-2241: -- Fokko closed pull request #346: AVRO-2241. Fi

[jira] [Commented] (AVRO-2241) Fix Jsr310/Joda tests when comparing datetimes

2018-10-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660791#comment-16660791 ] ASF subversion and git services commented on AVRO-2241: --- Commit d695

[jira] [Commented] (AVRO-2241) Fix Jsr310/Joda tests when comparing datetimes

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660789#comment-16660789 ] ASF GitHub Bot commented on AVRO-2241: -- Fokko edited a comment on issue #346: AVRO-22

[jira] [Commented] (AVRO-2241) Fix Jsr310/Joda tests when comparing datetimes

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660776#comment-16660776 ] ASF GitHub Bot commented on AVRO-2241: -- Fokko commented on issue #346: AVRO-2241. Fix

[jira] [Resolved] (AVRO-2246) Enable Travis-CI for Apache Avro

2018-10-23 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2246. Resolution: Won't Fix > Enable Travis-CI for Apache Avro >

[jira] [Commented] (AVRO-1256) C++ API compileJsonSchema ignores "doc" and custom attributes on a field/record

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660596#comment-16660596 ] ASF GitHub Bot commented on AVRO-1256: -- thiru-apache commented on a change in pull re