If all we want is the diff/exit code, then we should use pycodestyle
instead of black. I'll change course to work on that.
On Tue, May 28, 2019 at 5:24 AM Driesprong, Fokko
wrote:
> Fully agree with you Ismaël.
>
>
> The issue is that it CAN write directly. For example here:
>
[
https://issues.apache.org/jira/browse/AVRO-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849928#comment-16849928
]
Jacob Tolar commented on AVRO-2400:
---
{quote}Yes, good catch, lines 97 and 98 of SchemaCompatibility also
Fully agree with you Ismaël.
The issue is that it CAN write directly. For example here:
https://github.com/Fokko/avro/pull/35 If you ask dependabot to merge it, it
will be merged into master. And therefore it will ask for write access to
the repository. Recently dependabot has been acquired
[
https://issues.apache.org/jira/browse/AVRO-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849486#comment-16849486
]
Hudson commented on AVRO-2408:
--
SUCCESS: Integrated in Jenkins build AvroJava #668 (See
+1 for Black, great idea and in line we the changes we did with
spotless for the Java code base.
About dependabot I think this is an interesting case to discuss in
upstream apache lists. So far ASF allows bots that do not touch the
code, for example for metadata, as we do with the autolabeler
Thanks, Michael for working on this. I think having an auto formatter for
Python is valuable since it will decrease the conflicts in the future. For
now, we need to do a big PR to get all the files in the correct format.
We need to add to the CI: black --check --diff . This will throw a non-zero
[
https://issues.apache.org/jira/browse/AVRO-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849438#comment-16849438
]
ASF subversion and git services commented on AVRO-2408:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved AVRO-2408.
Resolution: Fixed
Fix Version/s: 1.10.0
> Make Forrest work again in the Docker
