[GitHub] [avro] anhldbk commented on pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
anhldbk commented on pull request #847: URL: https://github.com/apache/avro/pull/847#issuecomment-623230961 @Fokko I've got troubles with my Python formatter. Gonna resolve it and tell you later This is an automated message

[GitHub] [avro] rayokota commented on pull request #869: AVRO-2822: Add toString that doesn't inline referenced schemas

2020-05-03 Thread GitBox
rayokota commented on pull request #869: URL: https://github.com/apache/avro/pull/869#issuecomment-623190520 @RyanSkraba , is it ok if we add this `toString` method to 1.10.0, and someone can look whether a more general Formatter should be added later, as you suggested? Thanks!

Re: Proposal: RFCs for Avro 2.x

2020-05-03 Thread Ryan Blue
It sounds like there is consensus around separating the languages into separate releases and possibly projects. Should we consider a separate discuss & vote thread for that alone? I don't think there's a need for an improvement proposal there. On Sun, May 3, 2020 at 7:47 AM Andy Le wrote: > +1

[GitHub] [avro] Fokko removed a comment on pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
Fokko removed a comment on pull request #847: URL: https://github.com/apache/avro/pull/847#issuecomment-623124136 @anhldbk I see a lot of unrelated changes in `lang/py/avro/io.py`, could you check? We like to minimize the changes, to avoid unrelated changes in version control.

[GitHub] [avro] Fokko commented on pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
Fokko commented on pull request #847: URL: https://github.com/apache/avro/pull/847#issuecomment-623124136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: Proposal: RFCs for Avro 2.x

2020-05-03 Thread Andy Le
+1 the project structure and more documentation. I'm really impressed with the way Vertx documentation organized. Finally, so what should we do? IMHO, we should: - Clear about the organization - Brainstorming what to do in a plan - Publicly show the plan & call for contributions I'm a newcomer

[GitHub] [avro] anhldbk commented on pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
anhldbk commented on pull request #847: URL: https://github.com/apache/avro/pull/847#issuecomment-623084441 @Fokko PTAL :) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [avro] Fokko commented on pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
Fokko commented on pull request #847: URL: https://github.com/apache/avro/pull/847#issuecomment-623079453 I can't merge the PR, there is a merge conflict in `lang/py/avro/io.py`. You should pull the latest master into your branch, and resolve the conflicts.

[GitHub] [avro] anhldbk commented on a change in pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
anhldbk commented on a change in pull request #847: URL: https://github.com/apache/avro/pull/847#discussion_r419070072 ## File path: doc/src/content/xdocs/spec.xml ## @@ -546,7 +546,7 @@ Unions -A union is encoded by first writing a long

[GitHub] [avro] anhldbk commented on pull request #847: Avro-2785: Update specs on how unions encoded

2020-05-03 Thread GitBox
anhldbk commented on pull request #847: URL: https://github.com/apache/avro/pull/847#issuecomment-623075626 @Fokko What should I do? I agree with [Roger's comment](https://lists.apache.org/thread.html/rac728c7e4fd8052778e560b997e473745453eec3c3a1826b3cc3607c%40%3Cuser.avro.apache.org%3E)

[jira] [Commented] (AVRO-2819) Add BigInteger and BigDecimal support for JacksonUtils

2020-05-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098283#comment-17098283 ] Hudson commented on AVRO-2819: -- SUCCESS: Integrated in Jenkins build AvroJava #855 (See

[jira] [Commented] (AVRO-2535) Ruby support for enum defaults

2020-05-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098284#comment-17098284 ] Hudson commented on AVRO-2535: -- SUCCESS: Integrated in Jenkins build AvroJava #855 (See

[GitHub] [avro] Fokko commented on a change in pull request #870: AVRO-2815: Remove the ant stuff

2020-05-03 Thread GitBox
Fokko commented on a change in pull request #870: URL: https://github.com/apache/avro/pull/870#discussion_r419063895 ## File path: doc/src/content/xdocs/gettingstartedpython.xml ## @@ -73,9 +80,8 @@ $ python $ cd lang/py/ -$ python setup.py install +$ pip

Re: When and how should we remove lang/py3?

2020-05-03 Thread Driesprong, Fokko
Hi Mchael, Thank you for bringing this up. I agree, but I'm not sure how we're going to migrate the users to the avro package. Rijprojectnum_downloads 1 avro 885838 2 avro-python3 147313 A quick query on bigquery, that contains all the pypi downloads shows that the python3 package is more

[GitHub] [avro] Fokko commented on pull request #628: AVRO-2535: Add Ruby support for enum defaults

2020-05-03 Thread GitBox
Fokko commented on pull request #628: URL: https://github.com/apache/avro/pull/628#issuecomment-623068611 I'm merging this @tjwp. The Windows servers of Travis are unstable, so we're ignoring that for now. This is an

[jira] [Updated] (AVRO-2535) Ruby support for enum defaults

2020-05-03 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong updated AVRO-2535: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Ruby support for enum

[jira] [Commented] (AVRO-2535) Ruby support for enum defaults

2020-05-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098275#comment-17098275 ] ASF subversion and git services commented on AVRO-2535: --- Commit

Re: Proposal: RFCs for Avro 2.x

2020-05-03 Thread Driesprong, Fokko
Yes, I'd love to see the AEPs being revived. This would enable it to make more structural/fundamental changes, such as the one mentioned above. This also enables others to have a complete overview of changes and the impact. I also agree with Michael when it comes to the project structure. Maybe

[GitHub] [avro] Fokko commented on pull request #726: AVRO-2639: add option to write Optional only when fields are nullable

2020-05-03 Thread GitBox
Fokko commented on pull request #726: URL: https://github.com/apache/avro/pull/726#issuecomment-623067648 Thanks for the PR, I like this one. Would be much nicer if we could use the primitive types, as @kan-izh suggests.

[GitHub] [avro] Fokko commented on pull request #864: [AVRO-2278] getter semantics confusing.

2020-05-03 Thread GitBox
Fokko commented on pull request #864: URL: https://github.com/apache/avro/pull/864#issuecomment-623067269 @zolyfarkas I'm still not sure about breaking the backward compatibility. WDYT @iemejia ? This is an automated

[jira] [Commented] (AVRO-2819) Add BigInteger and BigDecimal support for JacksonUtils

2020-05-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098271#comment-17098271 ] ASF subversion and git services commented on AVRO-2819: --- Commit

[jira] [Resolved] (AVRO-2819) Add BigInteger and BigDecimal support for JacksonUtils

2020-05-03 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2819. Fix Version/s: 1.10.0 Resolution: Fixed > Add BigInteger and BigDecimal support for

[GitHub] [avro] Fokko commented on pull request #859: AVRO-2819:Add BigInteger and BigDecimal support for JacksonUtils

2020-05-03 Thread GitBox
Fokko commented on pull request #859: URL: https://github.com/apache/avro/pull/859#issuecomment-623066770 Thanks @zeshuai007 This is an automated message from the Apache Git Service. To respond to the message, please log on

Community governance

2020-05-03 Thread Andy Le
Hi guys, I'm starting this thread to discuss about my issue about our community: > Recently I've seen so many Jira issues and Github PRs having no proper > responses from committers. I think responsive answers from members will create a better Avro community. How can we resolve the issue?

[GitHub] [avro] anhldbk commented on pull request #790: AVRO-2068: Improved static class constructor performance

2020-05-03 Thread GitBox
anhldbk commented on pull request #790: URL: https://github.com/apache/avro/pull/790#issuecomment-623065212 Well, I think this change is nice-to-have. IMHO, it's not critical to improve performance. This is an automated