[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873453#comment-13873453
]
Tie Liu commented on AVRO-1428:
---
In following example, let's say we have unionSchema like
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873831#comment-13873831
]
Tie Liu commented on AVRO-1428:
---
yes, a given call to RecordSchema#computeHash keeps track of
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tie Liu updated AVRO-1428:
--
Attachment: TestAvro.java
This is code my colleague to test the hash code generation.
Schema.computeHash() to
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872656#comment-13872656
]
Tie Liu commented on AVRO-1428:
---
Our code doesn't compute hashcode directly, but our schema
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872676#comment-13872676
]
Tie Liu commented on AVRO-1428:
---
To explain the problem more clearly, in current
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872703#comment-13872703
]
Tie Liu commented on AVRO-1428:
---
it's half right that I suggest cache the field hashCode. In
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872716#comment-13872716
]
Tie Liu commented on AVRO-1428:
---
also for the UnionSchema, it's calculating the hashcode for
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866842#comment-13866842
]
Tie Liu commented on AVRO-1428:
---
new patch file attached, it's generated using svn diff. The
Tie Liu created AVRO-1428:
-
Summary: Schema.computeHash() to add if check to avoid unnecessary
hashcode computation
Key: AVRO-1428
URL: https://issues.apache.org/jira/browse/AVRO-1428
Project: Avro
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tie Liu updated AVRO-1428:
--
Attachment: AVRO-1428.patch
This patch is to be applied on Schema.java under org.apache.avro package.
[
https://issues.apache.org/jira/browse/AVRO-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849206#comment-13849206
]
Tie Liu commented on AVRO-1348:
---
Another note about this is, change to use string literal
[
https://issues.apache.org/jira/browse/AVRO-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849746#comment-13849746
]
Tie Liu commented on AVRO-1348:
---
Just run the Perf test in our environment, which is 64 bit
Tie Liu created AVRO-1411:
-
Summary: org.apache.avro.util.Utf8 performance improvement by
remove private Charset in class
Key: AVRO-1411
URL: https://issues.apache.org/jira/browse/AVRO-1411
Project: Avro
[
https://issues.apache.org/jira/browse/AVRO-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846578#comment-13846578
]
Tie Liu commented on AVRO-1411:
---
I checked the patch, the patch v2
[
https://issues.apache.org/jira/browse/AVRO-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tie Liu resolved AVRO-1411.
---
Resolution: Duplicate
duplicate as jira https://issues.apache.org/jira/browse/AVRO-1348
[
https://issues.apache.org/jira/browse/AVRO-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846597#comment-13846597
]
Tie Liu commented on AVRO-1348:
---
I tested it under java 6, will be out of office tomorrow,
16 matches
Mail list logo
