[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873453#comment-13873453
]
Tie Liu commented on AVRO-1428:
---
In following example, let's say we have unionSchema like
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873786#comment-13873786
]
Doug Cutting commented on AVRO-1428:
A given call to RecordSchema#computeHash() keeps
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873831#comment-13873831
]
Tie Liu commented on AVRO-1428:
---
yes, a given call to RecordSchema#computeHash keeps track of
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872629#comment-13872629
]
Doug Cutting commented on AVRO-1428:
Do you have an application that is computing
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872656#comment-13872656
]
Tie Liu commented on AVRO-1428:
---
Our code doesn't compute hashcode directly, but our schema
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872676#comment-13872676
]
Tie Liu commented on AVRO-1428:
---
To explain the problem more clearly, in current
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872685#comment-13872685
]
Doug Cutting commented on AVRO-1428:
But schema caches the hashcode. Each schema
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872689#comment-13872689
]
Doug Cutting commented on AVRO-1428:
It seems you're arguing that Field should cache
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872703#comment-13872703
]
Tie Liu commented on AVRO-1428:
---
it's half right that I suggest cache the field hashCode. In
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872716#comment-13872716
]
Tie Liu commented on AVRO-1428:
---
also for the UnionSchema, it's calculating the hashcode for
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872807#comment-13872807
]
Doug Cutting commented on AVRO-1428:
The current design is:
- hashCode() re-computes
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866842#comment-13866842
]
Tie Liu commented on AVRO-1428:
---
new patch file attached, it's generated using svn diff. The
[
https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863703#comment-13863703
]
Doug Cutting commented on AVRO-1428:
Your patch does not apply cleanly. Can you please
13 matches
Mail list logo