[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-16 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873453#comment-13873453 ] Tie Liu commented on AVRO-1428: --- In following example, let's say we have unionSchema like

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-16 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873786#comment-13873786 ] Doug Cutting commented on AVRO-1428: A given call to RecordSchema#computeHash() keeps

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-16 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873831#comment-13873831 ] Tie Liu commented on AVRO-1428: --- yes, a given call to RecordSchema#computeHash keeps track of

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872629#comment-13872629 ] Doug Cutting commented on AVRO-1428: Do you have an application that is computing

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872656#comment-13872656 ] Tie Liu commented on AVRO-1428: --- Our code doesn't compute hashcode directly, but our schema

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872676#comment-13872676 ] Tie Liu commented on AVRO-1428: --- To explain the problem more clearly, in current

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872685#comment-13872685 ] Doug Cutting commented on AVRO-1428: But schema caches the hashcode. Each schema

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872689#comment-13872689 ] Doug Cutting commented on AVRO-1428: It seems you're arguing that Field should cache

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872703#comment-13872703 ] Tie Liu commented on AVRO-1428: --- it's half right that I suggest cache the field hashCode. In

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872716#comment-13872716 ] Tie Liu commented on AVRO-1428: --- also for the UnionSchema, it's calculating the hashcode for

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-15 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872807#comment-13872807 ] Doug Cutting commented on AVRO-1428: The current design is: - hashCode() re-computes

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-09 Thread Tie Liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866842#comment-13866842 ] Tie Liu commented on AVRO-1428: --- new patch file attached, it's generated using svn diff. The

[jira] [Commented] (AVRO-1428) Schema.computeHash() to add if check to avoid unnecessary hashcode computation

2014-01-06 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863703#comment-13863703 ] Doug Cutting commented on AVRO-1428: Your patch does not apply cleanly. Can you please