[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049985#comment-15049985
]
ASF GitHub Bot commented on AVRO-1747:
--
Github user mtth closed the pull request at:
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038534#comment-15038534
]
Matthieu Monsch commented on AVRO-1747:
---
Also: the version used here is 1.0.0. Do you have a
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038434#comment-15038434
]
Ryan Blue commented on AVRO-1747:
-
Yes, I ran it and found the file was missing. I think it is probably
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038435#comment-15038435
]
Ryan Blue commented on AVRO-1747:
-
Also: the version used here is 1.0.0. Do you have a problem with this
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038419#comment-15038419
]
Matthieu Monsch commented on AVRO-1747:
---
Thanks for the update Ryan!
If you don't mind, I'd like to
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038387#comment-15038387
]
Ryan Blue commented on AVRO-1747:
-
I was able to get the tests to pass using the [node 4.x install
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038583#comment-15038583
]
Ryan Blue commented on AVRO-1747:
-
I'd like to finish this import as-is and then we can get the other in
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038674#comment-15038674
]
Ryan Blue commented on AVRO-1747:
-
I committed this. Thanks for contributing it, [~mtth]!
As far as next
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038726#comment-15038726
]
Ryan Blue commented on AVRO-1747:
-
Glad to hear you plan to continue working on it! I'd really like to
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038715#comment-15038715
]
Matthieu Monsch commented on AVRO-1747:
---
Thanks for all your help [~rdblue]! Hopefully this will
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038745#comment-15038745
]
Hudson commented on AVRO-1747:
--
SUCCESS: Integrated in AvroJava #556 (See
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038637#comment-15038637
]
ASF subversion and git services commented on AVRO-1747:
---
Commit 1717850 from
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039504#comment-15039504
]
Matthieu Monsch commented on AVRO-1747:
---
[~rdblue] - Just created a new issue with the changes here:
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026122#comment-15026122
]
Matthieu Monsch commented on AVRO-1747:
---
Sounds good, will do.
> JavaScript implementation
>
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026289#comment-15026289
]
ASF GitHub Bot commented on AVRO-1747:
--
GitHub user mtth opened a pull request:
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025158#comment-15025158
]
Ryan Blue commented on AVRO-1747:
-
Thanks [~mtth]! I think this looks good. Could you open this as a pull
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998869#comment-14998869
]
Matthieu Monsch commented on AVRO-1747:
---
ALSv2 seems fine. It would've been easier to keep the same
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998909#comment-14998909
]
Ryan Blue commented on AVRO-1747:
-
Thanks!
Unfortunately, we can't use the MD5 implementation unless we
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998925#comment-14998925
]
Ryan Blue commented on AVRO-1747:
-
Two licensing things I found while looking at the patch. First, we like
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999029#comment-14999029
]
Matthieu Monsch commented on AVRO-1747:
---
Oh nice, I didn't know about these defined annotations (are
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997852#comment-14997852
]
Ryan Blue commented on AVRO-1747:
-
Apache projects can redistribute third-party works using licenses that
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996039#comment-14996039
]
Matthieu Monsch commented on AVRO-1747:
---
+ Thank you for the pointers. I emailed the author of the
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991990#comment-14991990
]
Ryan Blue commented on AVRO-1747:
-
I recently asked for a [clarification on the license of Doxygen
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991210#comment-14991210
]
Matthieu Monsch commented on AVRO-1747:
---
Thanks for the feedback!
1. Will do.
2. Sure, I can do
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990037#comment-14990037
]
Ryan Blue commented on AVRO-1747:
-
Thanks Matthieu! I'll have a look at your patch today. Since there's not
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984687#comment-14984687
]
Matthieu Monsch commented on AVRO-1747:
---
Just uploaded a tentative patch. If you'd like to browse the
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983639#comment-14983639
]
Matthieu Monsch commented on AVRO-1747:
---
Sounds good. We should definitely be able to shim the
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978951#comment-14978951
]
Ryan Blue commented on AVRO-1747:
-
I think this should be the lang/js implementation. There is already a
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975565#comment-14975565
]
Matthieu Monsch commented on AVRO-1747:
---
Thanks! I'll wrap up a few changes in the pipeline and start
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969513#comment-14969513
]
Ryan Blue commented on AVRO-1747:
-
I don't think there would be a need for two distributions, assuming that
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969258#comment-14969258
]
Matthieu Monsch commented on AVRO-1747:
---
Thanks for the information. Could you tell me a bit more how
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968051#comment-14968051
]
Ryan Blue commented on AVRO-1747:
-
Thanks Sean!
Also, I took a quick look at the existing JS
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965168#comment-14965168
]
Matthieu Monsch commented on AVRO-1747:
---
Definitely. What do I need to do?
> JavaScript
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965260#comment-14965260
]
Sean Busbey commented on AVRO-1747:
---
You'll need to get things into a pull request (or patch) within the
[
https://issues.apache.org/jira/browse/AVRO-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963950#comment-14963950
]
Ryan Blue commented on AVRO-1747:
-
[~mtth], this is great! Thanks for taking the time to post it here as
35 matches
Mail list logo
