Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...

2016-03-06 Thread Ryan Blue
Hi Zoltan, I just posted a review. I'd like you to take a look at some changes to the patch I made, but overall the diagnosis and approach you took is sound. Thanks for the fix! rb On Tue, Mar 1, 2016 at 9:53 AM, Zoltan Farkas wrote: > Can somebody look at this

Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...

2016-03-01 Thread Zoltan Farkas
Can somebody look at this patch? thank you —Z > On Feb 18, 2016, at 11:04 PM, Zoltan Farkas > wrote: > > Hi Ryan, > > did you have a chance to look at the patch? > > thank you > > —Z > > >> On Feb 13, 2016, at 8:06 AM, Zoltan Farkas

Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...

2016-02-13 Thread Zoltan Farkas
Sure, will attach a path to AVRO-1667. —Z > On Feb 12, 2016, at 7:40 PM, Ryan Blue wrote: > > Hi Zoltan, > > I remember taking a look at this a couple months ago. I think we can get it > in, but it isn't in a state where we can review it very easily because it >

Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...

2016-02-13 Thread Zoltan Farkas
Done, you have now a patch attached to the JIRA + a reference to a feature branch. let me know if you need anything else thank you —Z > On Feb 13, 2016, at 7:32 AM, Zoltan Farkas > wrote: > > Sure, will attach a path to AVRO-1667. > > > —Z > > >> On Feb

AVRO-1723 - can we implement this? patch is available, feature branch is available...

2016-02-12 Thread Zoltan Farkas
let me know thank you —Z

Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...

2016-02-12 Thread Ryan Blue
Hi Zoltan, I remember taking a look at this a couple months ago. I think we can get it in, but it isn't in a state where we can review it very easily because it mixes both AVRO-1667 and AVRO-1723 .