Re: Add support for nanosecond datetime types

2023-10-18 Thread Martin Grigorov
On Wed, Oct 18, 2023 at 10:28 AM Fokko Driesprong wrote: > Hey Martin, > > Thanks for the feedback, we got off the wrong foot here. > > Please don't treat me differently than anyone else, but please don't close > any PRs without giving an explanation, that doesn't look nice on the > I would not

Re: Add support for nanosecond datetime types

2023-10-18 Thread Fokko Driesprong
Hey Martin, Thanks for the feedback, we got off the wrong foot here. Please don't treat me differently than anyone else, but please don't close any PRs without giving an explanation, that doesn't look nice on the community. I agree that I jumped the gun a bit on the spec change, but it seemed to

Re: Add support for nanosecond datetime types

2023-10-17 Thread Martin Grigorov
Hi Fokko, Whenever I see an empty ticket and/or Github description (like https://issues.apache.org/jira/browse/AVRO-3884, https://github.com/apache/avro/pull/2554) the first thing that comes to my mind is to close it without giving an explanation too! If the reporter does not bother to help

Add support for nanosecond datetime types

2023-10-16 Thread Fokko Driesprong
Hi everyone, I just created a PR to add support for: - timestamp-nanos - local-timestamp-nanos Let me know what you think: https://github.com/apache/avro/pull/2554 Looking forward to your input! Kind regards, Fokko