[jira] [Updated] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning
[
https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
peter liu updated AVRO-1700:
Description:
saw below warning while compiling with g++ 4.2.1 on mac os 10.10.3
{quote}
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:19:9: warning:
'avro_BufferStreambuf_hh__' is used as a header guard here, followed by #define
of a different macro -Wheader-guard
#ifndef avro_BufferStreambuf_hh__
^
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:20:9: note:
'avro_BufferStreambuf_HH__' is defined here; did you mean
'avro_BufferStreambuf_hh__'?
#define avro_BufferStreambuf_HH__
^
avro_BufferStreambuf_hh__
1 warning generated
{quote}
avro_BufferStreambuf_hh__ header guard warning
---
Key: AVRO-1700
URL: https://issues.apache.org/jira/browse/AVRO-1700
Project: Avro
Issue Type: Bug
Components: c++
Affects Versions: 1.7.7
Reporter: peter liu
Priority: Minor
saw below warning while compiling with g++ 4.2.1 on mac os 10.10.3
{quote}
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:19:9:
warning: 'avro_BufferStreambuf_hh__' is used as a header guard here, followed
by #define
of a different macro -Wheader-guard
#ifndef avro_BufferStreambuf_hh__
^
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:20:9: note:
'avro_BufferStreambuf_HH__' is defined here; did you mean
'avro_BufferStreambuf_hh__'?
#define avro_BufferStreambuf_HH__
^
avro_BufferStreambuf_hh__
1 warning generated
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning
peter liu created AVRO-1700: --- Summary: avro_BufferStreambuf_hh__ header guard warning Key: AVRO-1700 URL: https://issues.apache.org/jira/browse/AVRO-1700 Project: Avro Issue Type: Bug Components: c++ Affects Versions: 1.7.7 Reporter: peter liu Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1702) Add LogicalType support to c++ library
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1702: Component/s: (was: java) c++ Add LogicalType support to c++ library -- Key: AVRO-1702 URL: https://issues.apache.org/jira/browse/AVRO-1702 Project: Avro Issue Type: New Feature Components: c++ Reporter: peter liu Assignee: Ryan Blue Fix For: 1.7.8 AVRO-1402 updates the Avro spec to include logical types, which are stored as existing types but interpreted as others. The next step is to implement LogicalType (in Java) that provides tools to attach a logical type to a schema, read a logical type, and validate logical types. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1702) Add LogicalType support to c++ library
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1702: Fix Version/s: (was: 1.7.8) Add LogicalType support to c++ library -- Key: AVRO-1702 URL: https://issues.apache.org/jira/browse/AVRO-1702 Project: Avro Issue Type: New Feature Components: c++ Reporter: peter liu Assignee: Ryan Blue I'd like to port the logicaltype support to c++ library -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1702) Add LogicalType support to c++ library
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1702: Description: I'd like to port the logicaltype support to c++ library (was: AVRO-1402 updates the Avro spec to include logical types, which are stored as existing types but interpreted as others. The next step is to implement LogicalType (in Java) that provides tools to attach a logical type to a schema, read a logical type, and validate logical types.) Add LogicalType support to c++ library -- Key: AVRO-1702 URL: https://issues.apache.org/jira/browse/AVRO-1702 Project: Avro Issue Type: New Feature Components: c++ Reporter: peter liu Assignee: Ryan Blue I'd like to port the logicaltype support to c++ library -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AVRO-1702) Add LogicalType support to c++ library
peter liu created AVRO-1702: --- Summary: Add LogicalType support to c++ library Key: AVRO-1702 URL: https://issues.apache.org/jira/browse/AVRO-1702 Project: Avro Issue Type: New Feature Components: java Reporter: peter liu Assignee: Ryan Blue Fix For: 1.7.8 AVRO-1402 updates the Avro spec to include logical types, which are stored as existing types but interpreted as others. The next step is to implement LogicalType (in Java) that provides tools to attach a logical type to a schema, read a logical type, and validate logical types. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] avro pull request: AVRO-1700 avro_BufferStreambuf_hh__ header guar...
GitHub user zhutoulala opened a pull request: https://github.com/apache/avro/pull/41 AVRO-1700 avro_BufferStreambuf_hh__ header guard warning You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhutoulala/avro trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/avro/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit c069f7997f17c4316f0593a49d8f7bc10d3d6d61 Author: LiuYanbo liuyanbo@liuyanbos-macbook.local Date: 2015-07-11T20:25:38Z AVRO-1700 avro_BufferStreambuf_hh__ header guard warning --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning
[
https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623563#comment-14623563
]
ASF GitHub Bot commented on AVRO-1700:
--
GitHub user zhutoulala opened a pull request:
https://github.com/apache/avro/pull/41
AVRO-1700 avro_BufferStreambuf_hh__ header guard warning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhutoulala/avro trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
commit c069f7997f17c4316f0593a49d8f7bc10d3d6d61
Author: LiuYanbo liuyanbo@liuyanbos-macbook.local
Date: 2015-07-11T20:25:38Z
AVRO-1700 avro_BufferStreambuf_hh__ header guard warning
avro_BufferStreambuf_hh__ header guard warning
---
Key: AVRO-1700
URL: https://issues.apache.org/jira/browse/AVRO-1700
Project: Avro
Issue Type: Bug
Components: c++
Affects Versions: 1.7.7
Reporter: peter liu
Priority: Minor
saw below warning while compiling with g++ 4.2.1 on mac os 10.10.3
{quote}
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:19:9:
warning: 'avro_BufferStreambuf_hh__' is used as a header guard here, followed
by #define
of a different macro -Wheader-guard
#ifndef avro_BufferStreambuf_hh__
^
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:20:9: note:
'avro_BufferStreambuf_HH__' is defined here; did you mean
'avro_BufferStreambuf_hh__'?
#define avro_BufferStreambuf_HH__
^
avro_BufferStreambuf_hh__
1 warning generated
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1692) Allow more than one logical type for a Java class
[ https://issues.apache.org/jira/browse/AVRO-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623615#comment-14623615 ] Ryan Blue commented on AVRO-1692: - [~tomwhite], I've updated the PR for Sean's review comments and added the test I made that demonstrates using logical types to implement circular references, AVRO-695. I didn't use the time types because they are not yet synced in github, but the circular reference test validates using multiple logical types with the same underlying Java class. I think this is ready to go now. Thanks! Allow more than one logical type for a Java class - Key: AVRO-1692 URL: https://issues.apache.org/jira/browse/AVRO-1692 Project: Avro Issue Type: Task Components: java Reporter: Ryan Blue Assignee: Ryan Blue Fix For: 1.8.0 Attachments: AVRO-1692.1.patch The initial logical types implementation assumed that there would only be one logical type per concrete class and kept a lookup table from class to conversion. There are cases where this assumption doesn't work. For example, both time-millis and time-micros can be represented by the same class, LocalTime, and the write path should use the correct logical type's conversion depending on the schema. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1692) Allow more than one logical type for a Java class
[ https://issues.apache.org/jira/browse/AVRO-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Blue updated AVRO-1692: Attachment: AVRO-1692.2.patch Allow more than one logical type for a Java class - Key: AVRO-1692 URL: https://issues.apache.org/jira/browse/AVRO-1692 Project: Avro Issue Type: Task Components: java Reporter: Ryan Blue Assignee: Ryan Blue Fix For: 1.8.0 Attachments: AVRO-1692.1.patch, AVRO-1692.2.patch The initial logical types implementation assumed that there would only be one logical type per concrete class and kept a lookup table from class to conversion. There are cases where this assumption doesn't work. For example, both time-millis and time-micros can be represented by the same class, LocalTime, and the write path should use the correct logical type's conversion depending on the schema. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'
peter liu created AVRO-1701:
---
Summary: warning: comparison between 'const enum
testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'
Key: AVRO-1701
URL: https://issues.apache.org/jira/browse/AVRO-1701
Project: Avro
Issue Type: Bug
Components: c++
Affects Versions: 1.7.7
Reporter: peter liu
Priority: Minor
saw below warning while compiling with g++ 4.2.1 on mac os 10.10.3
{quote}
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:19:9: warning:
'avro_BufferStreambuf_hh__' is used as a header guard here, followed by #define
of a different macro -Wheader-guard
#ifndef avro_BufferStreambuf_hh__
^
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:20:9: note:
'avro_BufferStreambuf_HH__' is defined here; did you mean
'avro_BufferStreambuf_hh__'?
#define avro_BufferStreambuf_HH__
^
avro_BufferStreambuf_hh__
1 warning generated
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'
[
https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
peter liu updated AVRO-1701:
Description:
saw below warning while compiling with g++ 4.2 and g++ 4.8 on mac os and linux
{quote}
[ 85%] Building CXX object
CMakeFiles/AvrogencppTests.dir/test/AvrogencppTests.cc.o
In file included from
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/impl/framework.ipp:29:0,
from
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/included/unit_test.hpp:20,
from
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/included/unit_test_framework.hpp:2,
from
/Users/liuyanbo/git/avro/lang/c++/test/AvrogencppTests.cc:33:
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp: In
instantiation of 'boost::test_tools::predicate_result
boost::test_tools::tt_detail::equal_impl(const Left, const Right) [with Left
= testgen_r::ExampleEnum; Right = testgen::ExampleEnum]':
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp:560:40:
required from 'boost::test_tools::predicate_result
boost::test_tools::tt_detail::equal_impl_frwd::call_impl(const Left, const
Right, mpl_::false_) const [with Left = testgen_r::ExampleEnum; Right =
testgen::ExampleEnum; mpl_::false_ = mpl_::bool_false]'
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp:575:56:
required from 'boost::test_tools::predicate_result
boost::test_tools::tt_detail::equal_impl_frwd::operator()(const Left, const
Right) const [with Left = testgen_r::ExampleEnum; Right =
testgen::ExampleEnum]'
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp:523:1:
required from 'bool boost::test_tools::tt_detail::check_frwd(Pred, const
boost::unit_test::lazy_ostream, boost::test_tools::const_string, std::size_t,
boost::test_tools::tt_detail::tool_level,
boost::test_tools::tt_detail::check_type, const Arg0, const char*, const
Arg1, const char*) [with Pred = boost::test_tools::tt_detail::equal_impl_frwd;
Arg0 = testgen_r::ExampleEnum; Arg1 = testgen::ExampleEnum;
boost::test_tools::const_string = boost::unit_test::basic_cstringconst char;
std::size_t = long unsigned int]'
/Users/liuyanbo/git/avro/lang/c++/test/AvrogencppTests.cc:124:5: required
from 'void checkRecord(const T1, const T2) [with T1 = testgen_r::RootRecord;
T2 = testgen::RootRecord]'
/Users/liuyanbo/git/avro/lang/c++/test/AvrogencppTests.cc:180:23: required
from here
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp:536:17:
warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum
testgen::ExampleEnum' [-Wenum-compare]
return left == right;
^
{quote}
was:
saw below warning while compiling with g++ 4.2.1 on mac os 10.10.3
{quote}
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:19:9: warning:
'avro_BufferStreambuf_hh__' is used as a header guard here, followed by #define
of a different macro -Wheader-guard
#ifndef avro_BufferStreambuf_hh__
^
/Users/liuyanbo/git/avro/lang/c++/api/buffer/BufferStreambuf.hh:20:9: note:
'avro_BufferStreambuf_HH__' is defined here; did you mean
'avro_BufferStreambuf_hh__'?
#define avro_BufferStreambuf_HH__
^
avro_BufferStreambuf_hh__
1 warning generated
{quote}
warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const
enum testgen::ExampleEnum'
-
Key: AVRO-1701
URL: https://issues.apache.org/jira/browse/AVRO-1701
Project: Avro
Issue Type: Bug
Components: c++
Affects Versions: 1.7.7
Reporter: peter liu
Priority: Minor
saw below warning while compiling with g++ 4.2 and g++ 4.8 on mac os and linux
{quote}
[ 85%] Building CXX object
CMakeFiles/AvrogencppTests.dir/test/AvrogencppTests.cc.o
In file included from
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/impl/framework.ipp:29:0,
from
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/included/unit_test.hpp:20,
from
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/included/unit_test_framework.hpp:2,
from
/Users/liuyanbo/git/avro/lang/c++/test/AvrogencppTests.cc:33:
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp: In
instantiation of 'boost::test_tools::predicate_result
boost::test_tools::tt_detail::equal_impl(const Left, const Right) [with
Left = testgen_r::ExampleEnum; Right = testgen::ExampleEnum]':
/Users/liuyanbo/Downloads/boost_1_56_0/boost/test/test_tools.hpp:560:40:
required from 'boost::test_tools::predicate_result
boost::test_tools::tt_detail::equal_impl_frwd::call_impl(const Left, const
Right, mpl_::false_) const [with Left =
