[RESULT] [VOTE] First stable release: release candidate #4

2017-05-15 Thread Davor Bonaci
I'm happy to announce that we have unanimously approved this release. There are 14 approving votes, 6 of which are binding: * Ahmet Altay * Davor Bonaci * Robert Bradshaw * Lukasz Cwik * María García Herrero * Thomas Groh * Dan Halperin * Pei He * Chamikara Jayalath * Aljoscha Krettek * Jason

Re: [VOTE] First stable release: release candidate #4

2017-05-15 Thread Davor Bonaci
Having passed 72 hours, this vote is now complete. I'll summarize the results and next steps in a separate thread. On Mon, May 15, 2017 at 8:58 PM, Dan Halperin wrote: > +1 > > In addition to the review for RC2/RC3 notes in the Acceptance Criteria doc, > I've

Re: [VOTE] First stable release: release candidate #4

2017-05-15 Thread Dan Halperin
+1 In addition to the review for RC2/RC3 notes in the Acceptance Criteria doc, I've manually verified that RC4 releases staged on dist.apache.org do not include binary artifacts :). Thanks everyone! On Mon, May 15, 2017 at 11:54 PM, Pei HE wrote: > +1 > > Given users can run

Re: [VOTE] First stable release: release candidate #4

2017-05-15 Thread Thomas Groh
+1 Since the last candidate, I've also run the game examples for a few hours on the DirectRunner and all's well. On Mon, May 15, 2017 at 9:16 AM, Lukasz Cwik wrote: > +1 (binding) > > Pei, I filed https://issues.apache.org/jira/browse/BEAM-2283 about using a >

Jenkins build is back to normal : beam_SeedJob #267

2017-05-15 Thread Apache Jenkins Server
See

Build failed in Jenkins: beam_SeedJob #266

2017-05-15 Thread Apache Jenkins Server
See -- GitHub pull request #3143 of commit 3adbd7b1c6fa78fee032112701e97d0c1eff2720, no merge conflicts. Setting status of 3adbd7b1c6fa78fee032112701e97d0c1eff2720 to PENDING with url

Re: Build failed in Jenkins: beam_SeedJob #264

2017-05-15 Thread Lukasz Cwik
I've been working on getting a Windows executor with https://github.com/apache/beam/pull/3143 So please ignore seed job failures today. On Mon, May 15, 2017 at 11:42 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Build failed in Jenkins: beam_SeedJob #264

2017-05-15 Thread Apache Jenkins Server
See -- GitHub pull request #3143 of commit daf58d12b02ad3b128242d6a0e255451fa5fd82a, no merge conflicts. Setting status of daf58d12b02ad3b128242d6a0e255451fa5fd82a to PENDING with url

Jenkins build is back to normal : beam_SeedJob #261

2017-05-15 Thread Apache Jenkins Server
See

Build failed in Jenkins: beam_SeedJob #260

2017-05-15 Thread Apache Jenkins Server
See -- GitHub pull request #3143 of commit 7552aa64b20934018b01e9b42f6355c40fbc79a0, no merge conflicts. Setting status of 7552aa64b20934018b01e9b42f6355c40fbc79a0 to PENDING with url

Re: Behavior of Top.Largest

2017-05-15 Thread Robert Bradshaw
On Sun, May 14, 2017 at 3:36 PM, Ben Chambers wrote: > Exposing the CombineFn is necessary for use with composed combine or > combining value state. There may be other reasons we made this visible, but > these continue to justify it. > These are the CompareFns, not

Re: [VOTE] First stable release: release candidate #4

2017-05-15 Thread Lukasz Cwik
+1 (binding) Pei, I filed https://issues.apache.org/jira/browse/BEAM-2283 about using a consistent strategy when dealing with URIs/string like paths in our APIs and related the bugs that you filed to it. On Mon, May 15, 2017 at 6:56 AM, Pei HE wrote: > Currently, several

Re: TextIO and .withWindowedWrites() - filenamepolicy

2017-05-15 Thread Borisa Zivkovic
Created PR https://github.com/apache/beam/pull/3142 On Fri, 12 May 2017 at 16:31 Reuven Lax wrote: > Can we simply fail WWW if windowed writes is not set? Or at least warn? > > On May 12, 2017 6:14 PM, "Dan Halperin" > wrote: > >