Re: Performance Testing - request for comments

2018-05-09 Thread Lukasz Cwik
+1 on only specifying the target that you need to build, You should use './gradlew -p path/to/java/project assemble' OR './gradlew :project-artifact-name:assemble' to build the jars that you should need. You can run these commands in a checked out version of your workspace and validate that they

Re: Merging our two SQL parser configs

2018-05-09 Thread Andrew Pilloud
Haven't heard anything, so I wrote up the change: https://github.com/apache/beam/pull/5325 Andrew On Mon, May 7, 2018 at 3:16 PM Andrew Pilloud wrote: > So we have two incompatible SQL parser configs in beam. One is in > BeamQueryPlanner >

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Andrew Pilloud
The seed job with the revert was run May 9, 2018 6:12:14 PM: https://builds.apache.org/job/beam_SeedJob/1657/ Your broken job was run before that. Andrew On Wed, May 9, 2018 at 1:11 PM Pablo Estrada wrote: > There is a problem that is still not fixed in Python: >

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Pablo Estrada
There is a problem that is still not fixed in Python: https://builds.apache.org/job/beam_PostCommit_Python_Verify/4909/console On Wed, May 9, 2018 at 12:07 PM Andrew Pilloud wrote: > Post commits are no longer failing on status pushes. Now that I know about > the seed job,

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Pablo Estrada
I was able to trigger a build again just now. On Wed, May 9, 2018 at 11:27 AM Andrew Pilloud wrote: > The manual launch button doesn't exist for me. I am not a committer, so I > don't have a login to Jenkins. > > On Wed, May 9, 2018 at 11:16 AM Lukasz Cwik

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Andrew Pilloud
The manual launch button doesn't exist for me. I am not a committer, so I don't have a login to Jenkins. On Wed, May 9, 2018 at 11:16 AM Lukasz Cwik wrote: > You can also just manually launch a seed job from within Jenkins pointing > at apache/master as its source. > > On Wed,

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Lukasz Cwik
You can also just manually launch a seed job from within Jenkins pointing at apache/master as its source. On Wed, May 9, 2018 at 11:10 AM Andrew Pilloud wrote: > I've not heard of seed jobs before, but from what I've been told I need to > create a PR with a empty

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Andrew Pilloud
Kenn tells me there is a button he can push to run it. He clicked it. Hopefully that fixes the postcommits. I don't know why Jenkins itself is having high latency but I've seen the same thing over the last few days. On Wed, May 9, 2018 at 11:09 AM Andrew Pilloud wrote: >

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Andrew Pilloud
I've not heard of seed jobs before, but from what I've been told I need to create a PR with a empty '.test-infra/jenkins' folder then type 'Run Seed Job' in a comment to apply the revert? Doing that now. Andrew On Wed, May 9, 2018 at 11:08 AM Lukasz Cwik wrote: > I am also

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Lukasz Cwik
I am also seeing the delayed launch of the tests. On Wed, May 9, 2018 at 10:56 AM Pablo Estrada wrote: > Does this require a Seed Job rerun? I'm seeing Python postcommits breaking > as well > > On Wed, May 9, 2018 at 10:49 AM Alan Myrvold wrote: > >> I

Re: Jackson serialisation of GenericJson subclasses

2018-05-09 Thread Tim Robertson
Hi Carlos Here is an example of subclassing with Jackson using the @Type annotation that I did many years ago: https://github.com/gbif/gbif-api/tree/master/src/main/java/org/gbif/api/model/registry/eml/temporal It decorates the JSON with an extra field ("@Type" in this case) which instructs the

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Pablo Estrada
Does this require a Seed Job rerun? I'm seeing Python postcommits breaking as well On Wed, May 9, 2018 at 10:49 AM Alan Myrvold wrote: > I saw ~1-2 hour latency for the trigger happening yesterday. Not sure what > would cause it to stop or be slow. > > On Wed, May 9, 2018

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Alan Myrvold
I saw ~1-2 hour latency for the trigger happening yesterday. Not sure what would cause it to stop or be slow. On Wed, May 9, 2018 at 10:45 AM Lukasz Cwik wrote: > It seems as though precommits are no longer triggering and trigger > requests like 'Run Java PreCommit' are no

Re: Please add me as a contributor

2018-05-09 Thread Lukasz Cwik
You have been added and I assigned the jira to you. On Wed, May 9, 2018 at 10:39 AM Kenneth Jung wrote: > Hi, > > I have a small bugfix that I'd like to contribute (tracked by > https://issues.apache.org/jira/browse/BEAM-4263). Can a PMC member add me > as a contributor? > >

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Lukasz Cwik
It seems as though precommits are no longer triggering and trigger requests like 'Run Java PreCommit' are no longer honored. On Wed, May 9, 2018 at 10:22 AM Andrew Pilloud wrote: > I broke all the post commits with this. Sorry! It has been reverted. I'm > going to follow up

Please add me as a contributor

2018-05-09 Thread Kenneth Jung
Hi, I have a small bugfix that I'd like to contribute (tracked by https://issues.apache.org/jira/browse/BEAM-4263). Can a PMC member add me as a contributor? Thanks Ken

Re: Jenkins Post Commit Status to Github

2018-05-09 Thread Andrew Pilloud
I broke all the post commits with this. Sorry! It has been reverted. I'm going to follow up with Apache Infra about getting the right credentials configured on the Jenkins plugin. Andrew On Tue, May 8, 2018 at 1:38 PM Andrew Pilloud wrote: > Yep, mess with the groovy

Jackson serialisation of GenericJson subclasses

2018-05-09 Thread Carlos Alonso
Hi everyone!! I'm working on BEAM-4257 issue and the approach I'm following is to create a new class 'BigQueryInsertError' that also extends 'GenericJson' and that contains three keys 'TableRow row', 'TableDataInsertAllResponse.InsertErrors error', and 'TableReference ref' and use this type as

Re: Graal instead of docker?

2018-05-09 Thread Eugene Kirpichov
On Wed, May 9, 2018 at 1:08 AM Romain Manni-Bucau wrote: > > > Le mer. 9 mai 2018 00:57, Henning Rohde a écrit : > >> There are indeed lots of possibilities for interesting docker >> alternatives with different tradeoffs and capabilities, but in

Re: ValidatesRunner test cleanup

2018-05-09 Thread Scott Wegner
FYI, this change is now merged [1]. Along with the many many other improvements made during the Gradle migration, many of our Jenkins test suites are now significantly faster than they used to be: * Java Precommit: before ~1h30m [2], now 37m [3] (59% reduction) * Flink ValidatesRunner: before

Jenkins build is back to normal : beam_SeedJob #1656

2018-05-09 Thread Apache Jenkins Server
See

Build failed in Jenkins: beam_SeedJob #1655

2018-05-09 Thread Apache Jenkins Server
See -- GitHub pull request #5180 of commit 1db667103e903edf9b35b9f68d2f00d603e042ab, no merge conflicts. Setting status of 1db667103e903edf9b35b9f68d2f00d603e042ab to PENDING with url

Re: Graal instead of docker?

2018-05-09 Thread Romain Manni-Bucau
Le mer. 9 mai 2018 00:57, Henning Rohde a écrit : > There are indeed lots of possibilities for interesting docker alternatives > with different tradeoffs and capabilities, but in generally both the runner > as well as the SDK must support them for it to work. As mentioned,

Build failed in Jenkins: beam_Release_Gradle_NightlySnapshot #33

2018-05-09 Thread Apache Jenkins Server
See Changes: [github] Explictly delcare globals defined elsewhere [schroederc] Move textio.FileSystem and its registry to a separate package [schroederc] Move filesystem implementations under

Jenkins build is back to normal : beam_SeedJob #1653

2018-05-09 Thread Apache Jenkins Server
See