Re: [VOTE] Vendored Dependencies Release

2019-08-28 Thread Andrew Pilloud
You need to close the release for it to be published to the staging server. I can help if you still have questions. Andrew On Wed, Aug 28, 2019, 8:48 PM Rui Wang wrote: > I can see prgapachebeam-1083 is in open status in staging repository. I am > not sure why it is not public exposed. I

Re: Is it too late to switch to Java 8 time for the schema aware Row and Beam SQL?

2019-08-28 Thread Rui Wang
We need to figure out a way to make sure we can read the data without losing precision. It will likely be case by case. -Rui On Wed, Aug 28, 2019 at 2:27 AM Alex Van Boxel wrote: > Thanks, how will ZetaSQL support higher precision as the input in general > will be Instant anyway. Will it rely

Re: [VOTE] Vendored Dependencies Release

2019-08-28 Thread Rui Wang
I can see prgapachebeam-1083 is in open status in staging repository. I am not sure why it is not public exposed. I probably need some guidance on it. -Rui On Wed, Aug 28, 2019 at 3:50 PM Kai Jiang wrote: > Hi Rui, > > For accessing artifacts [1] in Maven Central Repository, is this intent to

Re: Improve container support

2019-08-28 Thread Sam Bourne
> > If docker hub is the defacto place let's use that. bintray, or gcr.io (with > a new GCP project) also sounds like good options. I am impartial to the > choice of the service. Does anyone have a strong preference here? Not a strong preference, but it would simplify stuff for us if you choose

Re: [VOTE] Vendored Dependencies Release

2019-08-28 Thread Kai Jiang
Hi Rui, For accessing artifacts [1] in Maven Central Repository, is this intent to be not public exposed? Best, Kai [1] https://repository.apache.org/content/repositories/orgapachebeam-1083/ On Wed, Aug 28, 2019 at 11:57 AM Kai Jiang wrote: > +1 (non-binding)Thanks Rui! > > On Tue, Aug

[PROPOSAL] Preparing for Beam 2.16.0 release

2019-08-28 Thread Mark Liu
Hi all, Beam 2.16 release branch cut is scheduled on Sep 11 according to the release calendar [1]. I would like to volunteer myself to do this release. The plan is to cut the branch on that date, and cherrypick release-blocking fixes afterwards if any. If you have release blocking issues for

Re: RowWithGetters, FieldValueGetter being Serializable?

2019-08-28 Thread Reuven Lax
My first thought is that Row shouldn't need to be serializable at all. However it's possible that we have a dependency in some code on it being serializable. Worth testing it out to see what breaks. On Wed, Aug 28, 2019 at 2:55 AM Alex Van Boxel wrote: > Hi, > > I noticed that RowWithGetters

Re: [VOTE] Vendored Dependencies Release

2019-08-28 Thread Kai Jiang
+1 (non-binding)Thanks Rui! On Tue, Aug 27, 2019 at 10:46 PM Rui Wang wrote: > Please review the release of the following artifacts that we vendor: > > * beam-vendor-calcite-1_20_0 > > Hi everyone, > > Please review and vote on the release candidate #1 for the >

Re: Improve container support

2019-08-28 Thread Ahmet Altay
+1 to Pablo's comment. I believe any place that offers this service would be fine and we would need to figure out how to set it up correctly. Our pypi model seems to work fine so far (PMC members are owners, release managers are added as maintainers as needed.). To me, the important part is that

Re: Improve container support

2019-08-28 Thread Pablo Estrada
A question about the repository we're using. It seems that Docker Hub is the de-facto repo for docker images? Is GCR pretty much the same in terms of access, authentication, etc? We don't have to figure out the repository immediately, and it's fine to iterate - but I wanted to make sure we think

Re: Write-through-cache in State logic

2019-08-28 Thread Maximilian Michels
I've tried to put the current design into code. Any feedback appreciated for these changes to enable caching of user state: Proto: https://github.com/apache/beam/pull/9440 Runner: https://github.com/apache/beam/pull/9374 Python SDK: https://github.com/apache/beam/pull/9418 Thanks, Max On

Re: Master broken (likely due to Mockito upgrade)

2019-08-28 Thread Maximilian Michels
Master is ok again. Thank you Ryan for this one: https://github.com/apache/beam/pull/9442 On 28.08.19 14:32, Maximilian Michels wrote: Ismael pointed out that reverting #9338 works but the real culprit is https://github.com/apache/beam/pull/9000. Updated the PR to revert this commit instead.

Stop publishing unneeded Java artifacts

2019-08-28 Thread Ɓukasz Gajowy
Hi all, I wanted to notify that in PR 9417 I'm planning to turn off publishing of the following modules' artifacts to the maven repository: - :runners:google-cloud-dataflow-java:worker:windmill - :sdks:java:build-tools - :sdks:java:javadoc -

Re: [ANNOUNCE] New committer: Valentyn Tymofieiev

2019-08-28 Thread Frederik Bode
Congrats Valentyn!! On Wed, 28 Aug 2019 at 15:28, Tanay Tummalapalli wrote: > Congratulations Valentyn! > > On Wed, Aug 28, 2019 at 7:16 AM Ruoyun Huang wrote: > >> Congratulations Valentyn! >> >> On Tue, Aug 27, 2019 at 6:16 PM Daniel Oliveira >> wrote: >> >>> Congratulations Valentyn! >>>

Re: [ANNOUNCE] New committer: Valentyn Tymofieiev

2019-08-28 Thread Tanay Tummalapalli
Congratulations Valentyn! On Wed, Aug 28, 2019 at 7:16 AM Ruoyun Huang wrote: > Congratulations Valentyn! > > On Tue, Aug 27, 2019 at 6:16 PM Daniel Oliveira > wrote: > >> Congratulations Valentyn! >> >> On Tue, Aug 27, 2019, 11:31 AM Boyuan Zhang wrote: >> >>> Congratulations! >>> >>> On

Re: Improve container support

2019-08-28 Thread Lukasz Cwik
Google locks down docs created wtih @google.com addresses. Hannah please recreate the doc using a non @google.com address and share it with the community. You'll want to replace Google short link with an Apache short link (s.apache.org). On Wed, Aug 28, 2019 at 5:40 AM Gleb Kanterov wrote: >

Re: Improve container support

2019-08-28 Thread Gleb Kanterov
Google Doc doesn't seem to be shared with dev@. Can anybody double-check? On Wed, Aug 28, 2019 at 7:36 AM Hannah Jiang wrote: > add dev@ > > On Tue, Aug 27, 2019 at 9:29 PM Hannah Jiang > wrote: > >> Thanks for commenting and discussions. >> I created a Google Docs >>

Re: Master broken (likely due to Mockito upgrade)

2019-08-28 Thread Maximilian Michels
Ismael pointed out that reverting #9338 works but the real culprit is https://github.com/apache/beam/pull/9000. Updated the PR to revert this commit instead. -Max On 28.08.19 14:21, Maximilian Michels wrote: Hi, Most of you probably realized that the master is currently broken:

Master broken (likely due to Mockito upgrade)

2019-08-28 Thread Maximilian Michels
Hi, Most of you probably realized that the master is currently broken: https://builds.apache.org/job/beam_PreCommit_Java_Commit/7505/ https://builds.apache.org/job/beam_PreCommit_Java_Cron/ I did some bisecting and found that Mockito was updated: https://github.com/apache/beam/pull/9338 This

RowWithGetters, FieldValueGetter being Serializable?

2019-08-28 Thread Alex Van Boxel
Hi, I noticed that RowWithGetters and FieldValueGetter are both serializable (all in package org.apache.beam.sdk.values). I do have my doubt if they should be. Certainly RowWithGetters would be problematic: - it references the underlying object that could be anything and it's *not

Re: Write-through-cache in State logic

2019-08-28 Thread Maximilian Michels
Just to clarify, the repeated list of cache tokens in the process bundle request is used to validate reading *and* stored when writing? In that sense, should they just be called version identifiers or something like that? We could call them version identifiers, though cache tokens were always

Re: Is it too late to switch to Java 8 time for the schema aware Row and Beam SQL?

2019-08-28 Thread Alex Van Boxel
Thanks, how will ZetaSQL support higher precision as the input in general will be Instant anyway. Will it rely on the "pending" standardized logical types? _/ _/ Alex Van Boxel On Mon, Aug 19, 2019 at 7:02 AM Rui Wang wrote: > However, more challengings come from: > > 1. How to read data

Re: Write-through-cache in State logic

2019-08-28 Thread Maximilian Michels
cachetools sounds like a fine choice to me. For the first version I've implemented a simple LRU cache. If you want to have a look: https://github.com/apache/beam/pull/9418/files#diff-ed2d70e99442b6e1668e30409d3383a6R60 Open up a PR for the proto changes and we can work through any minor

Re: Did someone create a Beam Bintray account?

2019-08-28 Thread Hannah Jiang
I created a Bintray account tonight. Can you please verify it? We can update the email later to a more reasonable one. > On Aug 27, 2019, at 11:04 PM, Pablo Estrada wrote: > > I don't know what Bintray is, but I seem to remember it's related to Python > wheels? > > In any case, there are

Did someone create a Beam Bintray account?

2019-08-28 Thread Pablo Estrada
I don't know what Bintray is, but I seem to remember it's related to Python wheels? In any case, there are emails coming into moderation asking to validate the account. So if you created the account, please reach out to me/the PMC to figure out what it is / what to do. Best -P.