Re: [PROPOSAL] Merge gearpump-runner to master

2017-08-27 Thread Paul Findlay
Sorry, I missed this email. It appears Ken committed a fix soon after my email. On Fri, Aug 11, 2017 at 2:09 PM, Manu Zhang wrote: > Hi Paul, > > The latest master compiles fine for me. Could you check again ? > You may also want to check out the contribution guide >

Re: [PROPOSAL] Merge gearpump-runner to master

2017-08-10 Thread Manu Zhang
Hi Paul, The latest master compiles fine for me. Could you check again ? You may also want to check out the contribution guide . In short, the Apache way is to file a JIRA issue and submit a

Re: [PROPOSAL] Merge gearpump-runner to master

2017-08-07 Thread Paul Findlay
Cheers team. I have found a compilation issue on master (in CreateGearpumpPCollectionView), attached is a small patch Kind regards, Paul On Tue, Aug 8, 2017 at 4:10 PM, Manu Zhang wrote: > Thanks Kenn!!! Thanks everyone!!! It's a great achievement for us. > > On Tue,

Re: [PROPOSAL] Merge gearpump-runner to master

2017-08-07 Thread Manu Zhang
Thanks Kenn!!! Thanks everyone!!! It's a great achievement for us. On Tue, Aug 8, 2017 at 7:54 AM Kenneth Knowles wrote: > Done! > > On Fri, Jul 21, 2017 at 11:08 PM, Jean-Baptiste Onofré > wrote: > > > +1 > > > > Regards > > JB > > > > On Jul 22,

Re: [PROPOSAL] Merge gearpump-runner to master

2017-08-07 Thread Kenneth Knowles
Done! On Fri, Jul 21, 2017 at 11:08 PM, Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > On Jul 22, 2017, 05:06, at 05:06, Kenneth Knowles > wrote: > >+1 to this! > > > >I really want to call out the longevity of contribution behind this, >

Re: [PROPOSAL] Merge gearpump-runner to master

2017-07-22 Thread Jean-Baptiste Onofré
+1 Regards JB On Jul 22, 2017, 05:06, at 05:06, Kenneth Knowles wrote: >+1 to this! > >I really want to call out the longevity of contribution behind this, >following many changes in both Beam and Gearpump for over a year. >Here's >the first commit on the branch: > >

Re: [PROPOSAL] Merge gearpump-runner to master

2017-07-21 Thread Kenneth Knowles
+1 to this! I really want to call out the longevity of contribution behind this, following many changes in both Beam and Gearpump for over a year. Here's the first commit on the branch: commit 9478f4117de3a2d0ea40614ed4cb801918610724 (github/pr/323) Author: manuzhang