[RESULT] [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Anton Kedin
I'm happy to announce that we have unanimously approved this release. There are 7 approving votes, 4 of which are binding (in order): * Ahmet (al...@google.com); * Robert (rober...@google.com); * Pablo (pabl...@google.com); * Ismaël (ieme...@gmail.com); There are no disapproving votes. Thanks

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Chamikara Jayalath
+1 for continuing with RC1 with a notice about this issue. I marked this as a blocker for 2.15.0. Thanks, Cham On Wed, Jul 31, 2019 at 3:28 PM Anton Kedin wrote: > I am planning to close the vote tonight and this is the only potential > blocker discovered so far. So I strongly prefer to

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Eugene Kirpichov
I would recommend that the known issue notice about this source at least be strongly worded - this source in the current state should be marked "DO NOT USE" - it will produce data loss in *most* production use cases. That still leaves the risk that people will use it anyway; up to folks driving

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Ahmet Altay
Since the python mongodb source is new in this release (not a regression) and experimental, I agree with adding a known issues notice to the release notes instead of starting a RC2 only for this issue. On Wed, Jul 31, 2019 at 2:47 PM Chamikara Jayalath wrote: > FYI we found a critical issue

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Chamikara Jayalath
FYI we found a critical issue with the Python MongoDB source that is included with this release: https://issues.apache.org/jira/browse/BEAM-7866 I suggest we include a clear notice in the release about this issue if the release vote has already been finalized or make this a blocker if we are going

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Robert Bradshaw
On Wed, Jul 31, 2019 at 11:22 AM Valentyn Tymofieiev wrote: > I have checked Portable Wordcount example on Flink and Spark on Python 2 > and Python 3. > > To do so, I had to checkout Beam from git repo, since using the source > distribution does not include gradlew, and gradelw_orig did not work

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Valentyn Tymofieiev
I have checked Portable Wordcount example on Flink and Spark on Python 2 and Python 3. To do so, I had to checkout Beam from git repo, since using the source distribution does not include gradlew, and gradelw_orig did not work for me. Commands I ran: git checkout tags/v2.14.0-RC1 ./gradlew

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Ismaël Mejía
Oups Robert pointed to me that I have probably not counted correctly. There were indeed already 3 PMC +1 votes. Pablo, Robert and Ahmet. Please excuse me for the extra noise. On Wed, Jul 31, 2019 at 9:46 AM Ismaël Mejía wrote: > > To complete the release we need to have at least three +1 binding

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-31 Thread Ismaël Mejía
To complete the release we need to have at least three +1 binding votes (votes from PMC members) as stated in [1]. So far we have only 2. Thomas (and the others). The blog post PR is now open [2] please help us add missing features or maybe to highlight the ones you consider important in the PR

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-30 Thread Anton Kedin
Ran various postcommits, validates runners, and nexmark against the release branch. All looks good so far. Will take another look at the docs/blog and the nexmark numbers tomorrow, but if nothing comes up I will close the vote tomorrow (Wednesday) by 6pm PST (= Thursday 01:00am UTC) since it's

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-30 Thread Valentyn Tymofieiev
I also ran unit tests for Python 3.7 and they passed as well. Cython tests for python3.7 require `apt-get install python3.7-dev`. On Wed, Jul 31, 2019 at 3:16 AM Pablo Estrada wrote: > +1 > > I installed from source, and ran unit tests for Python in 2.7, 3.5, 3.6. > > Also ran a number of

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-30 Thread Pablo Estrada
+1 I installed from source, and ran unit tests for Python in 2.7, 3.5, 3.6. Also ran a number of integration tests on Py 3.5 on Dataflow and DirectRunner. Best -P. On Tue, Jul 30, 2019 at 11:09 AM Hannah Jiang wrote: > I checked Py3 tests using .zip, mainly with direct runners, and everything

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-30 Thread Hannah Jiang
I checked Py3 tests using .zip, mainly with direct runners, and everything looks good, so +1. On Tue, Jul 30, 2019 at 2:08 AM Robert Bradshaw wrote: > I checked all the artifact signatures and ran a couple test pipelines with > the wheels (Py2 and Py3) and everything looked good to me, so +1. >

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-30 Thread Robert Bradshaw
I checked all the artifact signatures and ran a couple test pipelines with the wheels (Py2 and Py3) and everything looked good to me, so +1. On Mon, Jul 29, 2019 at 8:29 PM Valentyn Tymofieiev wrote: > I have checked Python 3 batch and streaming quickstarts on Dataflow runner > using .zip and

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-29 Thread Valentyn Tymofieiev
I have checked Python 3 batch and streaming quickstarts on Dataflow runner using .zip and wheel distributions. So far +1 from me. On Mon, Jul 29, 2019 at 7:53 PM Ahmet Altay wrote: > +1, validated python 2 quickstarts. > > On Fri, Jul 26, 2019 at 5:46 PM Ahmet Altay wrote: > >> To confirm, I

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-29 Thread Ahmet Altay
+1, validated python 2 quickstarts. On Fri, Jul 26, 2019 at 5:46 PM Ahmet Altay wrote: > To confirm, I manuall validated leader board on python. It is working. > > On Fri, Jul 26, 2019 at 5:23 PM Yifan Zou wrote: > >> AFAIK, there should not be any special prerequisites for this. Things the >>

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Ahmet Altay
To confirm, I manuall validated leader board on python. It is working. On Fri, Jul 26, 2019 at 5:23 PM Yifan Zou wrote: > AFAIK, there should not be any special prerequisites for this. Things the > script does including: > 1. download the python rc in zip > 2. start virtualenv and install the

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Yifan Zou
AFAIK, there should not be any special prerequisites for this. Things the script does including: 1. download the python rc in zip 2. start virtualenv and install the sdk. 3. verify hash. 4. config settings.xml and start a Java pubsub message injector. 5. run game examples and validate. Could you

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Anton Kedin
Cool, will make the post and will update the release guide as well then On Fri, Jul 26, 2019 at 10:20 AM Chad Dombrova wrote: > I think the release guide needs to be updated to remove the optionality of >> blog creation and avoid confusion. Thanks for pointing that out. >> > > +1 > >

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Chad Dombrova
> > I think the release guide needs to be updated to remove the optionality of > blog creation and avoid confusion. Thanks for pointing that out. > +1

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Thomas Weise
A quick look over the JIRA release notes reveals new features and important improvements that call to be announced. I think the release guide needs to be updated to remove the optionality of blog creation and avoid confusion. Thanks for pointing that out. On Fri, Jul 26, 2019 at 9:53 AM Anton

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Anton Kedin
Hi Thomas, I haven't made it. I read that step of the guide as optional ("..if needed for this particular release..."). I am not sure if anything specific needs to be announced or highlighted for 2.14. I can go over the closed Jiras and create a blog post if it's expected. Regards, Anton On Fri,

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-26 Thread Thomas Weise
Hi Anton, Thanks for working on the release. I don't find the release blog in https://github.com/apache/beam/pull/9157 or elsewhere? This should be part of the release candidate [1] and I wonder why we keep on missing it in RCs. Is there something that needs be be fixed in [1]? The reason why

Re: [VOTE] Release 2.14.0, release candidate #1

2019-07-25 Thread Rui Wang
Tried to verify RC1 by running Nexmark on Dataflow but found it's broken (at least based commands from Running+Nexmark ). Will try to debug it and rerun the process. -Rui On Thu, Jul 25, 2019 at 2:39 PM Anton Kedin wrote: > Hi

[VOTE] Release 2.14.0, release candidate #1

2019-07-25 Thread Anton Kedin
Hi everyone, Please review and vote on the release candidate #3 for the version 2.14.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *