Re: Behavior change for Gradle build target

2020-09-30 Thread Brian Hulette
I opened up BEAM-10986 [1] to track this, let's move discussion there. [1] https://issues.apache.org/jira/browse/BEAM-10986 On Tue, Sep 29, 2020 at 2:40 PM Brian Hulette wrote: > A bisect found [1] to be the culprit, it upgrades the shadow plugin. I > suspect it's related to this change in shad

Re: Behavior change for Gradle build target

2020-09-29 Thread Brian Hulette
A bisect found [1] to be the culprit, it upgrades the shadow plugin. I suspect it's related to this change in shadow 4.0.4 [2], but I'm not sure: > When using shadow, application, and maven plugins together, remove shadowDistZip and shadowDistTar from > configurations.archives so they are not publ

Re: Behavior change for Gradle build target

2020-09-29 Thread Brian Hulette
I think that output is still incorrect for :sdks:java:io:expansion-service, there should be both shaded and unshaded in ./sdks/java/io/expansion-service/build/libs On Tue, Sep 29, 2020 at 1:08 PM Tyson Hamilton wrote: > Or, possibly that PR already fixed the issue. Could you sync, retry again? >

Re: Behavior change for Gradle build target

2020-09-29 Thread Tyson Hamilton
Or, possibly that PR already fixed the issue. Could you sync, retry again? Here is what I found after running the gradle task you mentioned: ttysonjh@tysonjh:~/Development/beam$ find . -name "*expansion-service*SNAPSHOT*" ./sdks/java/expansion-service/build/libs/beam-sdks-java-expansion-service-2.

Re: Behavior change for Gradle build target

2020-09-29 Thread Tyson Hamilton
Hm. It sounds like it is possibly related to the gradle upgrade to 6? I had a similar issue that I fixed for the Java nightly snapshot build in PR#12947 (https://github.com/apache/beam/pull/12947). It may require similar changes to the gradle.build file to generate the jar. On Tue, Sep 29, 2020 at

Behavior change for Gradle build target

2020-09-28 Thread Chamikara Jayalath
Hi, I just noticed that the result jars produced by command "./gradlew :sdks:java:io:expansion-service:build" went from both shaded [1] and unshaded [2] jars for Beam 2.24.0 branch to just the unshaded jar [3] for Beam 2.25.0 branch. Does anyone know what resulted in this behaviour change ? Also