Re: Inclusive terminology: "Sickbay" ==> "Disabled test"

2022-10-17 Thread Reuven Lax via dev
To add to this, I think one reason originally for using "sickbay" was to emphasize that this should be temporary. Removing tests from pre/post commits permanently is a bad state to be in - at that point why even have the test? Ideally if a test is extremely flaky, fixing that is highly

Re: Inclusive terminology: "Sickbay" ==> "Disabled test"

2022-10-17 Thread Yi Hu via dev
(From someone who received education not in English and from another field). I first assumed this is some terminology just like "flaky", "smock test" because I came from another world and did not know most of the terms in this field. That said, I just assumed it was another term used in the field

Re: Inclusive terminology: "Sickbay" ==> "Disabled test"

2022-10-17 Thread Danny McCormick via dev
I'm +1 on this, sickbay was a new term for me when I joined the project. One thing I will note: we still have plenty of sickbay references in our code itself - https://github.com/apache/beam/search?p=1=sickbay - if we decide to take this forward we should create an issue to remove those (with the

Inclusive terminology: "Sickbay" ==> "Disabled test"

2022-10-17 Thread Kenneth Knowles
Hi all, I have gotten a lot of questions from people like "what is sickbay?" Because I am a Star Trek enthusiast I easily understood that if I "sickbay the test" means to disable it temporarily. And people on my team are used to this terminology. But this is not all people :-) and there are many