Re: Python postcommit and precommit

I think we should replace the shell script with a top level pythonPostCommit gradle target, similar to the precomment. On Mon, Apr 9, 2018 at 12:12 PM Lukasz Cwik wrote: > The shell scripts still exist instead of using Gradle. Migrating to Gradle > as the build system hasn't

Re: Python postcommit and precommit

The shell scripts still exist instead of using Gradle. Migrating to Gradle as the build system hasn't addressed this (only change in the Gradle migration was an improvement where Gradle now creates a virtualenv automatically for building). Alan, any plans to integrate more closely with Gradle

Re: Python postcommit and precommit

Was this resolved off list? I think it makes sense to have a dependency-driven build tool as the entry point to these processes. So in our case, Gradle. If setting it up in Gradle/Groovy is a pain, having it shell out seems fine as an implementation detail, but you need to set up inputs/outputs of

Python postcommit and precommit

Hi, I noticed that Python precommit runs using this command: mvn clean install -pl sdks/python -am -amd while postcommit invocation is simply a bash script: bash sdks/python/run_postcommit.sh Both run unit tests via Tox, however since the runtime environment setup is configured in different