Re: [VOTE] Release 2.18.0, release candidate #1

I don't have anything conclusive yet; it could also be related to our infra. I would not block the release. Thomas On Wed, Jan 22, 2020 at 1:01 PM Udi Meiri wrote: > Thomas, please let us know if you learn more about possible root causes to > the regression you're seeing. > Also, if you

Re: [VOTE] Release 2.18.0, release candidate #1

Thomas, please let us know if you learn more about possible root causes to the regression you're seeing. Also, if you believe this should block the release then please vote -1. Does Beam have performance tests for the Python Flink portable streaming case? On Wed, Jan 22, 2020 at 8:08 AM

Re: [VOTE] Release 2.18.0, release candidate #1

+1 (binding) Quickly tested on beam-samples. Regards JB On 22/01/2020 16:33, Ismaël Mejía wrote: > +1 (binding) > > - Validated signatures > - Run Python wordcount on Direct runner (from wheels) > - Run Python wordcount on Flink runner with job-server image (via wheels) > - Run Python

Re: [VOTE] Release 2.18.0, release candidate #1

When trying to upgrade our fork from 2.16 to 2.18, we see a significant performance degradation. This applies to Flink portable streaming with the Python SDK. I don't know what the cause is yet. If anyone else has done validation with a similar setup and this RC, it would be good to know the

Re: [VOTE] Release 2.18.0, release candidate #1

+1. In addition to checks performed earlier, re-ran streaming quickstarts and batch mobile gaming examples on Dataflow runner after containers were updated. On Wed, Jan 22, 2020 at 7:33 AM Ismaël Mejía wrote: > +1 (binding) > > - Validated signatures > - Run Python wordcount on Direct runner

Re: [VOTE] Release 2.18.0, release candidate #1

+1 (binding) - Validated signatures - Run Python wordcount on Direct runner (from wheels) - Run Python wordcount on Flink runner with job-server image (via wheels) - Run Python wordcount on Spark runner with job-server from source (via wheels) - Validate no regressions on Nexmark for Spark

Re: [VOTE] Release 2.18.0, release candidate #1

Agree with Ahmet and Robert - IMO, this is not a blocker for 2.18. Sorry for messing things up a bit with this commit, we can revert it from 2.18 branch if it’s needed. > On 21 Jan 2020, at 22:48, Robert Bradshaw wrote: > > On Tue, Jan 21, 2020 at 12:04 PM Ahmet Altay wrote: >> >> This

Re: [VOTE] Release 2.18.0, release candidate #1

> Also, does anyone know how can I (we) validate the new docker image for Flink's job server included in this release? To start the job server: docker run --net=host apachebeam/flink1.9_job_server:2.18.0_rc1 Then you can run any Beam Java/Python/Go job with job endpoint localhost:8099 to

Re: [VOTE] Release 2.18.0, release candidate #1

On Tue, Jan 21, 2020 at 12:04 PM Ahmet Altay wrote: > > This change (https://github.com/apache/beam/pull/10625) was merged after the > RC1 email was out. IMO, we do not need to block RC1 vote for this. If there > will be an RC2 the change will be included. Agreed, we do not need to block RC1

Re: [VOTE] Release 2.18.0, release candidate #1

If there is a rc2 I would like to get BEAM-9144 since this is a regression reported already by one user. I am not sure however if it counts as a blocker since it is a quite particular use case. Also, does anyone know how can I (we) validate the

Re: [VOTE] Release 2.18.0, release candidate #1

This change (https://github.com/apache/beam/pull/10625) was merged after the RC1 email was out. IMO, we do not need to block RC1 vote for this. If there will be an RC2 the change will be included. I recall we had a similar thread before. Please, include the release managers in the PRs that

Re: [VOTE] Release 2.18.0, release candidate #1

I was not aware of https://issues.apache.org/jira/browse/BEAM-9123 or the PR on the release branch. On Tue, Jan 21, 2020 at 11:16 AM Robert Bradshaw wrote: > The source tarball seems to be missing the commit at > > https://github.com/apache/beam/commit/a61dfbf4570e3adb30e15315c116751faeda897e >

Re: [VOTE] Release 2.18.0, release candidate #1

The source tarball seems to be missing the commit at https://github.com/apache/beam/commit/a61dfbf4570e3adb30e15315c116751faeda897e On Tue, Jan 21, 2020 at 9:49 AM Ahmet Altay wrote: > > All, could you help with validations and voting? > > On Wed, Jan 15, 2020 at 6:14 PM Ahmet Altay wrote: >>

Re: [VOTE] Release 2.18.0, release candidate #1

All, could you help with validations and voting? On Wed, Jan 15, 2020 at 6:14 PM Ahmet Altay wrote: > +1, validated the same things, they still work. Thank you. > > On Wed, Jan 15, 2020 at 5:01 PM Udi Meiri wrote: > >> Dataflow containers have been updated. Test away. >> >> On Tue, Jan 14,

Re: [VOTE] Release 2.18.0, release candidate #1

+1, validated the same things, they still work. Thank you. On Wed, Jan 15, 2020 at 5:01 PM Udi Meiri wrote: > Dataflow containers have been updated. Test away. > > On Tue, Jan 14, 2020 at 6:37 PM Udi Meiri wrote: > >> Here my second take: >> >> Hi everyone, >> Please review and vote on the

Re: [VOTE] Release 2.18.0, release candidate #1

Dataflow containers have been updated. Test away. On Tue, Jan 14, 2020 at 6:37 PM Udi Meiri wrote: > Here my second take: > > Hi everyone, > Please review and vote on the release candidate #1 for the version 2.18.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the

Re: [VOTE] Release 2.18.0, release candidate #1

Here my second take: Hi everyone, Please review and vote on the release candidate #1 for the version 2.18.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: *

Re: [VOTE] Release 2.18.0, release candidate #1

Please don't do any Dataflow-based verifications yet, because we'll have to redo them once new Dataflow containers are built. On Tue, Jan 14, 2020 at 6:27 PM Ahmet Altay wrote: > I verified python 2 quickstarts with batch and streaming pipelines, wheel > files, and reviewed changes to the

Re: [VOTE] Release 2.18.0, release candidate #1

I verified python 2 quickstarts with batch and streaming pipelines, wheel files, and reviewed changes to the blog/website. Udi, could you send an updated version of the voting text with TODOs, template pieces removed? We can discuss changes to the template separately. My vote is +1 pending an

Re: [VOTE] Release 2.18.0, release candidate #1

Sorry about the messiness. The links at the bottom should be correct though. I intentionally did not replace MAVEN_VERSION because I didn't know how to get it (I didn't execute mvn for the release). As for JDK_VERSION, do we still need that? (If so, what about Python versions, such as the ones

Re: [VOTE] Release 2.18.0, release candidate #1

There are some issues in this message, part of the message is still a template (1.2.3, TODO, MAVEN_VERSION). Before I noticed these issues, I ran a few Batch and Streaming Python 3.7 pipelines using Direct and Dataflow runners, and they all succeeded. On Mon, Jan 13, 2020 at 4:09 PM Udi Meiri