Re: JDK11 support?

2019-04-10 Thread Michał Walenia
Yes, if you look at the DataflowRunner code [1], if you set a system property 'java.specification.version' to 11, the runner will automatically pull java11 enabled worker harness. [1]

Re: JDK11 support?

2019-04-10 Thread Gleb Kanterov
Is there a way to try JDK11 harness for Dataflow without building own docker image? On Wed, Apr 10, 2019 at 2:10 AM Yi Pan wrote: > Hi, Pablo, > > Thanks for the clarification. Does that mean that there needs to be a > separate effort to ensure KafkaIO to be Java 8 source compat and Java 11 >

Re: JDK11 support?

2019-04-09 Thread Yi Pan
Hi, Pablo, Thanks for the clarification. Does that mean that there needs to be a separate effort to ensure KafkaIO to be Java 8 source compat and Java 11 runtime compat? -Yi On Tue, Apr 9, 2019 at 5:03 PM Pablo Estrada wrote: > Our work (mostly done by Michal), consisted on testing that Beam

Re: JDK11 support?

2019-04-09 Thread Yi Pan
Hi, all, Thanks a lot for the pointers. Very useful and glad to see it in motion! One thing I would like to consider is: except for some core modules that all Beam code uses, can we start marking individual SDKs as JDK11 compatible? For example, we are using DataflowRunner and Kafka, is it

Re: JDK11 support?

2019-04-09 Thread Pablo Estrada
Our work (mostly done by Michal), consisted on testing that Beam artifacts built with Java 8 can run in a Java 11 environment in the DirectRunner and Dataflow. We have not planned other work in this area. On Tue, Apr 9, 2019 at 3:00 PM Ahmet Altay wrote: > Most recently +Pablo Estrada and

Re: JDK11 support?

2019-04-09 Thread Pablo Estrada
To clarify: This included adding tests to run continuously on Jenkins (by my previous phrasing, it may have sounded like we only tested this manually :P). On Tue, Apr 9, 2019 at 4:57 PM Pablo Estrada wrote: > Our work (mostly done by Michal), consisted on testing that Beam artifacts > built

Re: JDK11 support?

2019-04-09 Thread Ahmet Altay
Most recently +Pablo Estrada and +Michał Walenia were working on Java 11 related JIRAs. They may have more context. On Tue, Apr 9, 2019 at 1:22 PM Maximilian Michels wrote: > Hi Yi, > > That's a great question. Beam is still on Java 8 at the moment. There is > a JIRA issue for making Beam

Re: JDK11 support?

2019-04-09 Thread Maximilian Michels
Hi Yi, That's a great question. Beam is still on Java 8 at the moment. There is a JIRA issue for making Beam compatible with Java 11: https://issues.apache.org/jira/browse/BEAM-2530 As you can read in the issue, the upcoming Beam 2.12.0 has experimental support for Java 11. That said, there