Re: goVet and clickHouse tests failing

2019-11-30 Thread Robert Burke
Hello! A goal (that is up for anyone interested to work on) is to move the Beam Go SDK to use Go Modules[2] rather than the GoGradle[3] plugin's lock file, since this unifies the experience for both working on the Go SDK (as a Beam dev) and with the Go SDK (as a Beam user). The plugin hasn't been

Re: goVet and clickHouse tests failing

2019-11-29 Thread Amogh Tiwari
Adding +Sameer Abhyankar for visibility. On Fri, Nov 29, 2019 at 4:10 PM Amogh Tiwari wrote: > Hi Elliotte, > Thanks for your reply. > Tried out the steps that you suggested, still not able to resolve this > issue. > Should I use a particular version of go for the build? > What I have noticed

Re: goVet and clickHouse tests failing

2019-11-29 Thread Amogh Tiwari
Hi Elliotte, Thanks for your reply. Tried out the steps that you suggested, still not able to resolve this issue. Should I use a particular version of go for the build? What I have noticed is that when I ./gradlew build, it automatically downloads go 1.12 and sets the go env for it, basically

Re: goVet and clickHouse tests failing

2019-11-27 Thread Elliotte Rusty Harold
I did get through this one, and made the classic mistake of not immediately committing the steps I took to writing. I believe it involved some combination of setting go paths in environment variables. I seem to have added this to the end of my .profile: export GOROOT=/usr/local/go export

Re: goVet and clickHouse tests failing

2019-11-27 Thread Amogh Tiwari
Hi Elliotte, I am facing a similar goVet issue. It would be great if you can guide me through the solution. Please let me know the steps that you followed. Regards, Amogh On Thu, Nov 21, 2019 at 6:06 PM Elliotte Rusty Harold wrote: > Tentatively, the goVet issue does seem to have been an issue

Re: goVet and clickHouse tests failing

2019-11-21 Thread Kenneth Knowles
It would be nice if this failed gracefully, indicating what dependency is not installed. Kenn On Thu, Nov 21, 2019 at 4:38 AM Elliotte Rusty Harold wrote: > That would explain it. I didn't have Docker installed. I do now, so > let's see if it passes. Ultimately the root cause for a lot of this

Re: goVet and clickHouse tests failing

2019-11-21 Thread Elliotte Rusty Harold
That would explain it. I didn't have Docker installed. I do now, so let's see if it passes. Ultimately the root cause for a lot of this seems to be incomplete and conflicting docs. I hope we can invest some effort into improving this. On Thu, Nov 21, 2019 at 6:27 AM Gleb Kanterov wrote: > >

Re: goVet and clickHouse tests failing

2019-11-21 Thread Elliotte Rusty Harold
Tentatively, the goVet issue does seem to have been an issue with my Go install I have now cleaned up. The clickhouse issue remains, as do several others I'm working through. I've filed https://issues.apache.org/jira/browse/BEAM-8798 to consolidate and update the instructions for getting to a

Re: goVet and clickHouse tests failing

2019-11-21 Thread Gleb Kanterov
:sdks:java:io:clickhouse:test is using testcontainers. Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container. Therefore, ClickHouse tests require a local

goVet and clickHouse tests failing

2019-11-21 Thread Elliotte Rusty Harold
I'm slowly working my way through getting the tests to run and pass. We have a lot of work to do on the contributing docs to explain how to setup and run the build. There's clearly a lot of knowledge in developers' heads and workstations that hasn't yet made it into the docs. The latest is a