Re: rename: BeamRecord -> Row

2018-02-03 Thread Reuven Lax
This thread exists so others can weigh in on the name if they want :) If I don't hear any conflicting opinions, I'll merge the PR with Row (though of course this is all still an experimental API, so we can easily change our minds about the name later) On Sat, Feb 3, 2018 at 9:44 AM, Romain

Re: rename: BeamRecord -> Row

2018-02-03 Thread Romain Manni-Bucau
This is as true as the renaming is not needed so I guess the PR owner will decide ;). Thanks for the clarification. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: rename: BeamRecord -> Row

2018-02-03 Thread Reuven Lax
Oh I agree 100%, however I'm just saying that we shouldn't ask the SQL effort to halt just because the schema effort overlaps. There's at least one other pending PR on this class (to do with automatic POJO generation). Also the name of the Record/Row class is somewhat independent of everything

Re: rename: BeamRecord -> Row

2018-02-03 Thread Romain Manni-Bucau
I know Reuven, but when you check what it does, it is exactly the same and the current work will be to replace by the schema work so better to avoid a round trip of work which will be throw away in any case. Also note that current structure is flat and very limiting for modern SQL so the alignment

Re: rename: BeamRecord -> Row

2018-02-03 Thread Reuven Lax
This is a core part of SQL which is ongoing. On Feb 2, 2018 11:45 PM, "Romain Manni-Bucau" wrote: > Hi > > Shouldnt the discussion on schema which has a direct impact on this > generic container be closed before any action on this? > > > Le 3 févr. 2018 01:09, "Ankur

Re: rename: BeamRecord -> Row

2018-02-02 Thread Romain Manni-Bucau
Hi Shouldnt the discussion on schema which has a direct impact on this generic container be closed before any action on this? Le 3 févr. 2018 01:09, "Ankur Chauhan" a écrit : > ++ > > On Fri, Feb 2, 2018 at 1:33 PM Rafael Fernandez > wrote: > >> Very

Re: rename: BeamRecord -> Row

2018-02-02 Thread Ankur Chauhan
++ On Fri, Feb 2, 2018 at 1:33 PM Rafael Fernandez wrote: > Very strong +1 > > > On Fri, Feb 2, 2018 at 1:24 PM Reuven Lax wrote: > >> We're looking at renaming the BeamRecord class >> , that was used for columnar

Re: rename: BeamRecord -> Row

2018-02-02 Thread Rafael Fernandez
Very strong +1 On Fri, Feb 2, 2018 at 1:24 PM Reuven Lax wrote: > We're looking at renaming the BeamRecord class > , that was used for columnar > data. There was sufficient discussion on the naming, that I want to make > sure the dev

rename: BeamRecord -> Row

2018-02-02 Thread Reuven Lax
We're looking at renaming the BeamRecord class , that was used for columnar data. There was sufficient discussion on the naming, that I want to make sure the dev list is aware of naming plans here. BeamRecord is a columnar, field-based record. Currently