Re: [ANNOUNCE] New committer: Chad Dombrova

2020-02-25 Thread Chamikara Jayalath
Congrats Chad! On Tue, Feb 25, 2020 at 6:00 AM jincheng sun wrote: > Congratulations Chad! > > Best, > Jincheng > > > Jan Lukavský 于2020年2月25日周二 下午5:05写道: > >> Congrats Chad! >> On 2/25/20 9:48 AM, Gleb Kanterov wrote: >> >> Congratulations! >> >> On Tue, Feb 25, 2020 at 9:44 AM Ismaël Mejía

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Jean-Baptiste Onofré
+1Regards JBLe mar. 25 f?vr. 2020 ? 13:43, Isma?l Mej?a a ?crit :Please review the release of the following artifacts that we vendor: * beam-vendor-bytebuddy-1_10_8Hi everyone,Please review and vote on the release candidate #1 for the version 0.1, as follows:[ ] +1, Approve the release[ ] -1, Do

Re: Github flaky?

2020-02-25 Thread Alan Myrvold
There is an active incident, from https://www.githubstatus.com/ On Tue, Feb 25, 2020 at 10:10 AM Luke Cwik wrote: > I have been getting errors from the Github UI when attempting to post a > comment / merge a commit / 500 errors when reloading a page. Anyone else > seeing this? >

Re: Can any contributor trigger PreCommit tests?

2020-02-25 Thread Boyuan Zhang
Hey Wenbing, Which tests you are interested in? Most non-dataflow tests can be ran locally for testing purposes. On Tue, Feb 25, 2020 at 11:15 AM Hannah Jiang wrote: > Committers can trigger the tests. Can you share your PRs here so people > who have permission can trigger tests for your PRs?

Re: [ANNOUNCE] New committer: Jincheng Sun

2020-02-25 Thread Rui Wang
Congrats! -Rui On Mon, Feb 24, 2020 at 11:24 PM Austin Bennett wrote: > Congrats! > > On Mon, Feb 24, 2020, 11:22 PM Alex Van Boxel wrote: > >> Congrats! >> >> _/ >> _/ Alex Van Boxel >> >> >> On Mon, Feb 24, 2020 at 8:13 PM Kyle Weaver wrote: >> >>> Thanks Jincheng for all your work on

Re: Review Request

2020-02-25 Thread Pablo Estrada
Thanks! I'll take a look today. On Mon, Feb 24, 2020 at 5:19 PM Wenbing Bai wrote: > Hi there, > > Can I get a review on this PR https://github.com/apache/beam/pull/10901? > > -- > > > > > > Wenbing Bai > > Senior Software Engineer, MLP > > Cruise > > Pronouns: She/Her > > > > *Confidentiality

Re: Can any contributor trigger PreCommit tests?

2020-02-25 Thread Wenbing Bai
I have the same issue. Follow this thread. Wenbing On Tue, Feb 25, 2020 at 9:43 AM Liu Wang wrote: > Hi, > > I'm a contributor but can't trigger tests for my PRs. Do I need to get any > permission for this? > Is it like any contributor can apply for and get the permission? > > Thanks, > Liu >

Re: Can any contributor trigger PreCommit tests?

2020-02-25 Thread Hannah Jiang
Committers can trigger the tests. Can you share your PRs here so people who have permission can trigger tests for your PRs? Please refer to this thread for more details of

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Reuven Lax
+1 On Tue, Feb 25, 2020 at 4:44 AM Ismaël Mejía wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-bytebuddy-1_10_8 > > Hi everyone, > Please review and vote on the release candidate #1 for the version 0.1, as > follows: > [ ] +1, Approve the release

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Luke Cwik
-1 The jar contains META-INF/versions/9/module-info.class copied over from bytebuddy containing: module net.bytebuddy { requires static java.instrument; requires static jdk.unsupported; requires static net.bytebuddy.agent; exports net.bytebuddy; exports net.bytebuddy.agent.builder;

Re: Create a 2.21.0 tag

2020-02-25 Thread Kenneth Knowles
Done On Tue, Feb 25, 2020 at 10:25 AM Rui Wang wrote: > Hi Community, > > Is there a PMC who is able to create 2.21.0 tag to help people move their > Jiras? > > > > -Rui >

Can any contributor trigger PreCommit tests?

2020-02-25 Thread Liu Wang
Hi, I'm a contributor but can't trigger tests for my PRs. Do I need to get any permission for this? Is it like any contributor can apply for and get the permission? Thanks, Liu

Re: [VOTE] Upgrade gradle to 6.2

2020-02-25 Thread Luke Cwik
+1 On Tue, Feb 25, 2020 at 12:49 AM Gleb Kanterov wrote: > +1 (non-binding) > > On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía wrote: > >> +1 great to have our build updated, please share if there are new >> interesting features/plugin advantages we can benefit from too. >> >> On Tue, Feb 25,

Re: Github flaky?

2020-02-25 Thread Robert Burke
I've seen complaints on Twitter about GitHub availablilty today, so it's not just you. On Tue, Feb 25, 2020, 10:10 AM Luke Cwik wrote: > I have been getting errors from the Github UI when attempting to post a > comment / merge a commit / 500 errors when reloading a page. Anyone else > seeing

[RESULT] [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-25 Thread Luke Cwik
I'm happy to announce that we have unanimously approved this release. There are 7 approving votes, 4 of which are binding: * Ismaël Mejía * Robert Bradshaw * Ahmet Altay * Luke Cwik There are no disapproving votes. Thanks everyone! On Sat, Feb 22, 2020 at 5:49 AM Ismaël Mejía wrote: > +1

Are there extra Beam Python test matchers available?

2020-02-25 Thread Liu Wang
Hi, As far as I know, the matchers I can use with assert_that are equal_to and matches_all in this file: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/util.py Is there any matcher that I can test a PCollection contains a subset? Is there any matcher that I can test a

Github flaky?

2020-02-25 Thread Luke Cwik
I have been getting errors from the Github UI when attempting to post a comment / merge a commit / 500 errors when reloading a page. Anyone else seeing this?

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Ismaël Mejía
Thanks Luke there is indeed an extra module-info.class in the vendored jar. This vote is cancelled. A new vote will be opened once the fix is merged. PTAL https://github.com/apache/beam/pull/10970 On Tue, Feb 25, 2020 at 6:39 PM Luke Cwik wrote: > -1 > > The jar contains

Re: [DISCUSSION] Use github actions for python wheels ?

2020-02-25 Thread Kenneth Knowles
+1 to exploring this. On bui...@apache.org there is lots of discussion and general approval for trying it. It is enabled and used by some projects. Calcite uses it to build their website, for example. Kenn On Tue, Feb 25, 2020 at 2:08 PM Ahmet Altay wrote: > Hi all, > > I recently had a

[DISCUSSION] Use github actions for python wheels ?

2020-02-25 Thread Ahmet Altay
Hi all, I recently had a chance to look at the documentation for github actions. I think we could use github actions instead of travis to for building python wheels during releases. This will have the following advantages: - We will eliminate one repo. (If you don't know, we have

Re: Can any contributor trigger PreCommit tests?

2020-02-25 Thread Liu Wang
How can I become a committer? On 2020/02/25 19:14:28, Hannah Jiang wrote: > Committers can trigger the tests. Can you share your PRs here so people who > have permission can trigger tests for your PRs? > Please refer to this thread >

Re: [DISCUSSION] Use github actions for python wheels ?

2020-02-25 Thread Robert Bradshaw
I'd be in favor of this, assuming it actually simplifies things. (Note that the wheels are for several variants of linux, presumably we could do cross-compiles. Also, manylinux is a "minimal" linux specifically built as to produce shared object libraries compatible with a wide variety of

Re: Can any contributor trigger PreCommit tests?

2020-02-25 Thread Liu Wang
https://github.com/apache/beam/pull/10951 On 2020/02/25 19:14:28, Hannah Jiang wrote: > Committers can trigger the tests. Can you share your PRs here so people who > have permission can trigger tests for your PRs? > Please refer to this thread >

Re: [ANNOUNCE] New committer: Jincheng Sun

2020-02-25 Thread Chamikara Jayalath
Congrats Jincheng! On Tue, Feb 25, 2020 at 10:14 AM Rui Wang wrote: > Congrats! > > > -Rui > > On Mon, Feb 24, 2020 at 11:24 PM Austin Bennett < > whatwouldausti...@gmail.com> wrote: > >> Congrats! >> >> On Mon, Feb 24, 2020, 11:22 PM Alex Van Boxel wrote: >> >>> Congrats! >>> >>> _/ >>> _/

Re: [ANNOUNCE] New committer: Chad Dombrova

2020-02-25 Thread Valentyn Tymofieiev
Congratulations, Chad! On Tue, Feb 25, 2020 at 9:36 AM Chamikara Jayalath wrote: > Congrats Chad! > > On Tue, Feb 25, 2020 at 6:00 AM jincheng sun > wrote: > >> Congratulations Chad! >> >> Best, >> Jincheng >> >> >> Jan Lukavský 于2020年2月25日周二 下午5:05写道: >> >>> Congrats Chad! >>> On 2/25/20

Re: [ANNOUNCE] New committer: Jincheng Sun

2020-02-25 Thread Valentyn Tymofieiev
Congratulations, Jincheng! On Tue, Feb 25, 2020 at 5:02 PM Chamikara Jayalath wrote: > Congrats Jincheng! > > On Tue, Feb 25, 2020 at 10:14 AM Rui Wang wrote: > >> Congrats! >> >> >> -Rui >> >> On Mon, Feb 24, 2020 at 11:24 PM Austin Bennett < >> whatwouldausti...@gmail.com> wrote: >> >>>

Re: [EXTERNAL] Re: Java Build broken

2020-02-25 Thread Pulasthi Supun Wickramasinghe
Hi Stefan, Yes, I am also still getting this error on my local setup, However, strangely I am not getting this on my laptop. I tried manually installing the missing 'error_prone' dependencies to maven but then go some other error. Might this be some kind of cache issue? Best Regards, Pulasthi

Re: [VOTE] Upgrade gradle to 6.2

2020-02-25 Thread Gleb Kanterov
+1 (non-binding) On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía wrote: > +1 great to have our build updated, please share if there are new > interesting features/plugin advantages we can benefit from too. > > On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré > wrote: > >> Hi Alex >> >> I also

Re: [ANNOUNCE] New committer: Chad Dombrova

2020-02-25 Thread Ismaël Mejía
Congratulations, so well deserved for the lots of amazing work and new perspectives you have broght into the project !!! On Tue, Feb 25, 2020 at 8:24 AM Austin Bennett wrote: > Hooray! > > On Mon, Feb 24, 2020, 11:21 PM Alex Van Boxel wrote: > >> Congrats! >> >> _/ >> _/ Alex Van Boxel >> >>

Re: [VOTE] Upgrade gradle to 6.2

2020-02-25 Thread Ismaël Mejía
+1 great to have our build updated, please share if there are new interesting features/plugin advantages we can benefit from too. On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré wrote: > Hi Alex > > I also have couple of contacts at Gradle. Let me know if needed. > > Regards > JB > > Le

Re: [ANNOUNCE] New committer: Chad Dombrova

2020-02-25 Thread Gleb Kanterov
Congratulations! On Tue, Feb 25, 2020 at 9:44 AM Ismaël Mejía wrote: > Congratulations, so well deserved for the lots of amazing work and new > perspectives you have broght into the project !!! > > On Tue, Feb 25, 2020 at 8:24 AM Austin Bennett < > whatwouldausti...@gmail.com> wrote: > >>

RE: [EXTERNAL] Re: Java Build broken

2020-02-25 Thread Stefan Djelekar
Hi all, No this is not yet fixed. @Pulasthi do you still get the same error? @Maximilian I don’t have any overrides. It looks like on localhost build references https://oss.sonatype.org/content/repositories/staging/com/google/errorprone/error_prone_check_api/2.3.4/ istead of

Re: [ANNOUNCE] New committer: Chad Dombrova

2020-02-25 Thread Jan Lukavský
Congrats Chad! On 2/25/20 9:48 AM, Gleb Kanterov wrote: Congratulations! On Tue, Feb 25, 2020 at 9:44 AM Ismaël Mejía > wrote: Congratulations, so well deserved for the lots of amazing work and new perspectives you have broght into the project !!! On

Re: [ANNOUNCE] New committer: Chad Dombrova

2020-02-25 Thread jincheng sun
Congratulations Chad! Best, Jincheng Jan Lukavský 于2020年2月25日周二 下午5:05写道: > Congrats Chad! > On 2/25/20 9:48 AM, Gleb Kanterov wrote: > > Congratulations! > > On Tue, Feb 25, 2020 at 9:44 AM Ismaël Mejía wrote: > >> Congratulations, so well deserved for the lots of amazing work and new >>

Re: [PROPOSAL] Vendored bytebuddy dependency release

2020-02-25 Thread Ismaël Mejía
It seems we have a clear consensus so I will proceed with the vote. Thanks! On Tue, Feb 25, 2020 at 2:19 AM Kenneth Knowles wrote: > +1 thanks! > > On Mon, Feb 24, 2020 at 1:13 PM Pablo Estrada wrote: > >> +1 >> >> On Sun, Feb 23, 2020 at 8:31 PM Luke Cwik wrote: >> >>> +1 >>> >>> On Sun,

[VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Ismaël Mejía
Please review the release of the following artifacts that we vendor: * beam-vendor-bytebuddy-1_10_8 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments)

Re: SplittableDoFn with Flink fails at checkpointing larger files (200MB)

2020-02-25 Thread Maximilian Michels
Hi Marek, That's a great question. The answer depends on whether you are using portability or the "classic" Runner: Portability === In portability, the SDF functionality includes the option for the Runner to split a given bundle such that the remaining current bundle's work will be