Re: [VOTE] Release 2.26.0, release candidate #1

2020-12-10 Thread Chamikara Jayalath
+1 (non-binding). Validated multi-language pipelines for Kafka/SQL. Thanks, Cham On Thu, Dec 10, 2020 at 8:41 AM Tyson Hamilton wrote: > +1 from me. I validated Nexmark performance tests. > > On Tue, Dec 8, 2020 at 7:53 PM Robert Burke wrote: > >> I'm +1 on RC1 based on the 7 tests I know I

Re: [VOTE] Release 2.26.0, release candidate #1

2020-12-10 Thread Brian Hulette
+1 (non-binding). Ran a Python pipeline using DataframeTransform on DirectRunner and DataflowRunner (woohoo!) On Thu, Dec 10, 2020 at 8:48 AM Chamikara Jayalath wrote: > +1 (non-binding). Validated multi-language pipelines for Kafka/SQL. > > Thanks, > Cham > > On Thu, Dec 10, 2020 at 8:41 AM

Re: [VOTE] Release 2.26.0, release candidate #1

2020-12-10 Thread Robert Bradshaw
+1 (binding). I've verified the release artifacts and signatures, and validated some simple pipelines with a freshly installed wheel. On Thu, Dec 10, 2020 at 10:00 AM Brian Hulette wrote: > +1 (non-binding). Ran a Python pipeline using DataframeTransform on > DirectRunner and DataflowRunner

Re: [VOTE] Release 2.26.0, release candidate #1

2020-12-10 Thread Tyson Hamilton
+1 from me. I validated Nexmark performance tests. On Tue, Dec 8, 2020 at 7:53 PM Robert Burke wrote: > I'm +1 on RC1 based on the 7 tests I know I can check successfully. I'll > be trying more tomorrow, but remember that release validation requires the > community to validate it meets our

Re: Dynamic timers in python sdk.

2020-12-10 Thread Yichi Zhang
Fair enough, I think we can also just extend existing timer API to allow setting a dynamic timer tag field: timer.set(timestamp) -> timer.set(timestamp, dynamic_timer_tag=a_tag) timer.clear() -> timer.clear(dynamic_timer_tag=a_tag) and have the default value of dynamic_timer_tag to be empty (the

Re: Dynamic timers in python sdk.

2020-12-10 Thread Robert Bradshaw
Yep. A slight variant on this is to add separate set_dynamic and clear_dynamic methods, rather than letting set and clear take an optional argument, but I'm not sure I like that as much as the simple extension you proposed. We should also consider whether the default used in set() should be the

Re: Dynamic timers in python sdk.

2020-12-10 Thread Boyuan Zhang
Thanks for the explanation! That makes sense. We may also want to update pydoc to state the usage explicitly since it's quite different from how Java SDK does it. On Thu, Dec 10, 2020 at 11:13 AM Robert Bradshaw wrote: > On Thu, Dec 10, 2020 at 11:05 AM Boyuan Zhang wrote: > >> We should also

Re: Dynamic timers in python sdk.

2020-12-10 Thread Robert Bradshaw
On Thu, Dec 10, 2020 at 11:05 AM Boyuan Zhang wrote: > We should also consider whether the default used in set() should be the >> empty string, or some value completely disjoint from any other string. (I'd >> lean towards the latter.) > > From API layer, the default value could be None for

Re: Dynamic timers in python sdk.

2020-12-10 Thread Boyuan Zhang
> > We should also consider whether the default used in set() should be the > empty string, or some value completely disjoint from any other string. (I'd > lean towards the latter.) >From API layer, the default value could be None for non-dynamic timer. When translating to timer data message,

Re: [VOTE] Release 2.26.0, release candidate #1

2020-12-10 Thread Robert Burke
Hello All! The minimum vote time has elapsed with six +1 votes, two of which are binding, which is not enough for me to start finalization processes. I'm happy to extend the period until the sooner of the 2.27.0 branch is cut and it's first RC is built (sometime on/after the 16th according to the

Re: Docker Development Environment

2020-12-10 Thread Alex Kosolapov
Hi Brian, Yes - will update the script, created JIRA to track https://issues.apache.org/jira/browse/BEAM-11438 I was thinking about dscl initially too - and dscl will require user to create docker group in this case as you noted. For some users that might be an extra manual step to do (group

Re: [VOTE] Release 2.26.0, release candidate #1

2020-12-10 Thread Pablo Estrada
+1 (binding) I've built and ran basic tests for existing Dataflow templates. Best -P. On Thu, Dec 10, 2020 at 11:31 AM Robert Bradshaw wrote: > +1 (binding). I've verified the release artifacts and signatures, and > validated some simple pipelines with a freshly installed wheel. > > On Thu, Dec