Re: [PROPOSAL] Vendored bytebuddy dependency release

2020-02-22 Thread Kai Jiang
+1 On Sat, Feb 22, 2020 at 09:50 Alex Van Boxel wrote: > +1 > > _/ > > _/ Alex Van Boxel > > > On Sat, Feb 22, 2020 at 5:45 PM Jean-Baptiste Onofré > wrote: > >> +1 >> >> Regards >> JB >> >> Le sam. 22 f?vr. 2020 ? 15:02, Isma?l Mej?a a ?crit : >> >>> The version of bytebuddy Beam is

Re: [PROPOSAL] Vendored bytebuddy dependency release

2020-02-22 Thread Alex Van Boxel
+1 _/ _/ Alex Van Boxel On Sat, Feb 22, 2020 at 5:45 PM Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > Le sam. 22 f?vr. 2020 ? 15:02, Isma?l Mej?a a ?crit : > >> The version of bytebuddy Beam is vendoring (1.9.3) is more than 16 months >> old. I >> would like to propose that we

Re: [PROPOSAL] Vendored bytebuddy dependency release

2020-02-22 Thread Jean-Baptiste Onofré
+1RegardsJBLe sam. 22 f?vr. 2020 ? 15:02, Isma?l Mej?a a ?crit :The version of bytebuddy Beam is vendoring (1.9.3) is more than 16 months old. Iwould like to propose that we upgrade it [1] to the most recent version (1.10.8)[2] so we can benefit of the latest improvements for Java 11 and upgraded

[PROPOSAL] Vendored bytebuddy dependency release

2020-02-22 Thread Ismaël Mejía
The version of bytebuddy Beam is vendoring (1.9.3) is more than 16 months old. I would like to propose that we upgrade it [1] to the most recent version (1.10.8) [2] so we can benefit of the latest improvements for Java 11 and upgraded ASM. If everyone agrees I would like to volunteer as the

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-22 Thread Ismaël Mejía
+1 (binding) Verified signatures, produced jar from code and checked that artifact does not contain both Main.class and module-info.classes Thanks for taking care of this Tomo and Luke. On Sat, Feb 22, 2020 at 10:27 AM jincheng sun wrote: > +1(non-binding) > > Best, > Jincheng > > > Kai

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-22 Thread jincheng sun
+1(non-binding) Best, Jincheng Kai Jiang 于2020年2月22日周六 下午2:58写道: > +1 (non-binding) > > On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu wrote: > >> +1 (verified) >> >> On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw >> wrote: >> >>> +1 (binding) >>> >>> >>> On Fri, Feb 21, 2020 at 4:48 PM Ahmet

Re: Schema Convert transform fails on type metadata

2020-02-22 Thread Jozef Vilcek
Will do! Thanks Alex. On Sat, Feb 22, 2020 at 9:23 AM Alex Van Boxel wrote: > I've assigned it too you. If you create a PR you can add me as reviewer. > > _/ > _/ Alex Van Boxel > > > On Sat, Feb 22, 2020 at 9:14 AM Jozef Vilcek > wrote: > >> I have filed

Re: Schema Convert transform fails on type metadata

2020-02-22 Thread Alex Van Boxel
I've assigned it too you. If you create a PR you can add me as reviewer. _/ _/ Alex Van Boxel On Sat, Feb 22, 2020 at 9:14 AM Jozef Vilcek wrote: > I have filed https://issues.apache.org/jira/browse/BEAM-9360 for this. > > Seems like I am not able to self assign this, can I get rights to do

Re: Schema Convert transform fails on type metadata

2020-02-22 Thread Jozef Vilcek
I have filed https://issues.apache.org/jira/browse/BEAM-9360 for this. Seems like I am not able to self assign this, can I get rights to do that or get someone assign JIRA to me please? On Sat, Feb 22, 2020 at 2:41 AM Reuven Lax wrote: > I think that it's incorrect - we shouldn't enforce that