Re: [VOTE] Release 2.24.0, release candidate #1

2020-09-01 Thread Daniel Oliveira
Ack, I'll rebuild the artifacts for RC2 with JDK 8 and open a new vote. This vote is closed. On Tue, Sep 1, 2020 at 1:00 PM Ismaël Mejía wrote: > -1 > > We should rebuild the artifacts with a Java 8 compiler as Robert suggested. > > We have a set of 'forward compatibility' tests for new

Re: Could someone review my pull request 12695 ?

2020-09-01 Thread terry xian
As nielm pointed out in his comment of my PR, I added this because  "spanner API change that exposes Guava classes is: googleapis/java-spanner/pull/81, Specifically, adding AsyncResultSet in  googleapis/java-spanner/pull/81/files#diff-7a9cb34faeb259be46b44f1878b7210f which returns an

Re: Could someone review my pull request 12695 ?

2020-09-01 Thread Chamikara Jayalath
BTW this PR adds the following to the API surface. (com.google.common.collect.ImmutableCollection.class), (com.google.common.collect.ImmutableCollection.Builder.class), (com.google.common.collect.ImmutableList.class), (com.google.common.collect.ImmutableList.Builder.class),

Could someone review my pull request 12695 ?

2020-09-01 Thread terry xian
Hi,  My pull request [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0 by terryxian78 · Pull Request #12695 · apache/beam  was there for more than 3 days. Although I've added a reviewer (lukecwik), I am afraid that I missed something which might

Re: [VOTE] Release 2.24.0, release candidate #1

2020-09-01 Thread Ismaël Mejía
-1 We should rebuild the artifacts with a Java 8 compiler as Robert suggested. We have a set of 'forward compatibility' tests for new releases of Beam at Talend. When i updated the tests to use the 2.24.0 RC1 artifacts I got this exception: 2020-09-01T08:19:46.7681646Z [0m [91mSep 01, 2020

Re: [VOTE] Release 2.24.0, release candidate #1

2020-09-01 Thread Robert Bradshaw
On Tue, Sep 1, 2020 at 10:41 AM Daniel Oliveira wrote: > > I should probably call out that Dataflow containers aren't built yet (I will > be building them today), so testing of Dataflow should probably wait until > tomorrow. > > > If Java 11 was used to build the release artifacts, does this

Re: [VOTE] Release 2.24.0, release candidate #1

2020-09-01 Thread Daniel Oliveira
I should probably call out that Dataflow containers aren't built yet (I will be building them today), so testing of Dataflow should probably wait until tomorrow. > If Java 11 was used to build the release artifacts, does this create any backwards-compatibility challenges for Java 8 users? It's

Re: KinesisIO - aggregation

2020-09-01 Thread Alexey Romanenko
Hello Mani, For Write part it should be already supported since KinesisIO uses KPL to write records under the hood. So, it’s just a question of proper configuration [1][2][3] For Read part, since it’s based on AWS API, it’s more complicated and we need to add a support for this explicitly.

Re: BEAM-9330

2020-09-01 Thread Alexey Romanenko
Hi Cristian, Great to see that you want to contribute to Beam. I’m not sure that I’ll have a time for pair-programming but feel free to ask me any questions about Java/Beam development on ASF slack channel or by email. > On 29 Aug 2020, at 06:11, Cristian Constantinescu wrote: > > Hello, >

Re: Contributor permission for Beam Jira tickets

2020-09-01 Thread Alexey Romanenko
Hi Omkar, Thank you for working on this. As I can see, you are already in Jira Contributors list and you can assign Jira tasks to you. Though, actually the Jira that you worked on, is already resolved since your PR was merged yesterday. > On 28 Aug 2020, at 03:00, Deshpande, Omkar wrote: >