It looks good to me, I'm merging and moving forward.
Regards
JB
On 14/06/2018 00:45, Pablo Estrada wrote:
> Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky
> test. As JB is the release manager, I'l let him make the call on what to
> do about it.
> Best
> -P.
>
> On Wed, Jun
FWIW I have a fix to the flaky test in
https://github.com/apache/beam/pull/5585 (open)
On Wed, Jun 13, 2018 at 5:26 PM Udi Meiri wrote:
> +1 to ignoring flaky test.
>
> FYI there's a fourth cherrypick: https://github.com/apache/beam/pull/5624
>
> On Wed, Jun 13, 2018 at 3:45 PM Pablo Estrada wr
+1 to ignoring flaky test.
FYI there's a fourth cherrypick: https://github.com/apache/beam/pull/5624
On Wed, Jun 13, 2018 at 3:45 PM Pablo Estrada wrote:
> Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky
> test. As JB is the release manager, I'l let him make the call on wh
Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky test.
As JB is the release manager, I'l let him make the call on what to do about
it.
Best
-P.
On Wed, Jun 13, 2018 at 3:34 PM Ahmet Altay wrote:
> I would vote for second option, not a release blocker and disable the test
> i
I would vote for second option, not a release blocker and disable the test
in the release branch. My reasoning is:
- ReferenceRunner is not yet the official alternative to existing direct
runners.
- It is bad to have flaky tests on the release branch, and we would not get
good signal during validat
Hello all,
cherrypicks for the release branch seem to be going well, but thanks to
them we were able to surface a flaky test in the release branch. JIRA is
filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558
Given that test issue, I see the following options:
- Consider that this
Hey all,
Currently we have 3 PRs supposed to be cherrypicked into RC2:
Pablo: https://github.com/apache/beam/pull/5609 (merged)
Udi: https://github.com/apache/beam/pull/5607 (open)
Charles: https://github.com/apache/beam/pull/5636 (open)
Boyuan
On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada wr
Precommits for PR https://github.com/apache/beam/pull/5609 are now passing.
For now I've simply set failOnWarning to false to cherrypick into the
release, and fix in master later on.
Best
-P.
On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner wrote:
> From my understanding, the @SuppressFBWarnings usa
>From my understanding, the @SuppressFBWarnings usage is in a dependency
(ByteBuddy) rather than directly in our code; so we're not able to modify
the usage.
Pablo, feel free to disable failOnWarning for the sdks-java-core project
temporarily. This isn't a major regression since we've only recentl
Hi Pablo,
I'm afraid I couldn't find one either... there is an issue about it [1]
which is old so it doesn't look likely to be resolved either.
If you have time (sorry I am a bit busy) could you please verify the
version does work if you install that version locally? I know the maven
version of t
Hi Tim,
you're right. Thanks for pointing that out. There's just one problem that
I'm running into now: The 3.0.1-1 version does not seem to be available in
Maven Central[1]. Looking at the website, I am not quite sure if there's
another repository where they do stage the newer versions?[2]
-P
[1
Hi Pablo,
I took only a quick look.
"- The JAR from the non-LGPL findbugs does not contain the
SuppressFBWarnings annotation"
Unless I misunderstand you it looks like SuppressFBWarnings was added in
Stephen's version in this commit [1] which was introduced in version
2.0.3-1 - I've checked is i
Hi all,
I'll humbly declare that after wrestling with he build to stop depending on
the wrong findbugs_annotations, I feel somewhat lost. The issue is actually
quite small:
- The JAR from the non-LGPL findbugs does not contain the
SuppressFBWarnings annotation. This means that when building, ByteB
Yes, ok I was not aware it was already being addressed, nice.
On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay wrote:
>
> Ismaël,
>
> I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing the
> issue by changing the findbugs back to "com.github.stephenc.findbugs". Is
> this what you a
Ismaël,
I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing the
issue by changing the findbugs back to "com.github.stephenc.findbugs". Is
this what you are referring to?
Ahmet
On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang wrote:
> Hey JB,
>
> I added some instructions about ho
Hey JB,
I added some instructions about how to create python wheels in this PR:
https://github.com/apache/beam-site/pull/467 . Hope it would be helpful.
Boyuan
On Tue, Jun 12, 2018 at 12:33 PM Jean-Baptiste Onofré
wrote:
> Hi all,
>
> due to issues found by Udi and Pablo, I cancel RC1 to prepa
There is another issue highlighted by Scott Wegner in a non-related to
the vote PR discussion.
https://github.com/apache/beam/pull/5540
It seems that in the migration to gradle we changed the
findbugs-annotations library from com.github.stephenc.findbugs to
com.google.code.findbugs:findbugs-annota
Hi all,
due to issues found by Udi and Pablo, I cancel RC1 to prepare a new release.
Thanks Udi and Pablo for catching up.
I will prepare a RC2 after cherry pick/fixed the found issues (tomorrow
morning my time).
Regards
JB
On 12/06/2018 21:04, Pablo Estrada wrote:
> Hello all,
> I've found a
18 matches
Mail list logo
