I agree with Romain.
Further more, after have worked on the Gradle build last week, I saw some
difference between the actions performed by the Maven and Gradle builds.
For instance, Nextmark build is not equivalent between Maven and Gradle.
I think we should align both or at least agree about
@Lukasz: there was a vote on gradle and I think it won with the condition
there is a dryrun release to validate the external visibility of the
project. If this thread passes you will hit the same blocker normally. My
point was not "dont move" but "if you want to move, please make it fast or
dont ma
+1 to insisting on equivalent test coverage
On Dec 15, 2017 4:23 PM, "Lukasz Cwik" wrote:
> Might as well as make it explicit and add:
> * the test coverage is the same or better
>
> On Fri, Dec 15, 2017 at 1:54 PM, Robert Bradshaw
> wrote:
>
>> +1 to these being minimal criteria. (I assume the
Might as well as make it explicit and add:
* the test coverage is the same or better
On Fri, Dec 15, 2017 at 1:54 PM, Robert Bradshaw
wrote:
> +1 to these being minimal criteria. (I assume there's an implicit "the
> coverage is the same or better" as well?)
>
> On Fri, Dec 15, 2017 at 12:37 PM,
+1 to these being minimal criteria. (I assume there's an implicit "the
coverage is the same or better" as well?)
On Fri, Dec 15, 2017 at 12:37 PM, Lukasz Cwik wrote:
> Romain, choosing the criteria is about setting the minimum expectations and
> your welcome to suggest alternative criteria.
> Eve
Romain, choosing the criteria is about setting the minimum expectations and
your welcome to suggest alternative criteria.
Even though the criteria is the minimum expectations we can see that the
Gradle build has averaged 130 mins while the maven build has averaged 201
mins for the Java pre-commit.
If it is the ~same Im not sure i see the point to move but please dont keep
gradle and mvn in master - more than jenkins ;). It makes it hard to follow
the project and do prs.
Le 15 déc. 2017 20:42, "Lukasz Cwik" a écrit :
> I'm proposing that the criteria to remove a PreCommit/PostCommit runnin
I'm proposing that the criteria to remove a PreCommit/PostCommit running in
Jenkins via Maven is that and any Maven based configuration supporting the
execution:
* The pass rate of the Jenkins job via Gradle is the same or better then
Maven over the past 7 days.
* The average execution time via Gra
