Re: [VOTE] Code Review Process

2018-06-04 Thread Griselda Cuevas 
+1

On Mon, 4 Jun 2018 at 12:30, Robert Burke  wrote:

> +1
>
> On Mon, Jun 4, 2018, 9:01 AM Raghu Angadi  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer Load for
>>> Code Reviews"[1], this is a vote to change the Beam policy on Code Reviews
>>> to require that
>>>
>>> (1) At least one committer is involved with the code review, as either a
>>> reviewer or as the author
>>> (2) A contributor has approved the change
>>>
>>> prior to merging any change.
>>>
>>> This changes our policy from its current requirement that at least one
>>> committer *who is not the author* has approved the change prior to merging.
>>> We believe that changing this process will improve code review throughput,
>>> reduce committer load, and engage more of the community in the code review
>>> process.
>>>
>>> Please vote:
>>> [ ] +1: Accept the above proposal to change the Beam code review/merge
>>> policy
>>> [ ] -1: Leave the Code Review policy unchanged
>>>
>>> Thanks,
>>>
>>> Thomas
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>>
>>

Re: [VOTE] Code Review Process

2018-06-04 Thread Robert Burke 
+1

On Mon, Jun 4, 2018, 9:01 AM Raghu Angadi  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>
>> As we seem to largely have consensus in "Reducing Committer Load for Code
>> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
>> require that
>>
>> (1) At least one committer is involved with the code review, as either a
>> reviewer or as the author
>> (2) A contributor has approved the change
>>
>> prior to merging any change.
>>
>> This changes our policy from its current requirement that at least one
>> committer *who is not the author* has approved the change prior to merging.
>> We believe that changing this process will improve code review throughput,
>> reduce committer load, and engage more of the community in the code review
>> process.
>>
>> Please vote:
>> [ ] +1: Accept the above proposal to change the Beam code review/merge
>> policy
>> [ ] -1: Leave the Code Review policy unchanged
>>
>> Thanks,
>>
>> Thomas
>>
>> [1]
>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>
>

Re: [VOTE] Code Review Process

2018-06-04 Thread Raghu Angadi 
+1

On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:

> As we seem to largely have consensus in "Reducing Committer Load for Code
> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
> require that
>
> (1) At least one committer is involved with the code review, as either a
> reviewer or as the author
> (2) A contributor has approved the change
>
> prior to merging any change.
>
> This changes our policy from its current requirement that at least one
> committer *who is not the author* has approved the change prior to merging.
> We believe that changing this process will improve code review throughput,
> reduce committer load, and engage more of the community in the code review
> process.
>
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code review/merge
> policy
> [ ] -1: Leave the Code Review policy unchanged
>
> Thanks,
>
> Thomas
>
> [1]
> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>

Re: [VOTE] Code Review Process

2018-06-04 Thread Jean-Baptiste Onofré 
+1

I think it's already pretty close to what we do, so, no brainer ;)

Regards
JB

On 01/06/2018 19:25, Thomas Groh wrote:
> As we seem to largely have consensus in "Reducing Committer Load for
> Code Reviews"[1], this is a vote to change the Beam policy on Code
> Reviews to require that
> 
> (1) At least one committer is involved with the code review, as either a
> reviewer or as the author
> (2) A contributor has approved the change
> 
> prior to merging any change.
> 
> This changes our policy from its current requirement that at least one
> committer *who is not the author* has approved the change prior to
> merging. We believe that changing this process will improve code review
> throughput, reduce committer load, and engage more of the community in
> the code review process.
> 
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code review/merge
> policy
> [ ] -1: Leave the Code Review policy unchanged
> 
> Thanks,
> 
> Thomas
> 
> [1] 
> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: [VOTE] Code Review Process

2018-06-04 Thread Reuven Lax 
+1

On Mon, Jun 4, 2018 at 11:40 AM Łukasz Gajowy 
wrote:

> +1
>
> 2018-06-04 9:12 GMT+02:00 Etienne Chauchot :
>
>> +1
>> As I was already applying this.
>>
>> Le samedi 02 juin 2018 à 11:24 +0300, Reuven Lax a écrit :
>>
>> +1
>>
>> I believe only some committers were aware of the old policy, and others
>> were effectively doing this anyway.
>>
>> On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada  wrote:
>>
>> +1 :) glad that we had this discussion
>>
>> On Fri, Jun 1, 2018, 3:38 PM Udi Meiri  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud 
>> wrote:
>>
>> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
>> having enough committers.
>>
>> On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin  wrote:
>>
>> +1 -- this is encoding what I previously thought the process was and
>> what, in practice, I think was often the behavior of committers anyway.
>>
>> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
>> wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
>> wrote:
>>
>> +1
>>
>> Thanks,
>> Cham
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
>> wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
>> wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:
>>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>>
>> As we seem to largely have consensus in "Reducing Committer Load for Code
>> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
>> require that
>>
>> (1) At least one committer is involved with the code review, as either a
>> reviewer or as the author
>> (2) A contributor has approved the change
>>
>> prior to merging any change.
>>
>> This changes our policy from its current requirement that at least one
>> committer *who is not the author* has approved the change prior to merging.
>> We believe that changing this process will improve code review throughput,
>> reduce committer load, and engage more of the community in the code review
>> process.
>>
>> Please vote:
>> [ ] +1: Accept the above proposal to change the Beam code review/merge
>> policy
>> [ ] -1: Leave the Code Review policy unchanged
>>
>> Thanks,
>>
>> Thomas
>>
>> [1]
>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>
>>
>>
>>
>>
>>
>

Re: [VOTE] Code Review Process

2018-06-04 Thread Łukasz Gajowy 
+1

2018-06-04 9:12 GMT+02:00 Etienne Chauchot :

> +1
> As I was already applying this.
>
> Le samedi 02 juin 2018 à 11:24 +0300, Reuven Lax a écrit :
>
> +1
>
> I believe only some committers were aware of the old policy, and others
> were effectively doing this anyway.
>
> On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada  wrote:
>
> +1 :) glad that we had this discussion
>
> On Fri, Jun 1, 2018, 3:38 PM Udi Meiri  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud  wrote:
>
> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
> having enough committers.
>
> On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin  wrote:
>
> +1 -- this is encoding what I previously thought the process was and what,
> in practice, I think was often the behavior of committers anyway.
>
> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
> wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
> wrote:
>
> +1
>
> Thanks,
> Cham
>
> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
> wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
> wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:
>
> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>
> As we seem to largely have consensus in "Reducing Committer Load for Code
> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
> require that
>
> (1) At least one committer is involved with the code review, as either a
> reviewer or as the author
> (2) A contributor has approved the change
>
> prior to merging any change.
>
> This changes our policy from its current requirement that at least one
> committer *who is not the author* has approved the change prior to merging.
> We believe that changing this process will improve code review throughput,
> reduce committer load, and engage more of the community in the code review
> process.
>
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code review/merge
> policy
> [ ] -1: Leave the Code Review policy unchanged
>
> Thanks,
>
> Thomas
>
> [1] https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9
> a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>
>
>
>
>
>

Re: [VOTE] Code Review Process

2018-06-04 Thread Etienne Chauchot 
+1As I was already applying this.
Le samedi 02 juin 2018 à 11:24 +0300, Reuven Lax a écrit :
> +1
> 
> I believe only some committers were aware of the old policy, and others were 
> effectively doing this anyway.
> 
> On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner  wrote:
> > +1
> > 
> > On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada  wrote:
> > > +1 :) glad that we had this discussion
> > > 
> > > On Fri, Jun 1, 2018, 3:38 PM Udi Meiri  wrote:
> > > > +1
> > > > 
> > > > On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud  
> > > > wrote:
> > > > > +1 - I hope this doesn't reduce the urgency to fix the root cause: 
> > > > > not having enough committers.
> > > > > 
> > > > > On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde  
> > > > > wrote:
> > > > > > +1
> > > > > > 
> > > > > > On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin  
> > > > > > wrote:
> > > > > > > +1 -- this is encoding what I previously thought the process was 
> > > > > > > and what, in practice, I think was often
> > > > > > > the behavior of committers anyway.
> > > > > > > On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  
> > > > > > > wrote:
> > > > > > > > +1
> > > > > > > > 
> > > > > > > > On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
> > > > > > > >  wrote:
> > > > > > > > > +1
> > > > > > > > > 
> > > > > > > > > On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
> > > > > > > > >  wrote:
> > > > > > > > > > +1
> > > > > > > > > > 
> > > > > > > > > > Thanks,
> > > > > > > > > > Cham
> > > > > > > > > > 
> > > > > > > > > > On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
> > > > > > > > > >  wrote:
> > > > > > > > > > > +1
> > > > > > > > > > > 
> > > > > > > > > > > On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka 
> > > > > > > > > > >  wrote:
> > > > > > > > > > > > +1
> > > > > > > > > > > > 
> > > > > > > > > > > > On Fri, Jun 1, 2018 at 11:28 AM Charles Chen 
> > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > +1
> > > > > > > > > > > > > 
> > > > > > > > > > > > > On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
> > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > > +1
> > > > > > > > > > > > > > On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
> > > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > > > +1
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
> > > > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > > > > +1
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
> > > > > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > > > > > As we seem to largely have consensus in 
> > > > > > > > > > > > > > > > > "Reducing Committer Load for Code Reviews"[1],
> > > > > > > > > > > > > > > > > this is a vote to change the Beam policy on 
> > > > > > > > > > > > > > > > > Code Reviews to require that
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > (1) At least one committer is involved with 
> > > > > > > > > > > > > > > > > the code review, as either a reviewer or
> > > > > > > > > > > > > > > > > as the author
> > > > > > > > > > > > > > > > > (2) A contributor has approved the change
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > prior to merging any change.
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > This changes our policy from its current 
> > > > > > > > > > > > > > > > > requirement that at least one committer *who
> > > > > > > > > > > > > > > > > is not the author* has approved the change 
> > > > > > > > > > > > > > > > > prior to merging. We believe that changing
> > > > > > > > > > > > > > > > > this process will improve code review 
> > > > > > > > > > > > > > > > > throughput, reduce committer load, and engage
> > > > > > > > > > > > > > > > > more of the community in the code review 
> > > > > > > > > > > > > > > > > process.
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > Please vote:
> > > > > > > > > > > > > > > > > [ ] +1: Accept the above proposal to change 
> > > > > > > > > > > > > > > > > the Beam code review/merge policy
> > > > > > > > > > > > > > > > > [ ] -1: Leave the Code Review policy unchanged
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > Thanks,
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > Thomas
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > [1] 
> > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f38165
> > > > > > > > > > > > > > > > > 4aa3e47df18@%3Cdev.beam.apache.org%3E
> > > > > > > > > > > 
> > > > > > > > > > >

Re: [VOTE] Code Review Process

2018-06-02 Thread Reuven Lax 
+1

I believe only some committers were aware of the old policy, and others
were effectively doing this anyway.

On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada  wrote:
>
>> +1 :) glad that we had this discussion
>>
>> On Fri, Jun 1, 2018, 3:38 PM Udi Meiri  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud 
>>> wrote:
>>>
 +1 - I hope this doesn't reduce the urgency to fix the root cause: not
 having enough committers.

 On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin 
> wrote:
>
>> +1 -- this is encoding what I previously thought the process was and
>> what, in practice, I think was often the behavior of committers anyway.
>>
>> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath <
 chamik...@google.com> wrote:

> +1
>
> Thanks,
> Cham
>
> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster <
> jasonkus...@google.com> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
 valen...@google.com> wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  > wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles <
>> k...@google.com> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh <
>>> tg...@apache.org> wrote:
>>>
 As we seem to largely have consensus in "Reducing Committer
 Load for Code Reviews"[1], this is a vote to change the Beam 
 policy on Code
 Reviews to require that

 (1) At least one committer is involved with the code
 review, as either a reviewer or as the author
 (2) A contributor has approved the change

 prior to merging any change.

 This changes our policy from its current requirement that
 at least one committer *who is not the author* has approved 
 the change
 prior to merging. We believe that changing this process will 
 improve code
 review throughput, reduce committer load, and engage more of 
 the community
 in the code review process.

 Please vote:
 [ ] +1: Accept the above proposal to change the Beam code
 review/merge policy
 [ ] -1: Leave the Code Review policy unchanged

 Thanks,

 Thomas

 [1]
 https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E

>>>
>>
>
>>
>> --
>> ---
>> Jason Kuster
>> Apache Beam / Google Cloud Dataflow
>>
>> See something? Say something. go/jasonkuster-feedback
>> 
>>
>
>> --
>> Got feedback? go/pabloem-feedback
>> 
>>
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Scott Wegner 
+1

On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada  wrote:

> +1 :) glad that we had this discussion
>
> On Fri, Jun 1, 2018, 3:38 PM Udi Meiri  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud 
>> wrote:
>>
>>> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
>>> having enough committers.
>>>
>>> On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin 
 wrote:

> +1 -- this is encoding what I previously thought the process was and
> what, in practice, I think was often the behavior of committers anyway.
>
> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath <
>>> chamik...@google.com> wrote:
>>>
 +1

 Thanks,
 Cham

 On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster <
 jasonkus...@google.com> wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
>>> valen...@google.com> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles <
> k...@google.com> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
>> wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer
>>> Load for Code Reviews"[1], this is a vote to change the Beam 
>>> policy on Code
>>> Reviews to require that
>>>
>>> (1) At least one committer is involved with the code review,
>>> as either a reviewer or as the author
>>> (2) A contributor has approved the change
>>>
>>> prior to merging any change.
>>>
>>> This changes our policy from its current requirement that at
>>> least one committer *who is not the author* has approved the 
>>> change prior
>>> to merging. We believe that changing this process will improve 
>>> code review
>>> throughput, reduce committer load, and engage more of the 
>>> community in the
>>> code review process.
>>>
>>> Please vote:
>>> [ ] +1: Accept the above proposal to change the Beam code
>>> review/merge policy
>>> [ ] -1: Leave the Code Review policy unchanged
>>>
>>> Thanks,
>>>
>>> Thomas
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>>
>>
>

>
> --
> ---
> Jason Kuster
> Apache Beam / Google Cloud Dataflow
>
> See something? Say something. go/jasonkuster-feedback
> 
>

> --
> Got feedback? go/pabloem-feedback
> 
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Pablo Estrada 
+1 :) glad that we had this discussion

On Fri, Jun 1, 2018, 3:38 PM Udi Meiri  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud  wrote:
>
>> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
>> having enough committers.
>>
>> On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin 
>>> wrote:
>>>
 +1 -- this is encoding what I previously thought the process was and
 what, in practice, I think was often the behavior of committers anyway.

 On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath <
>> chamik...@google.com> wrote:
>>
>>> +1
>>>
>>> Thanks,
>>> Cham
>>>
>>> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
>> valen...@google.com> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles <
 k...@google.com> wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
> wrote:
>
>> As we seem to largely have consensus in "Reducing Committer
>> Load for Code Reviews"[1], this is a vote to change the Beam 
>> policy on Code
>> Reviews to require that
>>
>> (1) At least one committer is involved with the code review,
>> as either a reviewer or as the author
>> (2) A contributor has approved the change
>>
>> prior to merging any change.
>>
>> This changes our policy from its current requirement that at
>> least one committer *who is not the author* has approved the 
>> change prior
>> to merging. We believe that changing this process will improve 
>> code review
>> throughput, reduce committer load, and engage more of the 
>> community in the
>> code review process.
>>
>> Please vote:
>> [ ] +1: Accept the above proposal to change the Beam code
>> review/merge policy
>> [ ] -1: Leave the Code Review policy unchanged
>>
>> Thanks,
>>
>> Thomas
>>
>> [1]
>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>
>

>>>

 --
 ---
 Jason Kuster
 Apache Beam / Google Cloud Dataflow

 See something? Say something. go/jasonkuster-feedback
 

>>>
 --
Got feedback? go/pabloem-feedback

Re: [VOTE] Code Review Process

2018-06-01 Thread Andrew Pilloud 
+1 - I hope this doesn't reduce the urgency to fix the root cause: not
having enough committers.

On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin  wrote:
>
>> +1 -- this is encoding what I previously thought the process was and
>> what, in practice, I think was often the behavior of committers anyway.
>>
>> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath <
 chamik...@google.com> wrote:

> +1
>
> Thanks,
> Cham
>
> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
 valen...@google.com> wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
>>> wrote:
>>>
 As we seem to largely have consensus in "Reducing Committer
 Load for Code Reviews"[1], this is a vote to change the Beam 
 policy on Code
 Reviews to require that

 (1) At least one committer is involved with the code review, as
 either a reviewer or as the author
 (2) A contributor has approved the change

 prior to merging any change.

 This changes our policy from its current requirement that at
 least one committer *who is not the author* has approved the 
 change prior
 to merging. We believe that changing this process will improve 
 code review
 throughput, reduce committer load, and engage more of the 
 community in the
 code review process.

 Please vote:
 [ ] +1: Accept the above proposal to change the Beam code
 review/merge policy
 [ ] -1: Leave the Code Review policy unchanged

 Thanks,

 Thomas

 [1]
 https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E

>>>
>>
>
>>
>> --
>> ---
>> Jason Kuster
>> Apache Beam / Google Cloud Dataflow
>>
>> See something? Say something. go/jasonkuster-feedback
>> 
>>
>
>>

Re: [VOTE] Code Review Process

2018-06-01 Thread Henning Rohde 
+1

On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin  wrote:

> +1 -- this is encoding what I previously thought the process was and what,
> in practice, I think was often the behavior of committers anyway.
>
> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
>>> wrote:
>>>
 +1

 Thanks,
 Cham

 On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
>>> valen...@google.com> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
>> wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer Load
>>> for Code Reviews"[1], this is a vote to change the Beam policy on 
>>> Code
>>> Reviews to require that
>>>
>>> (1) At least one committer is involved with the code review, as
>>> either a reviewer or as the author
>>> (2) A contributor has approved the change
>>>
>>> prior to merging any change.
>>>
>>> This changes our policy from its current requirement that at
>>> least one committer *who is not the author* has approved the change 
>>> prior
>>> to merging. We believe that changing this process will improve code 
>>> review
>>> throughput, reduce committer load, and engage more of the community 
>>> in the
>>> code review process.
>>>
>>> Please vote:
>>> [ ] +1: Accept the above proposal to change the Beam code
>>> review/merge policy
>>> [ ] -1: Leave the Code Review policy unchanged
>>>
>>> Thanks,
>>>
>>> Thomas
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>>
>>
>

>
> --
> ---
> Jason Kuster
> Apache Beam / Google Cloud Dataflow
>
> See something? Say something. go/jasonkuster-feedback
> 
>

>

Re: [VOTE] Code Review Process

2018-06-01 Thread Dan Halperin 
+1 -- this is encoding what I previously thought the process was and what,
in practice, I think was often the behavior of committers anyway.

On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
>> wrote:
>>
>>> +1
>>>
>>> Thanks,
>>> Cham
>>>
>>> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
>> valen...@google.com> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
> wrote:
>
>> As we seem to largely have consensus in "Reducing Committer Load
>> for Code Reviews"[1], this is a vote to change the Beam policy on 
>> Code
>> Reviews to require that
>>
>> (1) At least one committer is involved with the code review, as
>> either a reviewer or as the author
>> (2) A contributor has approved the change
>>
>> prior to merging any change.
>>
>> This changes our policy from its current requirement that at
>> least one committer *who is not the author* has approved the change 
>> prior
>> to merging. We believe that changing this process will improve code 
>> review
>> throughput, reduce committer load, and engage more of the community 
>> in the
>> code review process.
>>
>> Please vote:
>> [ ] +1: Accept the above proposal to change the Beam code
>> review/merge policy
>> [ ] -1: Leave the Code Review policy unchanged
>>
>> Thanks,
>>
>> Thomas
>>
>> [1] https://lists.apache.org/thread.html/7c1fde3884fbefacc25
>> 2b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>
>

>>>

 --
 ---
 Jason Kuster
 Apache Beam / Google Cloud Dataflow

 See something? Say something. go/jasonkuster-feedback
 

>>>

Re: [VOTE] Code Review Process

2018-06-01 Thread Yifan Zou 
+1

On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
> wrote:
>
>> +1
>>
>> Thanks,
>> Cham
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
> valen...@google.com> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
 wrote:

> As we seem to largely have consensus in "Reducing Committer Load
> for Code Reviews"[1], this is a vote to change the Beam policy on Code
> Reviews to require that
>
> (1) At least one committer is involved with the code review, as
> either a reviewer or as the author
> (2) A contributor has approved the change
>
> prior to merging any change.
>
> This changes our policy from its current requirement that at least
> one committer *who is not the author* has approved the change prior to
> merging. We believe that changing this process will improve code 
> review
> throughput, reduce committer load, and engage more of the community 
> in the
> code review process.
>
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code
> review/merge policy
> [ ] -1: Leave the Code Review policy unchanged
>
> Thanks,
>
> Thomas
>
> [1]
> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>

>>>
>>
>>>
>>> --
>>> ---
>>> Jason Kuster
>>> Apache Beam / Google Cloud Dataflow
>>>
>>> See something? Say something. go/jasonkuster-feedback
>>> 
>>>
>>

Re: [VOTE] Code Review Process

2018-06-01 Thread Robert Bradshaw 
+1

On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath 
wrote:

> +1
>
> Thanks,
> Cham
>
> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <
 valen...@google.com> wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh 
>>> wrote:
>>>
 As we seem to largely have consensus in "Reducing Committer Load
 for Code Reviews"[1], this is a vote to change the Beam policy on Code
 Reviews to require that

 (1) At least one committer is involved with the code review, as
 either a reviewer or as the author
 (2) A contributor has approved the change

 prior to merging any change.

 This changes our policy from its current requirement that at least
 one committer *who is not the author* has approved the change prior to
 merging. We believe that changing this process will improve code review
 throughput, reduce committer load, and engage more of the community in 
 the
 code review process.

 Please vote:
 [ ] +1: Accept the above proposal to change the Beam code
 review/merge policy
 [ ] -1: Leave the Code Review policy unchanged

 Thanks,

 Thomas

 [1]
 https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E

>>>
>>
>
>>
>> --
>> ---
>> Jason Kuster
>> Apache Beam / Google Cloud Dataflow
>>
>> See something? Say something. go/jasonkuster-feedback
>> 
>>
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Chamikara Jayalath 
+1

Thanks,
Cham

On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
>>> wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer Load for
>>> Code Reviews"[1], this is a vote to change the Beam policy on Code 
>>> Reviews
>>> to require that
>>>
>>> (1) At least one committer is involved with the code review, as
>>> either a reviewer or as the author
>>> (2) A contributor has approved the change
>>>
>>> prior to merging any change.
>>>
>>> This changes our policy from its current requirement that at least
>>> one committer *who is not the author* has approved the change prior to
>>> merging. We believe that changing this process will improve code review
>>> throughput, reduce committer load, and engage more of the community in 
>>> the
>>> code review process.
>>>
>>> Please vote:
>>> [ ] +1: Accept the above proposal to change the Beam code
>>> review/merge policy
>>> [ ] -1: Leave the Code Review policy unchanged
>>>
>>> Thanks,
>>>
>>> Thomas
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>>
>>
>

>
> --
> ---
> Jason Kuster
> Apache Beam / Google Cloud Dataflow
>
> See something? Say something. go/jasonkuster-feedback
> 
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Ankur Goenka 
+1

On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:

> As we seem to largely have consensus in "Reducing Committer Load for
> Code Reviews"[1], this is a vote to change the Beam policy on Code Reviews
> to require that
>
> (1) At least one committer is involved with the code review, as either
> a reviewer or as the author
> (2) A contributor has approved the change
>
> prior to merging any change.
>
> This changes our policy from its current requirement that at least one
> committer *who is not the author* has approved the change prior to 
> merging.
> We believe that changing this process will improve code review throughput,
> reduce committer load, and engage more of the community in the code review
> process.
>
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code review/merge
> policy
> [ ] -1: Leave the Code Review policy unchanged
>
> Thanks,
>
> Thomas
>
> [1]
> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>

>>>
>>

Re: [VOTE] Code Review Process

2018-06-01 Thread Jason Kuster 
+1

On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles 
 wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>
>> As we seem to largely have consensus in "Reducing Committer Load for
>> Code Reviews"[1], this is a vote to change the Beam policy on Code 
>> Reviews
>> to require that
>>
>> (1) At least one committer is involved with the code review, as
>> either a reviewer or as the author
>> (2) A contributor has approved the change
>>
>> prior to merging any change.
>>
>> This changes our policy from its current requirement that at least
>> one committer *who is not the author* has approved the change prior to
>> merging. We believe that changing this process will improve code review
>> throughput, reduce committer load, and engage more of the community in 
>> the
>> code review process.
>>
>> Please vote:
>> [ ] +1: Accept the above proposal to change the Beam code
>> review/merge policy
>> [ ] -1: Leave the Code Review policy unchanged
>>
>> Thanks,
>>
>> Thomas
>>
>> [1]
>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>
>

>>>

-- 
---
Jason Kuster
Apache Beam / Google Cloud Dataflow

See something? Say something. go/jasonkuster-feedback

Re: [VOTE] Code Review Process

2018-06-01 Thread Huygaa Batsaikhan 
+1. This will allow non-committers to be actively involved in code reviews
and reduce committer load.

On Fri, Jun 1, 2018 at 11:28 AM Charles Chen  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:
>>>
 +1

 On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:

> As we seem to largely have consensus in "Reducing Committer Load for
> Code Reviews"[1], this is a vote to change the Beam policy on Code Reviews
> to require that
>
> (1) At least one committer is involved with the code review, as either
> a reviewer or as the author
> (2) A contributor has approved the change
>
> prior to merging any change.
>
> This changes our policy from its current requirement that at least one
> committer *who is not the author* has approved the change prior to 
> merging.
> We believe that changing this process will improve code review throughput,
> reduce committer load, and engage more of the community in the code review
> process.
>
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code review/merge
> policy
> [ ] -1: Leave the Code Review policy unchanged
>
> Thanks,
>
> Thomas
>
> [1]
> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>

>>>
>>

Re: [VOTE] Code Review Process

2018-06-01 Thread Charles Chen 
+1

On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev 
wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>>>
 As we seem to largely have consensus in "Reducing Committer Load for
 Code Reviews"[1], this is a vote to change the Beam policy on Code Reviews
 to require that

 (1) At least one committer is involved with the code review, as either
 a reviewer or as the author
 (2) A contributor has approved the change

 prior to merging any change.

 This changes our policy from its current requirement that at least one
 committer *who is not the author* has approved the change prior to merging.
 We believe that changing this process will improve code review throughput,
 reduce committer load, and engage more of the community in the code review
 process.

 Please vote:
 [ ] +1: Accept the above proposal to change the Beam code review/merge
 policy
 [ ] -1: Leave the Code Review policy unchanged

 Thanks,

 Thomas

 [1]
 https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E

>>>
>>
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Valentyn Tymofieiev 
+1

On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer Load for
>>> Code Reviews"[1], this is a vote to change the Beam policy on Code Reviews
>>> to require that
>>>
>>> (1) At least one committer is involved with the code review, as either a
>>> reviewer or as the author
>>> (2) A contributor has approved the change
>>>
>>> prior to merging any change.
>>>
>>> This changes our policy from its current requirement that at least one
>>> committer *who is not the author* has approved the change prior to merging.
>>> We believe that changing this process will improve code review throughput,
>>> reduce committer load, and engage more of the community in the code review
>>> process.
>>>
>>> Please vote:
>>> [ ] +1: Accept the above proposal to change the Beam code review/merge
>>> policy
>>> [ ] -1: Leave the Code Review policy unchanged
>>>
>>> Thanks,
>>>
>>> Thomas
>>>
>>> [1] https://lists.apache.org/thread.html/7c1fde3884fbefacc25
>>> 2b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>>
>>
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Ahmet Altay 
+1

On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles  wrote:

> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:
>
>> As we seem to largely have consensus in "Reducing Committer Load for Code
>> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
>> require that
>>
>> (1) At least one committer is involved with the code review, as either a
>> reviewer or as the author
>> (2) A contributor has approved the change
>>
>> prior to merging any change.
>>
>> This changes our policy from its current requirement that at least one
>> committer *who is not the author* has approved the change prior to merging.
>> We believe that changing this process will improve code review throughput,
>> reduce committer load, and engage more of the community in the code review
>> process.
>>
>> Please vote:
>> [ ] +1: Accept the above proposal to change the Beam code review/merge
>> policy
>> [ ] -1: Leave the Code Review policy unchanged
>>
>> Thanks,
>>
>> Thomas
>>
>> [1] https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9
>> a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>>
>

Re: [VOTE] Code Review Process

2018-06-01 Thread Kenneth Knowles 
+1

On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh  wrote:

> As we seem to largely have consensus in "Reducing Committer Load for Code
> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
> require that
>
> (1) At least one committer is involved with the code review, as either a
> reviewer or as the author
> (2) A contributor has approved the change
>
> prior to merging any change.
>
> This changes our policy from its current requirement that at least one
> committer *who is not the author* has approved the change prior to merging.
> We believe that changing this process will improve code review throughput,
> reduce committer load, and engage more of the community in the code review
> process.
>
> Please vote:
> [ ] +1: Accept the above proposal to change the Beam code review/merge
> policy
> [ ] -1: Leave the Code Review policy unchanged
>
> Thanks,
>
> Thomas
>
> [1]
> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E
>

[VOTE] Code Review Process

2018-06-01 Thread Thomas Groh 
As we seem to largely have consensus in "Reducing Committer Load for Code
Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
require that

(1) At least one committer is involved with the code review, as either a
reviewer or as the author
(2) A contributor has approved the change

prior to merging any change.

This changes our policy from its current requirement that at least one
committer *who is not the author* has approved the change prior to merging.
We believe that changing this process will improve code review throughput,
reduce committer load, and engage more of the community in the code review
process.

Please vote:
[ ] +1: Accept the above proposal to change the Beam code review/merge
policy
[ ] -1: Leave the Code Review policy unchanged

Thanks,

Thomas

[1]
https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E