Re: [RESULT] [VOTE] Vendored Dependencies Release beam-vendor-grpc-1-60-1:0.2

2024-02-15 Thread Robert Burke
I'll handle the PMC steps for this. Thanks! On 2024/02/15 09:37:55 Sam Whittle wrote: > I'm happy to announce that we have unanimously approved the vendored release > > of beam-vendor-grpc-1-60-1:0.2 . > > There are 5 approving votes, 4 of which are binding: > > * chamikara@ Chamikara

[RESULT] [VOTE] Vendored Dependencies Release beam-vendor-grpc-1-60-1:0.2

2024-02-15 Thread Sam Whittle
I'm happy to announce that we have unanimously approved the vendored release of beam-vendor-grpc-1-60-1:0.2 . There are 5 approving votes, 4 of which are binding: * chamikara@ Chamikara Madhusanka Jayalath * kenn@ Kenneth Knowles * lostluck@ Robert Burke * tvalentyn@ Valentyn Tymofieiev *

Re: [VOTE] Vendored Dependencies Release

2024-02-15 Thread Sam Whittle
Thanks everyone, I'm closing the vote. On 2024/02/14 16:51:02 Valentyn Tymofieiev via dev wrote: > +1 (binding) > > On Wed, Feb 14, 2024 at 7:52 AM Kenneth Knowles wrote: > > > +1 (binding) > > > > On Wed, Feb 14, 2024 at 10:48 AM Robert Burke wrote: > > > >> +1 (binding) > >> > >> On Wed,

Re: [VOTE] Vendored Dependencies Release

2024-02-14 Thread Valentyn Tymofieiev via dev
+1 (binding) On Wed, Feb 14, 2024 at 7:52 AM Kenneth Knowles wrote: > +1 (binding) > > On Wed, Feb 14, 2024 at 10:48 AM Robert Burke wrote: > >> +1 (binding) >> >> On Wed, Feb 14, 2024, 7:35 AM Yi Hu via dev wrote: >> >>> +1 (non-binding) >>> >>> checked artifact packages not leaking

Re: [VOTE] Vendored Dependencies Release

2024-02-14 Thread Kenneth Knowles
+1 (binding) On Wed, Feb 14, 2024 at 10:48 AM Robert Burke wrote: > +1 (binding) > > On Wed, Feb 14, 2024, 7:35 AM Yi Hu via dev wrote: > >> +1 (non-binding) >> >> checked artifact packages not leaking namespace (or under >> org.apache.beam.vendor.grpc.v1p60p1) and the tests in >>

Re: [VOTE] Vendored Dependencies Release

2024-02-14 Thread Robert Burke
+1 (binding) On Wed, Feb 14, 2024, 7:35 AM Yi Hu via dev wrote: > +1 (non-binding) > > checked artifact packages not leaking namespace (or under > org.apache.beam.vendor.grpc.v1p60p1) and the tests in > https://github.com/apache/beam/pull/30212 > > > > > On Tue, Feb 13, 2024 at 4:29 AM Sam

Re: [VOTE] Vendored Dependencies Release

2024-02-14 Thread Yi Hu via dev
+1 (non-binding) checked artifact packages not leaking namespace (or under org.apache.beam.vendor.grpc.v1p60p1) and the tests in https://github.com/apache/beam/pull/30212 On Tue, Feb 13, 2024 at 4:29 AM Sam Whittle wrote: > Hi, > Sorry I missed that close step. Done! > Sam > > On Mon, Feb

Re: [VOTE] Vendored Dependencies Release

2024-02-13 Thread Sam Whittle via dev
Hi, Sorry I missed that close step. Done! Sam On Mon, Feb 12, 2024 at 8:32 PM Yi Hu via dev wrote: > Hi, > > I am trying to open " > https://repository.apache.org/content/repositories/orgapachebeam-1369/; > but get "[id=orgapachebeam-1369] exists but is not exposed." It seems the > staging

Re: [VOTE] Vendored Dependencies Release

2024-02-12 Thread Yi Hu via dev
Hi, I am trying to open " https://repository.apache.org/content/repositories/orgapachebeam-1369/; but get "[id=orgapachebeam-1369] exists but is not exposed." It seems the staging repository needs to be closed to have it available to public: [1] [1]

Re: [VOTE] Vendored Dependencies Release

2024-02-12 Thread Chamikara Jayalath via dev
+1 (binding) Thanks, Cham On Fri, Feb 9, 2024 at 5:25 AM Sam Whittle wrote: > Please review the release of the following artifacts that we vendor, > following the process [5]: > > * beam-vendor-grpc-1-60-1:0.2 > > Hi everyone, > > Please review and vote on the release candidate #1 for the

[VOTE] Vendored Dependencies Release

2024-02-09 Thread Sam Whittle
Please review the release of the following artifacts that we vendor, following the process [5]: * beam-vendor-grpc-1-60-1:0.2 Hi everyone, Please review and vote on the release candidate #1 for the version beam-vendor-grpc-1-60-1:0.2 as follows: [ ] +1, Approve the release [ ] -1, Do not

[Result][VOTE] Vendored Dependencies Release beam-vendor-grpc-1_60_1

2024-01-22 Thread Yi Hu via dev
Hi everyone, I'm happy to announce that we have unanimously approved this release. There are three approving votes, three of which are binding: * Kenneth Knowles * Robert Bradshaw * Chamikara Jayalath There are no disapproving votes. I will begin finalizing the release. Thanks everyone! --

Re: [VOTE] Vendored Dependencies Release

2024-01-22 Thread Chamikara Jayalath via dev
+1 (binding). Thanks, Cham On Mon, Jan 22, 2024 at 7:40 AM Yi Hu via dev wrote: > > Notably, the vendored artifact has no impact on the repo until the > version used is also bumped. > > That is correct. The PR that actually bump the version then the change > takes effect will be like

Re: [VOTE] Vendored Dependencies Release

2024-01-22 Thread Yi Hu via dev
> Notably, the vendored artifact has no impact on the repo until the version used is also bumped. That is correct. The PR that actually bump the version then the change takes effect will be like https://github.com/apache/beam/pull/29976 On Mon, Jan 22, 2024 at 10:11 AM Kenneth Knowles wrote: >

Re: [VOTE] Vendored Dependencies Release

2024-01-22 Thread Kenneth Knowles
Notably, the vendored artifact has no impact on the repo until the version used is also bumped, right? So the release is very low stakes. Kenn On Fri, Jan 19, 2024 at 4:55 PM Robert Bradshaw via dev wrote: > Thanks. > > +1 > > > On Fri, Jan 19, 2024 at 1:24 PM Yi Hu wrote: > >> The process I

Re: [VOTE] Vendored Dependencies Release

2024-01-19 Thread Robert Bradshaw via dev
Thanks. +1 On Fri, Jan 19, 2024 at 1:24 PM Yi Hu wrote: > The process I have been following is [1]. I have also suggested edits to > the voting email template to include the self-link. However, does anyone > can edit this doc so the change can be made? Otherwise we might better to > migrate

Re: [VOTE] Vendored Dependencies Release

2024-01-19 Thread Yi Hu via dev
The process I have been following is [1]. I have also suggested edits to the voting email template to include the self-link. However, does anyone can edit this doc so the change can be made? Otherwise we might better to migrate this doc to

Re: [VOTE] Vendored Dependencies Release

2024-01-18 Thread Robert Bradshaw via dev
Could you explain the process you used to produce these artifacts? On Thu, Jan 18, 2024 at 11:23 AM Kenneth Knowles wrote: > +1 > > On Wed, Jan 17, 2024 at 6:03 PM Yi Hu via dev wrote: > >> Hi everyone, >> >> >> Please review the release of the following artifacts that we vendor: >> >> *

Re: [VOTE] Vendored Dependencies Release

2024-01-18 Thread Kenneth Knowles
+1 On Wed, Jan 17, 2024 at 6:03 PM Yi Hu via dev wrote: > Hi everyone, > > > Please review the release of the following artifacts that we vendor: > > * beam-vendor-grpc-1_60_1 > > > Please review and vote on the release candidate #1 for the version 0.1, as > follows: > > [ ] +1, Approve the

[VOTE] Vendored Dependencies Release

2024-01-17 Thread Yi Hu via dev
Hi everyone, Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_60_1 Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments)

Re: [VOTE] Vendored Dependencies Release

2023-04-20 Thread Yi Hu via dev
Update: the beam-vendor-grpc-1_54_0 artifact is now released and the development branch has been switched to use it [1]. [1] https://github.com/apache/beam/pull/26371 Thanks everyone! On Wed, Apr 19, 2023 at 2:57 PM Yi Hu wrote: > I'm happy to announce that we have unanimously approved this

Re: [VOTE] Vendored Dependencies Release

2023-04-19 Thread Yi Hu via dev
I'm happy to announce that we have unanimously approved this release. There are 3 approving votes, 3 of which are binding: * Kenneth Knowles * Chamikara Jayalath * Robert Bradshaw There are no disapproving votes. Thanks everyone! On Mon, Apr 17, 2023 at 6:11 PM Robert Bradshaw wrote: > +1 >

Re: [VOTE] Vendored Dependencies Release

2023-04-17 Thread Robert Bradshaw via dev
+1 On Mon, Apr 17, 2023 at 11:20 AM Chamikara Jayalath via dev < dev@beam.apache.org> wrote: > +1 > > Thanks, > Cham > > On Mon, Apr 17, 2023 at 11:04 AM Kenneth Knowles wrote: > >> +1 >> >> On Fri, Apr 14, 2023 at 1:30 PM Yi Hu via dev >> wrote: >> >>> Please review the release of the

Re: [VOTE] Vendored Dependencies Release

2023-04-17 Thread Chamikara Jayalath via dev
+1 Thanks, Cham On Mon, Apr 17, 2023 at 11:04 AM Kenneth Knowles wrote: > +1 > > On Fri, Apr 14, 2023 at 1:30 PM Yi Hu via dev wrote: > >> Please review the release of the following artifacts that we vendor: >> >> * beam-vendor-grpc-1_54_0 >> >> >> >> Hi everyone, >> >> Please review and

Re: [VOTE] Vendored Dependencies Release

2023-04-17 Thread Kenneth Knowles
+1 On Fri, Apr 14, 2023 at 1:30 PM Yi Hu via dev wrote: > Please review the release of the following artifacts that we vendor: > > * beam-vendor-grpc-1_54_0 > > > > Hi everyone, > > Please review and vote on the release candidate #1 for the version 0.1, as > follows: > > [ ] +1, Approve the

[VOTE] Vendored Dependencies Release

2023-04-14 Thread Yi Hu via dev
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_54_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments)

[RESULT] [VOTE] Vendored Dependencies Release

2022-08-08 Thread Luke Cwik via dev
I'm happy to announce that we have unanimously approved this release. There are 3 approving votes, 3 of which are binding: * Luke Cwik * Pablo Estrada * Chamikara Jayalath There are no disapproving votes. Thanks everyone! On Mon, Aug 8, 2022 at 9:47 AM Pablo Estrada wrote: > +1 > Thanks! >

Re: [VOTE] Vendored Dependencies Release

2022-08-08 Thread Pablo Estrada via dev
+1 Thanks! -P. On Mon, Aug 8, 2022 at 9:24 AM Chamikara Jayalath via dev < dev@beam.apache.org> wrote: > +1 > > Thanks, > Cham > > On Fri, Aug 5, 2022 at 1:49 PM Luke Cwik via dev > wrote: > >> +1 >> >> I verified the signatures of the artifacts, that the jar doesn't contain >> classes outside

Re: [VOTE] Vendored Dependencies Release

2022-08-08 Thread Chamikara Jayalath via dev
+1 Thanks, Cham On Fri, Aug 5, 2022 at 1:49 PM Luke Cwik via dev wrote: > +1 > > I verified the signatures of the artifacts, that the jar doesn't contain > classes outside of the org/apache/beam/vendor/grpc/v1p48p1 package and I > tested the artifact against our precommits using >

Re: [VOTE] Vendored Dependencies Release

2022-08-05 Thread Luke Cwik via dev
+1 I verified the signatures of the artifacts, that the jar doesn't contain classes outside of the org/apache/beam/vendor/grpc/v1p48p1 package and I tested the artifact against our precommits using https://github.com/apache/beam/pull/22595 On Fri, Aug 5, 2022 at 1:42 PM Luke Cwik wrote: >

[VOTE] Vendored Dependencies Release

2022-08-05 Thread Luke Cwik via dev
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_48_1 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-20 Thread Ismaël Mejía
I'm happy to announce that we have unanimously approved this release. There are 7 approving votes, 4 of which are binding: * Pablo Estrada * Etienne Chauchot * Jean-Baptiste Onofre * Ismaël Mejía There are no disapproving votes. Thanks everyone! On Thu, May 20, 2021 at 9:17 PM Ismaël Mejía

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-20 Thread Ismaël Mejía
+1 (binding)

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-20 Thread Jean-Baptiste Onofre
+1 (binding) Regards JB > Le 20 mai 2021 à 10:56, Etienne Chauchot a écrit : > > +1 (binding) on releasing vendored bytebuddy for testing in > https://github.com/apache/beam/pull/14824 > > Etienne > > On 19/05/2021 23:43, Kai Jiang wrote: >> +1

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-20 Thread Etienne Chauchot
+1 (binding) on releasing vendored bytebuddy for testing in https://github.com/apache/beam/pull/14824 Etienne On 19/05/2021 23:43, Kai Jiang wrote: +1 (non-binding) On Wed, May 19, 2021 at 12:23 PM Jan Lukavský > wrote: +1 (non-binding) verified correct

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Kai Jiang
+1 (non-binding) On Wed, May 19, 2021 at 12:23 PM Jan Lukavský wrote: > +1 (non-binding) > > verified correct shading. > > Jan > On 5/19/21 8:53 PM, Ismaël Mejía wrote: > > This release is only to publish the vendored dependency artifacts. We need > those to integrate it and be able to verify

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Jan Lukavský
+1 (non-binding) verified correct shading.  Jan On 5/19/21 8:53 PM, Ismaël Mejía wrote: This release is only to publish the vendored dependency artifacts. We need those to integrate it and be able to verify if it causes problems or not. The PR for this is already opened but it needs the

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Tomo Suzuki
+1 All classes in the JAR are shaded correctly under org/apache/beam/vendor On Wed, May 19, 2021 at 2:54 PM Ismaël Mejía wrote: > This release is only to publish the vendored dependency artifacts. We need > those to integrate it and be able to verify if it causes problems or not. > The PR for

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Ismaël Mejía
This release is only to publish the vendored dependency artifacts. We need those to integrate it and be able to verify if it causes problems or not. The PR for this is already opened but it needs the artifacts of this vote to be ran. https://github.com/apache/beam/pull/14824 For ref there is a

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Pablo Estrada
+1 (binding) I've verified the hash sums. Best -P. On Wed, May 19, 2021 at 11:45 AM Tyson Hamilton wrote: > I'd like to help, but I don't know how to determine whether this upgrade > is going to cause problems or not. Are there tests I should look at, or > some validation I should perform? > >

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Tyson Hamilton
I'd like to help, but I don't know how to determine whether this upgrade is going to cause problems or not. Are there tests I should look at, or some validation I should perform? On Wed, May 19, 2021 at 11:29 AM Ismaël Mejía wrote: > Kind reminder, the vote is ongoing > > On Mon, May 17, 2021

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-19 Thread Ismaël Mejía
Kind reminder, the vote is ongoing On Mon, May 17, 2021 at 5:32 PM Ismaël Mejía wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-bytebuddy-1_11_0 > > Hi everyone, > Please review and vote on the release candidate #1 for the version 0.1, as >

[VOTE] Vendored Dependencies Release Byte Buddy 1.11.0

2021-05-17 Thread Ismaël Mejía
Please review the release of the following artifacts that we vendor: * beam-vendor-bytebuddy-1_11_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments)

[RESULT] [VOTE] Vendored Dependencies Release gRPC 1.36.0 v0.1 RC1

2021-03-19 Thread Kenneth Knowles
The vote has passed, with +4 approving votes: - Kenneth Knowles - Pablo Estrada - Ahmet Altay - Robert Bradshaw I will finalize the release. Kenn On Fri, Mar 19, 2021 at 6:02 PM Kenneth Knowles wrote: > +1 > > On Tue, Mar 16, 2021 at 6:07 PM Pablo Estrada wrote: > >> +1! >> >> On Tue,

Re: [VOTE] Vendored Dependencies Release gRPC 1.36.0 v0.1 RC1

2021-03-19 Thread Kenneth Knowles
+1 On Tue, Mar 16, 2021 at 6:07 PM Pablo Estrada wrote: > +1! > > On Tue, Mar 16, 2021 at 4:22 PM Ahmet Altay wrote: > >> +1 >> >> On Tue, Mar 16, 2021 at 4:21 PM Robert Bradshaw >> wrote: >> >>> +1 >>> >>> On Tue, Mar 16, 2021 at 4:00 PM Kenneth Knowles wrote: >>> Please review the

Re: [VOTE] Vendored Dependencies Release gRPC 1.36.0 v0.1 RC1

2021-03-16 Thread Pablo Estrada
+1! On Tue, Mar 16, 2021 at 4:22 PM Ahmet Altay wrote: > +1 > > On Tue, Mar 16, 2021 at 4:21 PM Robert Bradshaw > wrote: > >> +1 >> >> On Tue, Mar 16, 2021 at 4:00 PM Kenneth Knowles wrote: >> >>> Please review the release of the following artifacts that we vendor: >>> *

Re: [VOTE] Vendored Dependencies Release gRPC 1.36.0 v0.1 RC1

2021-03-16 Thread Ahmet Altay
+1 On Tue, Mar 16, 2021 at 4:21 PM Robert Bradshaw wrote: > +1 > > On Tue, Mar 16, 2021 at 4:00 PM Kenneth Knowles wrote: > >> Please review the release of the following artifacts that we vendor: >> * beam-vendor-grpc-1_36_0 >> >> Hi everyone, >> >> Please review and vote on the release

Re: [VOTE] Vendored Dependencies Release gRPC 1.36.0 v0.1 RC1

2021-03-16 Thread Robert Bradshaw
+1 On Tue, Mar 16, 2021 at 4:00 PM Kenneth Knowles wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-grpc-1_36_0 > > Hi everyone, > > Please review and vote on the release candidate #1 for the version 0.1, as > follows: > [ ] +1, Approve the release

[VOTE] Vendored Dependencies Release gRPC 1.36.0 v0.1 RC1

2021-03-16 Thread Kenneth Knowles
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_36_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

[RESULT] [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #3

2020-03-09 Thread Luke Cwik
I'm happy to announce that we have unanimously approved this release. There are 3 approving votes, 3 of which are binding: * Ismaël Mejía * Jean-Baptiste Onofre * Luke Cwik There are no disapproving votes. Thanks everyone! On Thu, Mar 5, 2020 at 1:56 PM Ismaël Mejía wrote: > +1 (binding) > >

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #3

2020-03-05 Thread Ismaël Mejía
+1 (binding) Verified signatures Verified that there are no conscrypt classes or binaries in jar Verified pom.xml has runtime dependency on conscrypt On Thu, Mar 5, 2020 at 9:14 PM Jean-Baptiste Onofre wrote: > > +1 (binding) > > Regards > JB > > Le 5 mars 2020 à 19:55, Luke Cwik a écrit : > >

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #3

2020-03-05 Thread Jean-Baptiste Onofre
+1 (binding) Regards JB > Le 5 mars 2020 à 19:55, Luke Cwik a écrit : > > Please review the release of the following artifacts that we vendor: > * beam-vendor-grpc-1_26_0 > > Hi everyone, > Please review and vote on the release candidate #1 for the version 0.3, as > follows: > [ ] +1,

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #3

2020-03-05 Thread Luke Cwik
+1 (binding) Verified that conscrypt jars and .so files don't appear in the jar. On Thu, Mar 5, 2020 at 10:55 AM Luke Cwik wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-grpc-1_26_0 > > Hi everyone, > Please review and vote on the release

[VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #3

2020-03-05 Thread Luke Cwik
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #2

2020-03-05 Thread Luke Cwik
Cancelling this release, I made a mistake for the commit id which I built from which I should have caught before sending this out. On Thu, Mar 5, 2020 at 10:45 AM Luke Cwik wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-grpc-1_26_0 > > Hi

[VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288 RC #2

2020-03-05 Thread Luke Cwik
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288

2020-03-03 Thread Luke Cwik
Looks like the vote is cancelled. On Tue, Mar 3, 2020 at 2:03 PM Ismaël Mejía wrote: > -1 > > It seems we still are adding the conscrypt native libraries as part in > META-INF > > $ jar tvf beam-vendor-grpc-1_26_0-0.3.jar | grep conscrypt > 2218176 Mon Sep 17 10:36:24 CEST 2018 >

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288

2020-03-03 Thread Ismaël Mejía
-1 It seems we still are adding the conscrypt native libraries as part in META-INF $ jar tvf beam-vendor-grpc-1_26_0-0.3.jar | grep conscrypt 2218176 Mon Sep 17 10:36:24 CEST 2018 META-INF/native/libconscrypt_openjdk_jni-linux-x86_64.so 1720832 Mon Sep 17 10:36:24 CEST 2018

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288

2020-03-03 Thread Pablo Estrada
+1 (binding) verified hashes On Tue, Mar 3, 2020 at 11:20 AM Luke Cwik wrote: > +1 (binding) > Verified signatures > Verified that there are no conscrypt classes in jar > Verified pom.xml has runtime dependency on conscrypt > > On Tue, Mar 3, 2020 at 10:35 AM Jean-Baptiste Onofré > wrote: > >>

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288

2020-03-03 Thread Luke Cwik
+1 (binding) Verified signatures Verified that there are no conscrypt classes in jar Verified pom.xml has runtime dependency on conscrypt On Tue, Mar 3, 2020 at 10:35 AM Jean-Baptiste Onofré wrote: > +1 (binding) > > Regards > JB > > Le mar. 3 mars 2020 ? 19:31, Luke Cwik a ?crit : > >> Please

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288

2020-03-03 Thread Jean-Baptiste Onofré
+1 (binding)RegardsJBLe mar. 3 mars 2020 ? 19:31, Luke Cwik a ?crit :Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0Hi everyone,Please review and vote on the release candidate #1 for the version 0.3, as follows:[ ] +1, Approve the release[ ] -1, Do

[VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.3 for BEAM-9288

2020-03-03 Thread Luke Cwik
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-29 Thread Ismaël Mejía
I'm happy to announce that we have unanimously approved this release. There are 6 approving votes, 5 of which are binding: * Luke Cwik * Pablo Estrada * Robert Bradshaw * Ismaël Mejía * Kenneth Knowles There are no disapproving votes. Thanks everyone! On Fri, Feb 28, 2020 at 6:39 PM Kenneth

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-28 Thread Kenneth Knowles
+1 (binding) On Fri, Feb 28, 2020 at 8:19 AM Ismaël Mejía wrote: > +1 (binding) > > On Wed, Feb 26, 2020 at 10:28 PM Robert Bradshaw > wrote: > >> +1 (binding) >> >> On Wed, Feb 26, 2020 at 1:11 PM Pablo Estrada wrote: >> > >> > +1 (binding) >> > Verified hashes. >> > Thank you Ismael! >> >

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-28 Thread Ismaël Mejía
+1 (binding) On Wed, Feb 26, 2020 at 10:28 PM Robert Bradshaw wrote: > +1 (binding) > > On Wed, Feb 26, 2020 at 1:11 PM Pablo Estrada wrote: > > > > +1 (binding) > > Verified hashes. > > Thank you Ismael! > > > > On Wed, Feb 26, 2020 at 11:30 AM Luke Cwik wrote: > >> > >> +1 (binding) > >> >

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-26 Thread Robert Bradshaw
+1 (binding) On Wed, Feb 26, 2020 at 1:11 PM Pablo Estrada wrote: > > +1 (binding) > Verified hashes. > Thank you Ismael! > > On Wed, Feb 26, 2020 at 11:30 AM Luke Cwik wrote: >> >> +1 (binding) >> >> Verified signatures and contents of jar to not contain module-info.class >> >> On Wed, Feb 26,

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-26 Thread Pablo Estrada
+1 (binding) Verified hashes. Thank you Ismael! On Wed, Feb 26, 2020 at 11:30 AM Luke Cwik wrote: > +1 (binding) > > Verified signatures and contents of jar to not contain module-info.class > > On Wed, Feb 26, 2020 at 10:45 AM Kai Jiang wrote: > >> +1 (non-binding) >> >> On Wed, Feb 26, 2020

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-26 Thread Luke Cwik
+1 (binding) Verified signatures and contents of jar to not contain module-info.class On Wed, Feb 26, 2020 at 10:45 AM Kai Jiang wrote: > +1 (non-binding) > > On Wed, Feb 26, 2020 at 01:23 Ismaël Mejía wrote: > >> Please review the release of the following artifacts that we vendor: >> *

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-26 Thread Kai Jiang
+1 (non-binding) On Wed, Feb 26, 2020 at 01:23 Ismaël Mejía wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-bytebuddy-1_10_8 > > Hi everyone, > Please review and vote on the release candidate #2 for the version 0.1, as > follows: > [ ] +1, Approve

[VOTE] Vendored Dependencies Release Byte Buddy 1.10.8 RC2

2020-02-26 Thread Ismaël Mejía
Please review the release of the following artifacts that we vendor: * beam-vendor-bytebuddy-1_10_8 Hi everyone, Please review and vote on the release candidate #2 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments)

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Ismaël Mejía
Thanks Luke there is indeed an extra module-info.class in the vendored jar. This vote is cancelled. A new vote will be opened once the fix is merged. PTAL https://github.com/apache/beam/pull/10970 On Tue, Feb 25, 2020 at 6:39 PM Luke Cwik wrote: > -1 > > The jar contains

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Luke Cwik
-1 The jar contains META-INF/versions/9/module-info.class copied over from bytebuddy containing: module net.bytebuddy { requires static java.instrument; requires static jdk.unsupported; requires static net.bytebuddy.agent; exports net.bytebuddy; exports net.bytebuddy.agent.builder;

[RESULT] [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-25 Thread Luke Cwik
I'm happy to announce that we have unanimously approved this release. There are 7 approving votes, 4 of which are binding: * Ismaël Mejía * Robert Bradshaw * Ahmet Altay * Luke Cwik There are no disapproving votes. Thanks everyone! On Sat, Feb 22, 2020 at 5:49 AM Ismaël Mejía wrote: > +1

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Jean-Baptiste Onofré
+1Regards JBLe mar. 25 f?vr. 2020 ? 13:43, Isma?l Mej?a a ?crit :Please review the release of the following artifacts that we vendor: * beam-vendor-bytebuddy-1_10_8Hi everyone,Please review and vote on the release candidate #1 for the version 0.1, as follows:[ ] +1, Approve the release[ ] -1, Do

Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Reuven Lax
+1 On Tue, Feb 25, 2020 at 4:44 AM Ismaël Mejía wrote: > Please review the release of the following artifacts that we vendor: > * beam-vendor-bytebuddy-1_10_8 > > Hi everyone, > Please review and vote on the release candidate #1 for the version 0.1, as > follows: > [ ] +1, Approve the release

[VOTE] Vendored Dependencies Release Byte Buddy 1.10.8

2020-02-25 Thread Ismaël Mejía
Please review the release of the following artifacts that we vendor: * beam-vendor-bytebuddy-1_10_8 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments)

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-22 Thread Ismaël Mejía
+1 (binding) Verified signatures, produced jar from code and checked that artifact does not contain both Main.class and module-info.classes Thanks for taking care of this Tomo and Luke. On Sat, Feb 22, 2020 at 10:27 AM jincheng sun wrote: > +1(non-binding) > > Best, > Jincheng > > > Kai

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-22 Thread jincheng sun
+1(non-binding) Best, Jincheng Kai Jiang 于2020年2月22日周六 下午2:58写道: > +1 (non-binding) > > On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu wrote: > >> +1 (verified) >> >> On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw >> wrote: >> >>> +1 (binding) >>> >>> >>> On Fri, Feb 21, 2020 at 4:48 PM Ahmet

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-21 Thread Kai Jiang
+1 (non-binding) On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu wrote: > +1 (verified) > > On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw > wrote: > >> +1 (binding) >> >> >> On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay wrote: >> > >> > +1 >> > >> > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik wrote:

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-21 Thread Robin Qiu
+1 (verified) On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw wrote: > +1 (binding) > > > On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay wrote: > > > > +1 > > > > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik wrote: > >> > >> +1 (binding) > >> I diffed the binary contents of the 0.1 jar and 0.2 jar

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-21 Thread Robert Bradshaw
+1 (binding) On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay wrote: > > +1 > > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik wrote: >> >> +1 (binding) >> I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes to >> the contents of the files and can confirm that module-info.class the

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-21 Thread Ahmet Altay
+1 On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik wrote: > +1 (binding) > I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes to > the contents of the files and can confirm that module-info.class the > offending Main.class and Main$1.class have been removed as well. > > On Fri,

Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-21 Thread Luke Cwik
+1 (binding) I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes to the contents of the files and can confirm that module-info.class the offending Main.class and Main$1.class have been removed as well. On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik wrote: > Please review the

[VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252

2020-02-21 Thread Luke Cwik
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.2, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

[RESULT] [VOTE] Vendored Dependencies Release

2020-01-13 Thread Luke Cwik
[RESULT] [VOTE] Vendored Dependencies Release I'm happy to announce that we have unanimously approved this release. There are 6 approving votes, 4 of which are binding: * Luke Cwik * Pablo Estrada * Ahmet Altay * Kenneth Knowles There are no disapproving votes. Thanks everyone! On 2020/01/11

Re: [VOTE] Vendored Dependencies Release

2020-01-10 Thread Kai Jiang
+1 (non-binding) On Thu, Jan 9, 2020 at 8:48 PM jincheng sun wrote: > +1,checked list as follows: > - verified the hash and signature > - verified that there is no linkage errors > - verified that the content of the pom is expected: the shaded > dependencies are not exposed, the scope of the

Re: [VOTE] Vendored Dependencies Release

2020-01-09 Thread jincheng sun
+1,checked list as follows: - verified the hash and signature - verified that there is no linkage errors - verified that the content of the pom is expected: the shaded dependencies are not exposed, the scope of the logging dependencies are runtime, etc. Best, Jincheng Kenneth Knowles

Re: [VOTE] Vendored Dependencies Release

2020-01-09 Thread Kenneth Knowles
+1 On Thu, Jan 9, 2020 at 4:03 PM Ahmet Altay wrote: > +1 > > On Thu, Jan 9, 2020 at 2:04 PM Pablo Estrada wrote: > >> +1 >> >> verified sha1 and md5 hashes. >> >> On Thu, Jan 9, 2020 at 10:28 AM Luke Cwik wrote: >> >>> +1 >>> >>> I validated that no classes appeared outside of the >>>

Re: [VOTE] Vendored Dependencies Release

2020-01-09 Thread Ahmet Altay
+1 On Thu, Jan 9, 2020 at 2:04 PM Pablo Estrada wrote: > +1 > > verified sha1 and md5 hashes. > > On Thu, Jan 9, 2020 at 10:28 AM Luke Cwik wrote: > >> +1 >> >> I validated that no classes appeared outside of the >> org.apache.beam.vendor.grpc.v1p26p0 namespace and I also validated that the >>

Re: [VOTE] Vendored Dependencies Release

2020-01-09 Thread Pablo Estrada
+1 verified sha1 and md5 hashes. On Thu, Jan 9, 2020 at 10:28 AM Luke Cwik wrote: > +1 > > I validated that no classes appeared outside of the > org.apache.beam.vendor.grpc.v1p26p0 namespace and I also validated that the > linkage checker listed no potential linkage errors. > > On Thu, Jan 9,

Re: [VOTE] Vendored Dependencies Release

2020-01-09 Thread Luke Cwik
+1 I validated that no classes appeared outside of the org.apache.beam.vendor.grpc.v1p26p0 namespace and I also validated that the linkage checker listed no potential linkage errors. On Thu, Jan 9, 2020 at 10:25 AM Luke Cwik wrote: > Please review the release of the following artifacts that we

[VOTE] Vendored Dependencies Release

2020-01-09 Thread Luke Cwik
Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0 Hi everyone, Please review and vote on the release candidate #1 for the version 0.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The

Re: [VOTE] Vendored Dependencies Release

2019-09-05 Thread Lukasz Cwik
LGTM On Wed, Sep 4, 2019 at 4:24 PM Rui Wang wrote: > Thanks Pablo for jumping in for help. > > Now the sources are moved to [1]. Please let me know if it is ok. > > [1]: > https://dist.apache.org/repos/dist/release/beam/vendor/calcite/1_20_0/ > > -Rui > > On Wed, Sep 4, 2019 at 4:15 PM Pablo

Re: [VOTE] Vendored Dependencies Release

2019-09-04 Thread Rui Wang
Thanks Pablo for jumping in for help. Now the sources are moved to [1]. Please let me know if it is ok. [1]: https://dist.apache.org/repos/dist/release/beam/vendor/calcite/1_20_0/ -Rui On Wed, Sep 4, 2019 at 4:15 PM Pablo Estrada wrote: > I can help. > > On Wed, Sep 4, 2019 at 1:09 PM Rui

Re: [VOTE] Vendored Dependencies Release

2019-09-04 Thread Pablo Estrada
I can help. On Wed, Sep 4, 2019 at 1:09 PM Rui Wang wrote: > There is a step of releasing requires PMC permission: > > """ > > Copy the source release from the dev repository to the release repository > at dist.apache.org using Subversion. > Move last release artifacts from dist.apache.org to

Re: [VOTE] Vendored Dependencies Release

2019-09-04 Thread Rui Wang
There is a step of releasing requires PMC permission: """ Copy the source release from the dev repository to the release repository at dist.apache.org using Subversion. Move last release artifacts from dist.apache.org to archive.apache.org using Subversion. """ Is there a PMC member could help

Re: [VOTE] Vendored Dependencies Release

2019-09-04 Thread Rui Wang
I'm happy to announce that we have unanimously approved this release. There are 5 approving votes, 3 of which are binding: * Lukasz Cwik * Kenneth Knowles * Ahmet Altay There are no disapproving votes. Thanks everyone! On Tue, Sep 3, 2019 at 1:29 PM Lukasz Cwik wrote: > +1 > > On Tue, Sep

Re: [VOTE] Vendored Dependencies Release

2019-09-03 Thread Lukasz Cwik
+1 On Tue, Sep 3, 2019 at 1:22 PM Kenneth Knowles wrote: > +1 > > On Tue, Sep 3, 2019 at 11:00 AM Ahmet Altay wrote: > >> +1 >> >> On Tue, Sep 3, 2019 at 10:52 AM Andrew Pilloud >> wrote: >> >>> +1 >>> >>> Inspected the jar it looked reasonable. >>> >>> Andrew >>> >>> On Tue, Sep 3, 2019 at

Re: [VOTE] Vendored Dependencies Release

2019-09-03 Thread Kenneth Knowles
+1 On Tue, Sep 3, 2019 at 11:00 AM Ahmet Altay wrote: > +1 > > On Tue, Sep 3, 2019 at 10:52 AM Andrew Pilloud > wrote: > >> +1 >> >> Inspected the jar it looked reasonable. >> >> Andrew >> >> On Tue, Sep 3, 2019 at 9:06 AM Rui Wang wrote: >> >>> Friendly ping. >>> >>> >>> -Rui >>> >>> On Thu,

Re: [VOTE] Vendored Dependencies Release

2019-09-03 Thread Ahmet Altay
+1 On Tue, Sep 3, 2019 at 10:52 AM Andrew Pilloud wrote: > +1 > > Inspected the jar it looked reasonable. > > Andrew > > On Tue, Sep 3, 2019 at 9:06 AM Rui Wang wrote: > >> Friendly ping. >> >> >> -Rui >> >> On Thu, Aug 29, 2019 at 9:50 AM Rui Wang wrote: >> >>> Thanks Kai and Andrew. Now

  1   2   >