Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Davor Bonaci
Nice to see uniform opinion here ;) Pre-commit and post-commit (beam_MavenVerify) should also take care of code coverage reporting. In addition to the nightly build, we had planned to use Jenkins for release automation (e.g., deployment of release candidates, version number management, branching,

Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Kenneth Knowles
On Tue, Apr 5, 2016 at 1:57 AM, Maximilian Michels wrote: > > - Test coverage of pull requests (beam_PreCommit) > - Test coverage of the master and all other branches (beam_MavenVerify) > - A daily job that deploys artifacts to the snapshot repository > (beam_Nightly) > I like this. Everything he

Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Jean-Baptiste Onofré
Hi Jason, Oh ok ;) I would say: - mvn clean verify for each scm change - mvn clean deploy systematically at midnight So, two jobs on Jenkins. My $0.01 Regards JB On 04/05/2016 09:57 AM, Jason Kuster wrote: Hey JB, Just want to clarify - do you mean that beam_nightly would continue to run o

Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Maximilian Michels
Hey JB, I would also propose three Jenkins jobs (apart from the Cloud Dataflow tests): - Test coverage of pull requests (beam_PreCommit) - Test coverage of the master and all other branches (beam_MavenVerify) - A daily job that deploys artifacts to the snapshot repository (beam_Nightly) Keeping

Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Robert Bradshaw
On Tue, Apr 5, 2016 at 12:57 AM, Jason Kuster wrote: > Hey JB, > > Just want to clarify - do you mean that beam_nightly would continue to run > on the schedule it currently has (SCM poll/hourly), plus one run at > midnight? > > I think Dan's question centers around whether beam_nightly build would

Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Jason Kuster
Hey JB, Just want to clarify - do you mean that beam_nightly would continue to run on the schedule it currently has (SCM poll/hourly), plus one run at midnight? I think Dan's question centers around whether beam_nightly build would just run once every 24h. We want our postsubmit coverage to run m

Re: [PROPOSAL] Nightly builds by Jenkins

2016-04-05 Thread Jean-Baptiste Onofré
Hi Dan, you can have both mvn clean deploy and mvn clean verify, but IMHO, the first already covers the second ;) So, I think mvn clean deploy is fine instead of clean verify. WDYT ? Regards JB On 04/05/2016 08:05 AM, Dan Halperin wrote: I am completely behind producing nightly jars. But,