Re: Write retry issues with ZooKeeperClient

2017-06-26 Thread Sam Just
Hmm, curator seems to have essentially the same problem: https://issues.apache.org/jira/browse/CURATOR-268 I'm not sure there's a good way to solve this transparently -- the right answer is probably to plumb the ConnectionLoss event through ZooKeeperClient for interested callers, audit for

Write retry issues with ZooKeeperClient

2017-06-26 Thread Sam Just
BookKeeper has a wrapper class for the ZooKeeper client called ZooKeeperClient. Its purpose appears to be to transparently perform retries in the case that ZooKeeper returns ConnectionLoss on an operation due to a Disconnect event. The trouble is that it's possible that a write which received a

[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

2017-06-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063975#comment-16063975 ] ASF GitHub Bot commented on BOOKKEEPER-1028: Github user reddycharan commented on the

[jira] [Commented] (BOOKKEEPER-1034) When all disks are full, start Bookie in RO mode if RO mode is enabled

2017-06-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063961#comment-16063961 ] ASF GitHub Bot commented on BOOKKEEPER-1034: Github user reddycharan commented on the

[GitHub] bookkeeper issue #190: BOOKKEEPER-1034: Bookie start in RO when diskfull

2017-06-26 Thread reddycharan
Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/190 @sijie fixed tailing spaces --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

2017-06-26 Thread kishorekasi
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/issues/198 Enrico, Found a few refcount leaks, fixed them and created a pull request. I couldn't reproduce the test failure locally. So, could you please check and let me know if this

[GitHub] bookkeeper pull request #214: Fix ByteBuf refcount release

2017-06-26 Thread kishorekasi
GitHub user kishorekasi opened a pull request: https://github.com/apache/bookkeeper/pull/214 Fix ByteBuf refcount release - Release ByteBuf in Replicator - Do not release refcnt in PCBC upon addEntry error - Remove unnecessary ByteBuf refcnt retain in Bookie protocol (V2)

Build failed in Jenkins: bookkeeper-master #1796

2017-06-26 Thread Apache Jenkins Server
See -- [...truncated 1.11 MB...] Running org.apache.bookkeeper.test.BookieFailureTest Tests run: 80, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.687 sec - in

[jira] [Commented] (BOOKKEEPER-588) SSL support

2017-06-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062816#comment-16062816 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user eolivelli commented on the issue:

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-26 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/183 @sijie for me this patch is OK, I don't know if other developers/committer want to add other comments @kishorekasi can you change the description of the PR which usually it written to

[jira] [Commented] (BOOKKEEPER-1100) Add Http Endpoint for Bookkeeper

2017-06-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062613#comment-16062613 ] ASF GitHub Bot commented on BOOKKEEPER-1100: Github user eolivelli commented on the

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-26 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/210 Some comments: 1) is it possible NOT to bundle all the implementations in bookkeeper-server project ? Or at least mark the dependencies as "provided" o "runtime" so that we do not