[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-31 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-319250335 @sijie, I am OK with your idea to start a new one, since this will be changed a lot. It depends on @caiok's decision.

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-28 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-318795947 @sijie @caiok How about merge this first, and open another issue to improve it following the comments above?

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-20 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316894211 @caiok, Thanks for the explain. It is better to handle the code duplications in dirs 4.4.0 and 4.4.0-alpine. If it is hard

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-20 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316894211 @caiok, Thanks for the explain. It is better to handle the code duplications in dirs 4.4.0 and 4.4.0-alpine. If it is hard

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316379132 Hi @caiok, Postgres example is not a "Automated Docker Build", While if bookkeeper image goes into

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in as the first stage, and polish it, while using it. @caiok Still have

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in as the first stage, and do polish it, while using it. @caiok Still

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in as the first stage, and polish it, while using it. @caiok Still have

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-07-19 Thread git
jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still