[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968656#comment-14968656 ] Sijie Guo commented on BOOKKEEPER-867: -- the failed tests aren't related to this patch. the patch

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964804#comment-14964804 ] Hadoop QA commented on BOOKKEEPER-867: -- Testing JIRA BOOKKEEPER-867 Patch

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965224#comment-14965224 ] Sijie Guo commented on BOOKKEEPER-867: -- I ran the test-patch locally. it seems to pass the

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962079#comment-14962079 ] Venkateswararao Jujjuri commented on BOOKKEEPER-867: Adding two more patches one

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962087#comment-14962087 ] Hadoop QA commented on BOOKKEEPER-867: -- Testing JIRA BOOKKEEPER-867 Patch

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961619#comment-14961619 ] Hadoop QA commented on BOOKKEEPER-867: -- Testing JIRA BOOKKEEPER-867 Patch

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960128#comment-14960128 ] Sijie Guo commented on BOOKKEEPER-867: -- [~jujjuri] could you generate the patch with

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960130#comment-14960130 ] Sijie Guo commented on BOOKKEEPER-867: -- the patch looks good to me. +1 > New Client API to allow

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960157#comment-14960157 ] Hadoop QA commented on BOOKKEEPER-867: -- Testing JIRA BOOKKEEPER-867 Patch

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960181#comment-14960181 ] Sijie Guo commented on BOOKKEEPER-867: -- [~jujjuri] there are 23 javadoc warnings and 2 findbugs

Re: [jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

Thanks Sijie. On Mon, Sep 7, 2015 at 9:19 AM, Sijie Guo (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733882#comment-14733882 > ] > > Sijie Guo commented on BOOKKEEPER-867:

Re: [jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

Can you explain little more on "might be test cases cover gap."? You mean ledger getting closed with gaps? or something else? Regarding your suggestion of creating abstract class, you basically wanted AdvLedgerHandle users to deal two handles, for reading(trailing or general) use