[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1110#issuecomment-165446246 @ahgittin thanks. Interesting we weren't getting any `ConcurrentModificationException`s that I noticed. Instead we just had some subset of the 100

[GitHub] incubator-brooklyn pull request: support for external config in Br...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Jenkins build is unstable: incubator-brooklyn-master-build #710

See

Jenkins build is back to normal : incubator-brooklyn-master-windows #388

See

[GitHub] incubator-brooklyn pull request: DO NOT MERGE - "Getting Started" ...

GitHub user geomacy opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1116 DO NOT MERGE - "Getting Started" with CLI documentation updates - for review. These are documentation updates for the "Getting Started" using the CLI. At present they don't

[GitHub] incubator-brooklyn pull request: Various QA changes

Github user m4rkmckenna commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-165611214 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165435426 agree re log message, i've applied that and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-brooklyn pull request: fixed byon syntax for catalog tem...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1106#issuecomment-165434559 Build failure unrelated: `Build timed out (after 40 minutes). Marking the build as aborted.` while checking out git repo. --- If your project is set up

Jenkins build became unstable: incubator-brooklyn-master-build #705

See

[GitHub] incubator-brooklyn pull request: Add timeout to attributeWhenReady...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-brooklyn pull request: Add timeout to attributeWhenReady...

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1090#issuecomment-165436700 nice fix! merged, with a tweak in the api 1c80fb4d1a8dc06138246d2558c30c6dff41db68 . does that sound reasonable @mikezaccardo ? --- If your project

[GitHub] incubator-brooklyn pull request: Fix concurrent use of entity.setA...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1110#discussion_r47898623 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java --- @@ -59,7 +60,20 @@ * Creates a new AttributeMap.

[GitHub] incubator-brooklyn pull request: Jclouds machines: do not persist ...

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1082#issuecomment-165437369 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Jenkins build is back to stable : incubator-brooklyn-master-build #706

See

[GitHub] incubator-brooklyn pull request: GeoDns improvements

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1096#issuecomment-165440498 looks good. minor comments, can be addressed subsequently. merging. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-brooklyn pull request: Rebind NPE fixes

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-brooklyn pull request: Republish request count sensors o...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1109#discussion_r47893741 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityFunctions.java --- @@ -154,7 +154,23 @@ protected

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1104#discussion_r47897382 --- Diff: usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java --- @@ -710,32 +719,42 @@ private void

[GitHub] incubator-brooklyn pull request: Fix/deferred location config

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1093#issuecomment-165434986 @alasdairhodge any progress on including that test and getting it to pass? Ping me if you want to discuss or pair. --- If your project is set up for it,

[GitHub] incubator-brooklyn pull request: support for external config in Br...

GitHub user aledsage reopened a pull request: https://github.com/apache/incubator-brooklyn/pull/1112 support for external config in BrooklynProperties An alternative implementation to https://github.com/apache/incubator-brooklyn/pull/1018 (i.e. replaces that PR). You can merge

[GitHub] incubator-brooklyn pull request: support for external config in Br...

Github user aledsage closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165434366 @sjcorbett Looks good - one very minor comment about an improvement to a log message. Good to merge. --- If your project is set up for it, you can reply

[GitHub] incubator-brooklyn pull request: fixed byon syntax for catalog tem...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1106#issuecomment-165434748 Looks good; merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-brooklyn pull request: support for external config in Br...

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1112#issuecomment-165432762 nice work. one substantive comment -- if not addressing, put a TODO in the doc. but for instance i could see it useful to set an entity etc. also