[GitHub] brooklyn-server pull request #229: Merge brooklyn.parameters in YAML files

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/229#discussion_r69508940 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -384,5 +387,73 @@ public static WeightedParameter

Build failed in Jenkins: brooklyn-master-windows #186

See -- Started by upstream project "brooklyn-master-build" build number 291 originally caused by: Started by timer [EnvInject] - Loading node environment variables. Building remotely on

Build failed in Jenkins: brooklyn-master-windows #185

See -- Started by upstream project "brooklyn-master-build" build number 290 originally caused by: Started by upstream project "brooklyn-server-master" build number 155 originally caused by:

Jenkins build is back to stable : brooklyn-master-build #290

See

[GitHub] brooklyn-server pull request #220: Added a percentage enricher

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #220: Added a percentage enricher

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/220 LGTM; merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server pull request #226: Expose assertServiceFailed(Entity) and as...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/226#discussion_r69489506 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSshCommandTest.java --- @@ -30,6 +30,8 @@ import static

[GitHub] brooklyn-server issue #226: Expose assertServiceFailed(Entity) and assertSer...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/226 @bostko we could include `SERVICE_STATE_EXPECTED` in the `assertServiceHealthy` - no strong feelings. It probably will never say actual is "running" if expected is not also something like

[jira] [Commented] (BROOKLYN-226) brooklyn support for eucalyptus

[ https://issues.apache.org/jira/browse/BROOKLYN-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361741#comment-15361741 ] Aled Sage commented on BROOKLYN-226: You need to use {{ec2}} rather than {{aws-ec2}}, for example

[jira] [Commented] (BROOKLYN-236) Catalog version ignores trailing zero: 1.10 treated as 1.1

[ https://issues.apache.org/jira/browse/BROOKLYN-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361735#comment-15361735 ] Aled Sage commented on BROOKLYN-236: Our examples have been changed to include quotes, and the docs

[jira] [Resolved] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-259. Resolution: Fixed > jcloudsByon location spec leaks location instances >

[jira] [Resolved] (BROOKLYN-280) br cli fails to login to brooklyn instances with self-signed SSL certs

[ https://issues.apache.org/jira/browse/BROOKLYN-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-280. Resolution: Fixed Fix Version/s: 0.10.0 > br cli fails to login to brooklyn instances with

Re: [PROPOSAL] Deleting orphaned locations

Sounds like a good idea. To clarify, does > It is important that the tool is run offline, in case a Brooklyn server is in > the middle of writing multiple new files. mean that Brooklyn must *not* be running when you use this tool? If so, can such a tool check this before it runs? Think it

[GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/155 I've PRed my changes to Andrew's branch but can re-do this to master if preferred, once Andrew's is merged. --- If your project is set up for it, you can reply to this email and have your

[jira] [Closed] (BROOKLYN-275) Private Key Data description in the Add BYON Location Wizard is misleading

[ https://issues.apache.org/jira/browse/BROOKLYN-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John McCabe closed BROOKLYN-275. Resolution: Fixed Fixed in https://github.com/apache/brooklyn-ui/pull/28 Thanks [~tbouron] >

[jira] [Resolved] (BROOKLYN-303) EmptyWindowsProcess provisioning fails with NPE

[ https://issues.apache.org/jira/browse/BROOKLYN-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-303. Resolution: Fixed Fix Version/s: 0.10.0 > EmptyWindowsProcess provisioning fails with NPE

[GitHub] brooklyn-docs pull request #86: Updated paths for usage-examples

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request #86: Updated paths for usage-examples

GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/86 Updated paths for usage-examples Paths used relative links, updated to use {{ site.path.guide }} You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-docs pull request #85: Split locations docs into more sections

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/85#discussion_r69469513 --- Diff: guide/ops/locations/_more-clouds.md --- @@ -26,404 +26,3 @@ is included below. You may also find these sources helpful: sometimes

[GitHub] brooklyn-docs pull request #85: Split locations docs into more sections

GitHub user duncangrant opened a pull request: https://github.com/apache/brooklyn-docs/pull/85 Split locations docs into more sections It is difficult to find the details for AWS softlayer in the locations doc as you have to scroll a long way so this commit splits them into

[GitHub] brooklyn-server issue #226: Expose assertServiceFailed(Entity) and assertSer...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/226 @bostko why is it checking the value of `SERVICE_STATE_EXPECTED`, rather than the value of `SERVICE_STATE_ACTUAL`? --- If your project is set up for it, you can reply to this email and

[GitHub] brooklyn-library pull request #47: Use Entities.descendantsAndSelf

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-library/pull/47 Use Entities.descendantsAndSelf Previously calling Entities.deprecated; that is not deprecated. This is dependent on first merging

Build failed in Jenkins: brooklyn-master-windows #184

See -- Started by upstream project "brooklyn-master-build" build number 289 originally caused by: Started by upstream project "brooklyn-server-master" build number 154 originally caused by:

Jenkins build is unstable: brooklyn-master-build #289

See

[GitHub] brooklyn-docs pull request #81: Expand OpenStack location docs

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #81: Expand OpenStack location docs

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-docs/pull/81 looks good - we don't host a JAR afaik so instructions are okay; new jclouds should fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Jenkins build is back to normal : brooklyn-server-master #154

See

[PROPOSAL] Deleting orphaned locations

Hi all, We are looking at implementing a "cleaner" that can remove orphaned locations from persisted state. _*Problem statement*_ In older versions of Brooklyn (e.g. prior to [1]), we sometimes did not unmanage locations when the associated entity was deleted. This means that the persisted

[GitHub] brooklyn-server pull request #225: Improve test cases

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #225: Improve test cases

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/225 Thanks @bostko - merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #226: Expose assertServiceFailed(Entity) and assertSer...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/226 @bostko I'm unsure about this. The problem is whether `assertServiceFailed` and `assertServiceHealthy` are general enough for all entities. The name "service" also looks out of place,

[GitHub] brooklyn-server pull request #226: Expose assertServiceFailed(Entity) and as...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/226#discussion_r69454029 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityAsserts.java --- @@ -223,4 +225,14 @@ public void run() { });

[GitHub] brooklyn-server pull request #226: Expose assertServiceFailed(Entity) and as...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/226#discussion_r69453865 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityAsserts.java --- @@ -223,4 +225,14 @@ public void run() { });

[GitHub] brooklyn-server pull request #229: Merge brooklyn.parameters in YAML files

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/229#discussion_r69450574 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -384,5 +387,73 @@ public static WeightedParameter

[GitHub] brooklyn-server pull request #229: Merge brooklyn.parameters in YAML files

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/229#discussion_r69448257 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -384,5 +387,73 @@ public static WeightedParameter

[GitHub] brooklyn-server pull request #229: Merge brooklyn.parameters in YAML files

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/229#discussion_r69448156 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -384,5 +387,73 @@ public static WeightedParameter

Build failed in Jenkins: brooklyn-server-master #153

See Changes: [aled.sage] Fixes BrooklynFeatureEnablement setting defaults -- [...truncated 29443 lines...] at java.net.Socket.(Socket.java:425) at

[GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/155 @grkvlt @geomacy can we get Geoff's changes (that are specific to the effector invocation) into this PR, and merge it? Or should we close this PR and have Geoff open a new PR with his

[GitHub] brooklyn-server pull request #227: Fixes BrooklynFeatureEnablement setting d...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #227: Fixes BrooklynFeatureEnablement setting defaults

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/227 @nakomis regarding docs, good question. There's not, except for the javadoc. Most end users won't touch this stuff, but agree it's still worth including in the docs. Note that

[GitHub] brooklyn-server pull request #225: Improve test cases

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/225#discussion_r69444633 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSshCommandTest.java --- @@ -278,6 +274,28 @@ public void

[GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...

Github user robertgmoss commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/218#discussion_r69442254 --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java --- @@ -81,7 +81,7 @@ public void

[GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...

Github user robertgmoss commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/218#discussion_r69441816 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindEntityTest.java --- @@ -310,7 +310,7 @@ public void testEntityTags()

Build failed in Jenkins: brooklyn-master-build #288

See -- [...truncated 45323 lines...] [INFO] Brooklyn Quick-Start Project Archetype . SKIPPED [INFO] Brooklyn Shared Package Files .. SKIPPED [INFO] Brooklyn DEB

[GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...

Github user robertgmoss commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/218#discussion_r69441669 --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java --- @@ -81,7 +81,7 @@ public void

[GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...

Github user robertgmoss commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/218#discussion_r69440147 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java --- @@ -100,30 +103,36 @@

[GitHub] brooklyn-server pull request #225: Improve test cases

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/225#discussion_r69440577 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSshCommandTest.java --- @@ -211,11 +213,9 @@ public void

[GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...

Github user robertgmoss commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/218#discussion_r69440473 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java --- @@ -655,34 +677,112 @@ public static boolean isDescendant(Entity

[GitHub] brooklyn-server pull request #225: Improve test cases

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/225#discussion_r69440408 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSshCommandTest.java --- @@ -278,6 +274,28 @@ public void

[GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...

Github user robertgmoss commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/218#discussion_r69440113 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java --- @@ -100,30 +103,36 @@

Build failed in Jenkins: brooklyn-master-windows #183

See -- Started by upstream project "brooklyn-master-build" build number 287 originally caused by: Started by upstream project "brooklyn-library-master" build number 36 originally caused by:

[GitHub] brooklyn-docs pull request #82: Catalog format more consistent

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #82: Catalog format more consistent

Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-docs/pull/82 @aledsage I'm going to merge this, as the other PRs are all good, but see my comment on `services` --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-dist pull request #39: Catalog format more consistent

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #222: Catalog format more consistent

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/222 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #228: Misc OSGi fixes

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #224: Fix VanillaJavaApp's stdin and env

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #219: Added identity method to DSL

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #218: Yaml entity refs: support $brooklyn:self()

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/218 @grkvlt we briefly changed the behaviour of `Propagator` to require that the producer be passed in (because previously the defaults were crazy - if no configuration, then propagate all