Jenkins build is back to normal : brooklyn-master-build #825

2017-02-14 Thread Apache Jenkins Server
See

[GitHub] brooklyn-server issue #521: fix unexpected AddChildrenEffector behaviour and...

2017-02-14 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/521 @tbouron Yes ... for once it gives a good error message: `requires either blueprint_type or blueprint_yaml`. You called it `brooklyn_yaml`! @aledsage Good comment re

[GitHub] brooklyn-server issue #485: `BundleMaker` utility routines making it easy to...

2017-02-14 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/485 I think discussion on ML has been 100% supportive of the direction this goes in, with a lot of ideas of where this could go, and no pushback on the piece part introduced here, including

[GitHub] brooklyn-server issue #480: Config self reference fix

2017-02-14 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/480 Re `TaskFactory` being a separate PR, that would mean massaging the tests and other places so there is a clean state where `TF` isn't supported, and a clean state where `TF` is supported.

Build failed in Jenkins: brooklyn-master-build #824

2017-02-14 Thread Apache Jenkins Server
See -- [...truncated 27 lines...] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at

[GitHub] brooklyn-server issue #480: Config self reference fix

2017-02-14 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/480 Rebased, and once #462 is merged this should be easier to review. Cherry-picking my "slow tests" meant it automatically left this PR which was nice. --- If your project is set up for

[GitHub] brooklyn-dist pull request #56: [READY FOR REVIEW] docker image, for standal...

2017-02-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #462: Inherit config default values

2017-02-14 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/462 @neykov @geomacy @aledsage Done. Hurrah. I've fixed the "declared keys" exclusions -- in the end @geomacy's suggestion re cleaning up the `resolveParameters` method was on point, and the

[GitHub] brooklyn-dist issue #56: [READY FOR REVIEW] docker image, for standalone or ...

2017-02-14 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-dist/pull/56 thanks @ahgittin, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-dist issue #56: [READY FOR REVIEW] docker image, for standalone or ...

2017-02-14 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-dist/pull/56 Thanks @neykov -- changes addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-client issue #39: adds flag for connecting to servers using self-si...

2017-02-14 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-client/pull/39 lgtm, tested against a server which runs on https but with a self-signed certificate --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Created] (BROOKLYN-438) Expose URL builder-like functionality as DSL

2017-02-14 Thread Svetoslav Neykov (JIRA)
Svetoslav Neykov created BROOKLYN-438: - Summary: Expose URL builder-like functionality as DSL Key: BROOKLYN-438 URL: https://issues.apache.org/jira/browse/BROOKLYN-438 Project: Brooklyn

[jira] [Commented] (BROOKLYN-421) Catalog libraries: externalized config for basic-auth credentials in url (via YAML)

2017-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866034#comment-15866034 ] ASF GitHub Bot commented on BROOKLYN-421: - Github user neykov commented on the issue:

[GitHub] brooklyn-server issue #551: BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(....

2017-02-14 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/551 https://issues.apache.org/jira/browse/BROOKLYN-437 https://issues.apache.org/jira/browse/BROOKLYN-438 --- If your project is set up for it, you can reply to this email and have your

[jira] [Created] (BROOKLYN-437) Deprecate Url.{encode,decode} and other uses of URLEncoder

2017-02-14 Thread Svetoslav Neykov (JIRA)
Svetoslav Neykov created BROOKLYN-437: - Summary: Deprecate Url.{encode,decode} and other uses of URLEncoder Key: BROOKLYN-437 URL: https://issues.apache.org/jira/browse/BROOKLYN-437 Project:

[GitHub] brooklyn-client issue #39: adds flag for connecting to servers using self-si...

2017-02-14 Thread robertgmoss
Github user robertgmoss commented on the issue: https://github.com/apache/brooklyn-client/pull/39 @geomacy I'm not sure why, but the global variable doesn't seem to be getting set - this PR makes it use a local flag instead, which seems more appropriate anyway, and crucially works!

[DISCUSSION] Determining which Brooklyn node address to advertise

2017-02-14 Thread Svetoslav Neykov
I'm trying to restrict access to the machines managed by Brooklyn using security groups - tightening jclouds' default behaviour of opening the "inboundPorts" to any source. Brooklyn obviously needs to have access to all managed machines. This means it needs to figure out the address it uses to

[jira] [Created] (BROOKLYN-436) HA nodes don't know the URL of the master

2017-02-14 Thread Svetoslav Neykov (JIRA)
Svetoslav Neykov created BROOKLYN-436: - Summary: HA nodes don't know the URL of the master Key: BROOKLYN-436 URL: https://issues.apache.org/jira/browse/BROOKLYN-436 Project: Brooklyn

[GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer

2017-02-14 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/529#discussion_r101047658 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -625,6 +630,30 @@ public

[GitHub] brooklyn-server issue #531: initial work to support HttpEntity

2017-02-14 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/531 @aledsage, @grkvlt can you have another look at this PR, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (BROOKLYN-421) Catalog libraries: externalized config for basic-auth credentials in url (via YAML)

2017-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865647#comment-15865647 ] ASF GitHub Bot commented on BROOKLYN-421: - Github user geomacy commented on the issue:

[GitHub] brooklyn-server issue #551: BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(....

2017-02-14 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/551 @aledsage, yes my comment above just meant that on reflection it's not invalid to use URI() to escape illegal characters in that way, but it still doesn't give us all we need; +1 to your

[GitHub] brooklyn-server pull request #462: Inherit config default values

2017-02-14 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r101001789 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server issue #551: BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(....

2017-02-14 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/551 @neykov I like your idea of something like: `$brooklyn:urlBuilder("http://host/path.to.jar;).userInfo(external("artifactory.credentials")).build()`. Or perhaps (IMO) in more

[GitHub] brooklyn-server pull request #531: initial work to support HttpEntity

2017-02-14 Thread andreaturli
Github user andreaturli closed the pull request at: https://github.com/apache/brooklyn-server/pull/531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #531: initial work to support HttpEntity

2017-02-14 Thread andreaturli
GitHub user andreaturli reopened a pull request: https://github.com/apache/brooklyn-server/pull/531 initial work to support HttpEntity - add HttpCommnadEffector - add CompositeEffector - add EntityInitializers util class to resolve DSL injected as params into the

[GitHub] brooklyn-server issue #531: initial work to support HttpEntity

2017-02-14 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/531 rebuild please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and