[GitHub] brooklyn-client issue #54: Fixed setting config. Added setting sensors

2017-06-14 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/54 @Graeme-Miller sounds good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[jira] [Commented] (BROOKLYN-465) CLI: Cannot set config on entities

2017-06-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049294#comment-16049294 ] ASF GitHub Bot commented on BROOKLYN-465: - Github user Graeme-Miller commented o

[GitHub] brooklyn-client issue #54: Fixed setting config. Added setting sensors

2017-06-14 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-client/pull/54 Actually, maybe all that is needed is some clarity about how to use this in the help documentation and some better error information. I was fixing this because of this Jira (ht

[GitHub] brooklyn-client issue #54: Fixed setting config. Added setting sensors

2017-06-14 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/54 Taking @neykov's point about backward compatiblity I'll reverse my suggestion above and say that `set` (with no args) remains as-is, while, say, `set -s` (s for string) is for auto-quoting th

[GitHub] brooklyn-client pull request #54: Fixed setting config. Added setting sensor...

2017-06-14 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/54#discussion_r121940013 --- Diff: cli/api/entity_config/config.go --- @@ -52,7 +52,7 @@ func ConfigValueAsBytes(network *net.Network, application, entity, config string

[GitHub] brooklyn-client pull request #54: Fixed setting config. Added setting sensor...

2017-06-14 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/54#discussion_r121902650 --- Diff: cli/commands/set.go --- @@ -51,9 +53,28 @@ func (cmd *SetConfig) Run(scope scope.Scope, c *cli.Context) { if err := net.VerifyLogin

[GitHub] brooklyn-client pull request #54: Fixed setting config. Added setting sensor...

2017-06-14 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/54#discussion_r121903310 --- Diff: cli/commands/set.go --- @@ -51,9 +53,28 @@ func (cmd *SetConfig) Run(scope scope.Scope, c *cli.Context) { if err := net.VerifyLogin

[GitHub] brooklyn-server issue #733: Makes core-tests.jar installable in the catalog,...

2017-06-14 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/733 @drigodwin I think the tests relies on a previously build `brooklyn-core-tests.jar`. Try building once with tests disabled and do a separate run of the test. --- If your project is set up f

[GitHub] brooklyn-client pull request #54: Fixed setting config. Added setting sensor...

2017-06-14 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/54#discussion_r121912681 --- Diff: cli/api/entity_config/config.go --- @@ -52,7 +52,7 @@ func ConfigValueAsBytes(network *net.Network, application, entity, config string

[GitHub] brooklyn-server pull request #678: JcloudsLocationCustomizer.onObtainError

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #678: JcloudsLocationCustomizer.onObtainError

2017-06-14 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/678 Build passes for me now, LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] brooklyn-docs pull request #197: Point to currently supported Java 8

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request #197: Point to currently supported Java 8

2017-06-14 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/197 Point to currently supported Java 8 Minor changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs java-8 Alternative